Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Take NULLs into account for DELTA_BINARY_PACKED#16317

Merged
Mytherin merged 4 commits intoduckdb:v1.2-histrionicusfrom
lnkuiper:issue16306
Feb 21, 2025
Merged

Take NULLs into account for DELTA_BINARY_PACKED#16317
Mytherin merged 4 commits intoduckdb:v1.2-histrionicusfrom
lnkuiper:issue16306

Conversation

@lnkuiper
Copy link
Collaborator

Fixes #16306

@xevix
Copy link
Contributor

xevix commented Feb 19, 2025

Confirmed the fix works on the dataset that triggered it. Thanks!

@duckdb-draftbot duckdb-draftbot marked this pull request as draft February 20, 2025 13:11
@lnkuiper
Copy link
Collaborator Author

lnkuiper commented Feb 20, 2025

This is running into an issue with uninitialized memory in CI, which I can reproduce locally. Will be a bit annoying to fix but I'll try a few Linux machines to see if it reproduces there.

EDIT: I think I got it

@lnkuiper lnkuiper marked this pull request as ready for review February 21, 2025 09:14
@Mytherin Mytherin merged commit 227d9d3 into duckdb:v1.2-histrionicus Feb 21, 2025
49 of 50 checks passed
@Mytherin
Copy link
Collaborator

Thanks!

krlmlr added a commit to duckdb/duckdb-r that referenced this pull request Mar 7, 2025
Take `NULL`s into account for `DELTA_BINARY_PACKED` (duckdb/duckdb#16317)
@lnkuiper lnkuiper deleted the issue16306 branch April 14, 2025 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Comments