Take NULLs into account for DELTA_BINARY_PACKED#16317
Merged
Mytherin merged 4 commits intoduckdb:v1.2-histrionicusfrom Feb 21, 2025
Merged
Take NULLs into account for DELTA_BINARY_PACKED#16317Mytherin merged 4 commits intoduckdb:v1.2-histrionicusfrom
NULLs into account for DELTA_BINARY_PACKED#16317Mytherin merged 4 commits intoduckdb:v1.2-histrionicusfrom
Conversation
Contributor
|
Confirmed the fix works on the dataset that triggered it. Thanks! |
Collaborator
Author
|
This is running into an issue with uninitialized memory in CI, which I can reproduce locally. Will be a bit annoying to fix but I'll try a few Linux machines to see if it reproduces there. EDIT: I think I got it |
Collaborator
|
Thanks! |
2 tasks
krlmlr
added a commit
to duckdb/duckdb-r
that referenced
this pull request
Mar 7, 2025
Take `NULL`s into account for `DELTA_BINARY_PACKED` (duckdb/duckdb#16317)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #16306