custom_extension_repository to also be the default autoinstall_extension_repository#16459
Merged
Mytherin merged 2 commits intoduckdb:v1.2-histrionicusfrom Mar 6, 2025
Conversation
923d307 to
f1cafe7
Compare
Contributor
Author
|
Unittester could also be updated using this, but that might (and will) break tests and require some more thoughts. |
Collaborator
|
Thanks for the PR! Makes sense to me. |
krlmlr
added a commit
to duckdb/duckdb-r
that referenced
this pull request
Apr 8, 2025
custom_extension_repository to also be the default autoinstall_extension_repository (duckdb/duckdb#16459)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently there are 2 settings that need to be overridden to change the default (remote) extension repository:
Having those point to different endpoint I think it's an historical artifact, and mostly used to test autoinstall and autoloading in our unittester.
Documentation do not mention
autoinstall_extension_repositoryat all, and I think users would assume settingcustom_extension_repositoryshould download from that one both these cases:The proposed solution, that I think should keep flexibility when needed (e.g. testing framework) while keeping most current workflow working is using
custom_extension_repositoryas default whenautoinstall_extension_repositoryis not set.Added a test, that in current DuckDB fails while INSTALLing the extension from default repo (even though
custom_extension_repositoryhad been set):Fixes also a minor mistake within an
#ifdef.