[BugFix]: Swap join children, not left and right set#16487
Merged
Mytherin merged 2 commits intoduckdb:v1.2-histrionicusfrom Mar 4, 2025
Merged
[BugFix]: Swap join children, not left and right set#16487Mytherin merged 2 commits intoduckdb:v1.2-histrionicusfrom
Mytherin merged 2 commits intoduckdb:v1.2-histrionicusfrom
Conversation
Contributor
Author
|
@Mytherin I think the tpcds regression is a false alarm. I ran the Local benchmarking doesn't reveal much of a difference With Fix Without Fix |
Collaborator
|
Thanks! LGTM |
krlmlr
added a commit
to duckdb/duckdb-r
that referenced
this pull request
Mar 7, 2025
[BugFix]: Swap join children, not left and right set (duckdb/duckdb#16487) bump sqlsmith extension tag (duckdb/duckdb#16488) Bump `postgres_scanner` and `fts` extensions (duckdb/duckdb#16492) [tests] Multiple FORMAT in copy, only last one matters (duckdb/duckdb#16493) [Python Dev] `pyproject.toml` should not use `oldest-supported-numpy` anymore (duckdb/duckdb#16486) Fixed reading piped JSON (duckdb/duckdb#16480)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Only the left and right set were being swapped, but not the actual join children. I think this case is very rare, hence why it has not been caught in our current CI suite.
Fixes #16426
Fixes https://github.com/duckdblabs/duckdb-internal/issues/4323