Conversation
|
Comment relevant for all 3 PRs: this is handy to have in upcoming 1.2.2 (if so, process is rebase the PR to be against Regarding the tests, I would think it makes sense, probably to be added in https://github.com/duckdb/duckdb/blob/main/.github/workflows/NightlyTests.yml, these are run once per day and then failures are flagged to relevant team member. |
|
Thanks.
|
|
|
On testing, @Mytherin to make a call on how to move forward. Thanks |
|
Thanks! We do run these warnings - I think the main thing is the compiler version. We could consider running these checks also with a newer compiler. |
Avoid UMA (duckdb/duckdb#16641) Add libs folder to bundled static libs (duckdb/duckdb#16655)
This is one out of three PRs to avoid accessing uninitialized memory. This change was necessary to satisfy CRAN's incoming checks.
CRAN uses gcc 14.2.0 with compile commands similar to the following:
I believe they are looking for
-Wuninitializedand-Wmaybe-uninitialized.Would you consider having similar checks as part of the CI/CD pipeline here, perhaps with
-Werror?