Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Comments

bump out-of-tree extensions to v1.2.2#16913

Merged
Mytherin merged 8 commits intoduckdb:v1.2-histrionicusfrom
Tmonster:bump-extensions
Apr 3, 2025
Merged

bump out-of-tree extensions to v1.2.2#16913
Mytherin merged 8 commits intoduckdb:v1.2-histrionicusfrom
Tmonster:bump-extensions

Conversation

@Tmonster
Copy link
Contributor

@Tmonster Tmonster commented Mar 31, 2025 •
edited
Loading

bump duckdb-httpfs, and duckdb-aws to latest version of v1.2-histrionicus

Also removing DONT_LINK from avro since duckdb-iceberg tries to automatically load it, and if it is not available duckdb-iceberg will through an error. This means any time iceberg is autoloaded and avro is not available/linked, then statements/tests will fail.

EDIT: not bumping iceberg in this PR. Want to try and isolate errors.

EDIT2: Not bumping aws, there seems to be an issue with windows and provider credential_chain. Want to try and debug it on the windows laptop first

@Mytherin
Copy link
Collaborator

Mytherin commented Mar 31, 2025

LinuxRelease / Checks extension entries (pull_request) failure seems related - could you have a look?

@carlopi
Copy link
Contributor

carlopi commented Mar 31, 2025 •
edited
Loading

The Windows error message is also weird, my explanation would be persistent secret being shared across tests (?), and iceberg being auto-loaded first and then autoloading avro on load.

Or even if not exactly that, it points to something off.

@carlopi
Copy link
Contributor

carlopi commented Mar 31, 2025

Actually also the "Checks extension entries" is connected:

Invalid Input Error: Initialization function "iceberg_init" from file "build/release/repository/iceberg/iceberg.duckdb_extension" threw an exception: "An error occurred while trying to automatically install the required extension 'avro':
Extension "/home/runner/.duckdb/extensions/618d76f66d/linux_amd64/avro.duckdb_extension" not found.

Candidate extensions: "arrow", "azure", "parquet", "jemalloc", "autocomplete""
Invalid Input Error: Initialization function "iceberg_init" from file "build/release/repository/iceberg/iceberg.duckdb_extension" threw an exception: "An error occurred while trying to automatically install the required extension 'avro':
Extension "/home/runner/.duckdb/extensions/618d76f66d/linux_amd64/avro.duckdb_extension" not found.

Candidate extensions: "arrow", "azure", "parquet", "jemalloc", "autocomplete""

@duckdb-draftbot duckdb-draftbot marked this pull request as draft April 1, 2025 11:36
@Tmonster Tmonster marked this pull request as ready for review April 1, 2025 11:36
@carlopi
Copy link
Contributor

carlopi commented Apr 1, 2025

@Tmonster: I think almost ready, but for aws failure in Windows CI: windows failure need fixing aws side?

[828/1089]: D:/a/duckdb/duckdb/build/release/_deps/aws_extension_fc-src/test/sql/aws_secret_aws.test ()
FAILURE IN RUNNING TEST
--------------------
RETURNCODE
--------------------
1
--------------------
STDOUT
--------------------
Filters: D:/a/duckdb/duckdb/build/release/_deps/aws_extension_fc-src/test/sql/aws_secret_aws.test


[0/1] (0%): D:/a/duckdb/duckdb/build/release/_deps/aws_extension_fc-src/test/...

~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

unittest.exe is a Catch v2.13.7 host application.

Run with -? for options



-------------------------------------------------------------------------------

D:/a/duckdb/duckdb/build/release/_deps/aws_extension_fc-src/test/sql/

aws_secret_aws.test

-------------------------------------------------------------------------------

D:/a/duckdb/duckdb/test/sqlite/test_sqllogictest.cpp(219)

...............................................................................



D:/a/duckdb/duckdb/build/release/_deps/aws_extension_fc-src/test/sql/aws_secret_aws.test(11): FAILED:

explicitly with message:

  0




[1/1] (100%): D:/a/duckdb/duckdb/build/release/_deps/aws_extension_fc-src/tes...

===============================================================================

test cases: 1 | 1 failed

assertions: 1 | 1 failed




--------------------
STDERR
--------------------
================================================================================

Query unexpectedly failed! (D:/a/duckdb/duckdb/build/release/_deps/aws_extension_fc-src/test/sql/aws_secret_aws.test:11)!

================================================================================

CREATE SECRET s1 (

    TYPE AWS,

    PROVIDER credential_chain

);

================================================================================

Invalid Input Error: Secret provider 'credential_chain' not found for type 'aws'

this means the secret type needs registering duckdb side?

@Tmonster
Copy link
Contributor Author

Tmonster commented Apr 1, 2025

Relevant failing test for AWS

/test/sql/aws_secret_aws.test

@duckdb-draftbot duckdb-draftbot marked this pull request as draft April 2, 2025 08:24
@Tmonster Tmonster marked this pull request as ready for review April 2, 2025 08:27
@duckdb-draftbot duckdb-draftbot marked this pull request as draft April 2, 2025 09:02
@Tmonster Tmonster marked this pull request as ready for review April 2, 2025 09:12
@carlopi carlopi removed the CI Failure label Apr 2, 2025
carlopi
carlopi approved these changes Apr 2, 2025
View reviewed changes
Copy link
Contributor

@carlopi carlopi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks about right! Thanks

@duckdb-draftbot duckdb-draftbot marked this pull request as draft April 3, 2025 08:39
@Tmonster Tmonster marked this pull request as ready for review April 3, 2025 08:39
@duckdb-draftbot duckdb-draftbot marked this pull request as draft April 3, 2025 09:40
@Tmonster Tmonster marked this pull request as ready for review April 3, 2025 09:40
carlopi
carlopi reviewed Apr 3, 2025
View reviewed changes
@duckdb-draftbot duckdb-draftbot marked this pull request as draft April 3, 2025 11:12
carlopi
carlopi approved these changes Apr 3, 2025
View reviewed changes
Copy link
Contributor

@carlopi carlopi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again.
This should likely be good, and after latest change (that include duckdb/duckdb-aws#74), this should also fix the Windows and Wasm CI issues

@Tmonster Tmonster marked this pull request as ready for review April 3, 2025 11:14
@carlopi
Copy link
Contributor

carlopi commented Apr 3, 2025

@Mytherin: this is still expected to fail, since arrow and possibly other extensions have not been adapted yet, BUT given this is now failing later, and this contain still relevant logic to handle https and aws bump, I think it's worth to have this in while looking at fixing the rest.

@Mytherin Mytherin merged commit 099fba2 into duckdb:v1.2-histrionicus Apr 3, 2025
50 of 51 checks passed
@Mytherin
Copy link
Collaborator

Mytherin commented Apr 3, 2025

Sure - thanks!

krlmlr added a commit to duckdb/duckdb-r that referenced this pull request Apr 8, 2025
@krlmlr
vendor: Update vendored sources to duckdb/duckdb@099fba2
5b30cd6 
bump out-of-tree extensions to v1.2.2 (duckdb/duckdb#16913)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@carlopi carlopi carlopi approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Ready To Merge

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Tmonster @Mytherin @carlopi