Parquet Reader: only read strings as fixed length strings if the type is FIXED_LEN_BYTE_ARRAY#17723
Merged
Mytherin merged 2 commits intoduckdb:v1.3-ossivalisfrom May 30, 2025
Merged
Conversation
… is FIXED_LEN_BYTE_ARRAY
ywelsch
reviewed
May 30, 2025
Contributor
ywelsch
left a comment
There was a problem hiding this comment.
There is similar code in ParquetDecimalUtils::CreateReader
Does that need adjustment too?
Collaborator
Author
|
Yes, good point - that should indeed follow the same logic. |
krlmlr
added a commit
to duckdb/duckdb-r
that referenced
this pull request
Jun 2, 2025
Parquet Reader: only read strings as fixed length strings if the type is FIXED_LEN_BYTE_ARRAY (duckdb/duckdb#17723) [SQLLogicTester] Replace keywords in `<FILE>:pattern` result for the `query` statement (duckdb/duckdb#17710)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a regression introduced in #16161
Type length may also be set for variable-length byte arrays (in which case it should be ignored).