Fix ICE with Windows ARM64 (1.3)#17846
Merged
Mytherin merged 1 commit intoduckdb:v1.3-ossivalisfrom Jun 8, 2025
Merged
Conversation
This is a 1.3 backport of PR duckdb#17844. This change attempts to fix the ICE that happens on Windows with MSVC ARM64 toolchains - with both cross-compiling and native ones. Abbreviated example (stacktrace can differ): ``` CL.exe /c /IC:[...] /nologo /W1 /WX- /diagnostics:column /O2 /Ob2 /Oy- /D[...] /EHsc /MD /GS /fp:precise /Zc:[...] /Fo"[...]" /Fd"[...]" /external:W1 /Gd /TP /wd[...] /analyze- /errorReport:queue /utf-8 /bigobj C:\a\duckdb\duckdb\extension\core_functions\scalar\date\ub_duckdb_core_functions_date.cpp base type 1 bad size 16 base type 1 bad size 16 base type 1 bad size 16 base type 1 bad size 16 CL!RaiseException()+0x60 CL!RaiseException()+0x60 CL!InvokeCompilerPass()+0x7f7f CL!InvokeCompilerPass()+0x171 [...]Microsoft.CppCommon.targets(781,5): error MSB6006: "CL.exe" exited with code -529706956. [[...].vcxproj] ``` It lowers inlining requirements for `ub_duckdb_core_functions_date.cpp` on MSVC ARM64 `Release` and `RelWithDebInfo` builds from `/Ob2`: > The default value under /O1 and /O2. Allows the compiler to expand > any function not explicitly marked for no inlining. to `/Ob1`: > Allows expansion only of functions marked inline, __inline, or > __forceinline, or in a C++ member function defined in a class > declaration. Testing: cannot reproduce this locally with cross-compiling, only tested with partial build on GH actions (native and cross). Fixes: duckdblabs/duckdb-internal#5079
Collaborator
|
Thanks! |
github-actions bot
pushed a commit
to duckdb/duckdb-r
that referenced
this pull request
Jun 8, 2025
[Fix] WAL replay catalog error in AddForeignKeyConstraint (duckdb/duckdb#17830) Fix ICE with Windows ARM64 (1.3) (duckdb/duckdb#17846)
github-actions bot
added a commit
to duckdb/duckdb-r
that referenced
this pull request
Jun 8, 2025
[Fix] WAL replay catalog error in AddForeignKeyConstraint (duckdb/duckdb#17830) Fix ICE with Windows ARM64 (1.3) (duckdb/duckdb#17846) Co-authored-by: krlmlr <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a 1.3 backport of PR #17844.
This change attempts to fix the ICE that happens on Windows with MSVC ARM64 toolchains - with both cross-compiling and native ones.
Abbreviated example (stacktrace can differ):
It lowers inlining requirements for
ub_duckdb_core_functions_date.cppon MSVC ARM64ReleaseandRelWithDebInfobuilds from/Ob2:to
/Ob1:Testing: cannot reproduce this locally with cross-compiling, only tested with partial build on GH actions (native and cross).
Fixes: duckdblabs/duckdb-internal#5079