Early-out on catalog errors to prevent GetDatabases#17865
Merged
Mytherin merged 5 commits intoduckdb:v1.3-ossivalisfrom Jun 12, 2025
Merged
Early-out on catalog errors to prevent GetDatabases#17865Mytherin merged 5 commits intoduckdb:v1.3-ossivalisfrom
Mytherin merged 5 commits intoduckdb:v1.3-ossivalisfrom
Conversation
Mytherin
reviewed
Jun 10, 2025
Collaborator
There was a problem hiding this comment.
Thanks for the PR!
Instead of having an early-out specifically for max_schema_count = 0, maybe we can push the max_schema_count into the GetDatabases? Given each database has at least one schema we should never need to fetch more than max_schema_count databases.
Collaborator
|
Thanks! |
github-actions bot
pushed a commit
to duckdb/duckdb-r
that referenced
this pull request
Jun 12, 2025
Early-out on catalog errors to prevent GetDatabases (duckdb/duckdb#17865)
github-actions bot
added a commit
to duckdb/duckdb-r
that referenced
this pull request
Jun 12, 2025
Early-out on catalog errors to prevent GetDatabases (duckdb/duckdb#17865) Co-authored-by: krlmlr <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CatalogErrorMaxSchemasSettingalready allows limiting the number of schemas traversed to construct thedid you meanpart of an error message. However, with A LOT of attached databases, we would still call intodb_manager.GetDatabases(context), causing aO(attached_databases)CatalogSet::Scan.With this PR, setting
SET catalog_error_max_schemas = 0early-outs before scanning the catalog set.