Deprecated std::stringstream#17894
Merged
Mytherin merged 2 commits intoduckdb:v1.3-ossivalisfrom Jun 12, 2025
Merged
Conversation
…assic on construction
aa70d63 to
7b87023
Compare
Collaborator
|
Thanks! |
github-actions bot
pushed a commit
to duckdb/duckdb-r
that referenced
this pull request
Jun 12, 2025
Deprecated std::stringstream (duckdb/duckdb#17894) Add support for deserializing multiple json-serialized statements (duckdb/duckdb#17902)
github-actions bot
added a commit
to duckdb/duckdb-r
that referenced
this pull request
Jun 12, 2025
Deprecated std::stringstream (duckdb/duckdb#17894) Add support for deserializing multiple json-serialized statements (duckdb/duckdb#17902) Co-authored-by: krlmlr <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Improved version of #17807, using infrastructure from #17866 to check
std::stringstreamare not used anymore at compile time.Original problem I had bumped in duckdb-wasm, where there would be some yet to be properly understood factor that would change the global static default locale to an unsupported one that would, via a SQL call to
duckdb_tablesend up calling a locale-influenced stringstream that would then throw.Testing can also be done on native applying the following diff, yet to be added as testing mode
Also cleans up comment from previous PR review at #17866 (comment)
Note that other streams might (and will) have the same problems, so it would be handy to expand this further, here taking it one step further.