Fix for IsDenseRange check in filter_combiner #17988
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Thanks! LGTM |
|
@pdet I reported the bug and looking though the fix a bit, it seems like the fix makes the function Just wondering how the queries based on UHUGEINT are impacted compared with HUGEINT even though both have 128bits? |
github-actions bot
pushed a commit
to duckdb/duckdb-r
that referenced
this pull request
Jun 27, 2025
Fix for IsDenseRange check in filter_combiner (duckdb/duckdb#17988)
github-actions bot
added a commit
to duckdb/duckdb-r
that referenced
this pull request
Jun 27, 2025
Fix for IsDenseRange check in filter_combiner (duckdb/duckdb#17988) Co-authored-by: krlmlr <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We cast the data to
HUGEINTbut if our data isUHUGEINTthere is no guarantee we can cast it toHUGEINTFix: #17827