Fix incorrect results in index scan #18058
Merged
+67
−49
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! Would it be possible to add a test for this as well? |
github-actions bot
pushed a commit
to duckdb/duckdb-r
that referenced
this pull request
Jun 28, 2025
Fix incorrect results in index scan (duckdb/duckdb#18058)
github-actions bot
added a commit
to duckdb/duckdb-r
that referenced
this pull request
Jun 28, 2025
Fix incorrect results in index scan (duckdb/duckdb#18058) Co-authored-by: krlmlr <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The filter in https://github.com/duckdblabs/duckdb-internal/issues/5186 contains a conjunction, and the conjunction contains another conjunction with an
INfilter.Before this PR, we just propagate the values of the inner
INfilter, without also comparing them to the otherCONJUNCTION_ANDcomparisons of the outer level.I.e., before this fix, we would look up keys 10017, 10011, 1009, and 1004, even though the outer comparisons contain
<= 10011and>=10009.Now, we propagate inner
INfilter values, and also compare them against outerINfilter values (union) and outer comparisons.