Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Check if GetLastSegment is not nullptr in ColumnData::RevertAppend #18171

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jul 8, 2025
+35 −0
Merged

Check if GetLastSegment is not nullptr in ColumnData::RevertAppend #18171

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
a8ecde5
check if nullptr first
Jul 7, 2025
94d2f29
don't use same name as test config db
Jul 7, 2025
b57e13a
also rename db name
Jul 7, 2025
8c319c2
move to separate test and add no_alternative_verify
Jul 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions src/storage/table/column_data.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -498,6 +498,9 @@ void ColumnData::RevertAppend(row_t start_row) {
auto l = data.Lock();
// check if this row is in the segment tree at all
auto last_segment = data.GetLastSegment(l);
if (!last_segment) {
return;
}
if (NumericCast<idx_t>(start_row) >= last_segment->start + last_segment->count) {
// the start row is equal to the final portion of the column data: nothing was ever appended here
D_ASSERT(NumericCast<idx_t>(start_row) == last_segment->start + last_segment->count);
Expand Down
32 changes: 32 additions & 0 deletions test/fuzzer/sqlsmith/nullif_map_with_config.test
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,32 @@
# name: test/fuzzer/sqlsmith/nullif_map_with_config.test
# description: Test nullif on maps with config (internal issue 5232)
# group: [sqlsmith]

require no_alternative_verify

statement ok
PRAGMA enable_verification

statement ok
ATTACH '__TEST_DIR__/issue5232.db' as issue5232 (STORAGE_VERSION 'latest');

statement ok
USE issue5232;

statement ok
SET storage_compatibility_version='latest';

statement ok
SET max_memory='1234kb';

statement ok
CREATE TABLE tbl(map MAP(VARCHAR, VARCHAR));;

statement ok
INSERT INTO tbl VALUES(MAP([], []));

# should not segv
statement error
INSERT INTO tbl VALUES(MAP(['key1', 'key2'], ['🦆🦆🦆🦆🦆🦆', 'goose']));
----
TransactionContext Error: Failed to commit: could not allocate block
Loading