Allow user type with schema defined to have array bounds #18342
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
The failing test seems unrelated, but I don't know why it happens. I'll look into it |
Member
|
@Dtenwolde can you re-generate the parser for this PR please? |
# Conflicts: # third_party/libpg_query/src_backend_parser_gram.cpp
Member
|
another merge and parser-regenerate please |
Collaborator
|
Thanks! |
github-actions bot
pushed a commit
to duckdb/duckdb-r
that referenced
this pull request
Sep 10, 2025
Allow user type with schema defined to have array bounds (duckdb/duckdb#18342) Issue template: Add the Python repository (duckdb/duckdb#18928)
github-actions bot
added a commit
to duckdb/duckdb-r
that referenced
this pull request
Sep 10, 2025
Allow user type with schema defined to have array bounds (duckdb/duckdb#18342) Issue template: Add the Python repository (duckdb/duckdb#18928) Co-authored-by: krlmlr <[email protected]>
This was referenced Oct 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://github.com/duckdblabs/duckdb-internal/issues/5185
Previously user defined types could not have a schema defined and array bounds which was a small oversight in the parser. I updated some tests to reflect this change.
Only question is related to user types from different catalogs which give a confusing error (Perhaps best tackled in a separate issue if deemed serious enough)
This returns:
Catalog Error: Type with name bar does not exist! Did you mean "db2.schema3.bar"?I also commented out
D_ASSERT(count == static_cast<size_t>(std::pow(2, neighbors.size()) - 1));because it caused tests to fail but seems unrelated (see https://github.com/duckdblabs/duckdb-internal/issues/5342). I'll wait for #18344 to be merged and remove the commented code