[Dev] Bit of code cleanup in (parquet) ColumnWriter #19063
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…l, use range inserts, deduplicate some logic in ArrayColumnWriter
Collaborator
|
Thanks! |
Collaborator
|
Just realized this is going into |
krlmlr
added a commit
to duckdb/duckdb-r
that referenced
this pull request
Sep 29, 2025
[Dev] Bit of code cleanup in (parquet) ColumnWriter (duckdb/duckdb#19063) Include BeginQuery in latency metric (duckdb/duckdb#19064) Switching core extension upload to dedicated credentials (duckdb/duckdb#19061)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While going through the code I noticed the use of
std::vector<bool>, this is a space-efficient specialization ofstd::vector, but it's not exactly cpu efficient.Other than that, minor clean up.