Always execute cast and try_cast if they are not invertible #19010
+40
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tmonster
reviewed
Sep 18, 2025
| # group: [optimizer] | ||
|
|
||
| statement ok | ||
| pragma disable_optimizer; |
There was a problem hiding this comment.
Can we remove this? And can we add the statement pragma enable_verification?
| INSERT INTO t0(c0, c1) VALUES (890608529, false); | ||
|
|
||
| statement ok | ||
| pragma enable_optimizer; |
Tmonster
reviewed
Sep 18, 2025
There was a problem hiding this comment.
seems like you added an empty file here. Can you take this out?
There was a problem hiding this comment.
Sorry for that. I should have double-checked the commit.
|
Thanks! |
krlmlr
added a commit
to duckdb/duckdb-r
that referenced
this pull request
Sep 29, 2025
Always execute cast and try_cast if they are not invertible (duckdb/duckdb#19010) add a bunch of expected error messages to old macro tests and fix iss… (duckdb/duckdb#19042) [unittest] Fixes so that '{BASE_TEST_NAME}' can be used within --on-new-connection (duckdb/duckdb#19056)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes https://github.com/duckdblabs/duckdb-internal/issues/5876
fixes #18967
Together with @Tmonster we managed to come up with a fix. We identified two separate issue.
To solve this we identified two solutions. One option is to change the functionality and when the cast is not invertible always run the cast or try_cast, but that is more work for the engine. The other option is to keep the old functionality, and just fix the inconsistency