Check for unresolved parameters when binding CREATE MACRO ... AS TABLE
#19196
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Thanks! |
github-actions bot
pushed a commit
to duckdb/duckdb-r
that referenced
this pull request
Oct 1, 2025
Check for unresolved parameters when binding `CREATE MACRO ... AS TABLE` (duckdb/duckdb#19196)
krlmlr
added a commit
to duckdb/duckdb-r
that referenced
this pull request
Oct 2, 2025
Check for unresolved parameters when binding `CREATE MACRO ... AS TABLE` (duckdb/duckdb#19196)
github-actions bot
added a commit
to duckdb/duckdb-r
that referenced
this pull request
Oct 2, 2025
* vendor: Update vendored sources to duckdb/duckdb@9eccb88 Check for unresolved parameters when binding `CREATE MACRO ... AS TABLE` (duckdb/duckdb#19196) * [create-pull-request] automated change (#1597) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> --------- Co-authored-by: krlmlr <[email protected]> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
2 tasks
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since v1.4.0, we bind table macros upon creation, just like we do for scalar macros. However, there were some issues where we did not properly throw upon finding unresolved parameters. This PR addresses that.
Fixes #19142
Fixes https://github.com/duckdblabs/duckdb-internal/issues/6081