Fix #18139: correctly initialize flush size in MemoryStream, and re-use writer states #19398
+29
−20
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
github-actions bot
pushed a commit
to duckdb/duckdb-r
that referenced
this pull request
Oct 21, 2025
Fix duckdb/duckdb#18139: correctly initialize flush size in MemoryStream, and re-use writer states (duckdb/duckdb#19398)
github-actions bot
added a commit
to duckdb/duckdb-r
that referenced
this pull request
Oct 21, 2025
Fix duckdb/duckdb#18139: correctly initialize flush size in MemoryStream, and re-use writer states (duckdb/duckdb#19398) Co-authored-by: krlmlr <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #18139
The performance variation comes from us triggering a poor case in MacOS' allocator - the issue doesn't occur outside of MacOS and requires a specific number of threads. We can avoid the issue (and it is generally good practice anyway) by doing fewer (re)-allocations.
This was already partially fixed once before in #18174 but that seems to have gotten lost in the refactor of #17692. This PR brings back that fix and adds an additional fix by reducing the number of
CSVWriterStatethat are instantiated during batch writes.