Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Fix correlated column binding in ConstantBinder#19945

Merged
Mytherin merged 7 commits intoduckdb:v1.4-andiumfrom
d-justen:constant-binder-fix
Nov 28, 2025
Merged

Fix correlated column binding in ConstantBinder#19945
Mytherin merged 7 commits intoduckdb:v1.4-andiumfrom
d-justen:constant-binder-fix

Conversation

@d-justen
Copy link
Contributor

Prevent ConstantBinder from trying to bind correlated columns

Fixes #16826
Fixes duckdblabs/duckdb-internal#4507

@duckdb-draftbot duckdb-draftbot marked this pull request as draft November 26, 2025 15:33
@d-justen d-justen marked this pull request as ready for review November 26, 2025 15:33
@duckdb-draftbot duckdb-draftbot marked this pull request as draft November 26, 2025 15:49
@d-justen d-justen marked this pull request as ready for review November 26, 2025 16:28
@Mytherin
Copy link
Collaborator

Thanks! A simpler solution that is more local to the constant binder is to throw directly when encountering a column ref in ConstantBinder::BindExpression. We only bind correlated columns when returning a BindResult - throwing directly aborts the binding. Perhaps we can try that approach here?

@duckdb-draftbot duckdb-draftbot marked this pull request as draft November 27, 2025 09:00
@d-justen d-justen marked this pull request as ready for review November 27, 2025 09:02
@Mytherin Mytherin merged commit 65ce088 into duckdb:v1.4-andium Nov 28, 2025
104 checks passed
github-actions bot pushed a commit to duckdb/duckdb-r that referenced this pull request Nov 28, 2025
Fix correlated column binding in ConstantBinder (duckdb/duckdb#19945)
Issue duckdb/duckdb#19916: WASM Time Zones (duckdb/duckdb#19918)
Bump: spatial (duckdb/duckdb#19943)
github-actions bot added a commit to duckdb/duckdb-r that referenced this pull request Nov 28, 2025
Fix correlated column binding in ConstantBinder (duckdb/duckdb#19945)
Issue duckdb/duckdb#19916: WASM Time Zones (duckdb/duckdb#19918)
Bump: spatial (duckdb/duckdb#19943)

Co-authored-by: krlmlr <[email protected]>
@d-justen d-justen deleted the constant-binder-fix branch December 5, 2025 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants