-
Notifications
You must be signed in to change notification settings - Fork 2.8k
Add email for first program creation in onboardProgram #2464
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
WalkthroughThe changes introduce a new email template for welcoming users who create a program, update the program creation logic to send this email, and refine the onboarding logic for program creation by checking the workspace's default program status instead of counting existing programs. Additionally, several dashboard pages were enhanced with contextual title information and links, and the program welcome modal's steps and styling were updated. Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant WebApp
participant EmailService
User->>WebApp: Create Program Request (with email)
WebApp->>WebApp: Create Program & related setup
WebApp->>EmailService: Send ProgramWelcome email (with program & workspace info)
EmailService-->>User: Deliver Welcome Email
WebApp-->>User: Respond with program creation result
Poem
✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
|
🤖 Bug0 QA Agent Here are the results of the automated tests for PR #2464:
To re-run the tests, please comment |
|
🤖 Bug0 QA Agent Here are the results of the automated tests for PR #2464:
To re-run the tests, please comment |
de5e9c1 to
2a78029
Compare
|
🤖 Bug0 QA Agent Here are the results of the automated tests for PR #2464:
To re-run the tests, please comment |
|
🤖 Bug0 QA Agent Here are the results of the automated tests for PR #2464:
To re-run the tests, please comment |
|
🤖 Bug0 QA Agent Here are the results of the automated tests for PR #2464:
To re-run the tests, please comment |
|
🤖 Bug0 QA Agent Here are the results of the automated tests for PR #2464:
To re-run the tests, please comment |
|
🤖 Bug0 QA Agent Here are the results of the automated tests for PR #2464:
To re-run the tests, please comment |
|
🤖 Bug0 QA Agent Here are the results of the automated tests for PR #2464:
To re-run the tests, please comment |
|
🤖 Bug0 QA Agent Here are the results of the automated tests for PR #2464:
To re-run the tests, please comment |
|
🤖 Bug0 QA Agent Here are the results of the automated tests for PR #2464:
To re-run the tests, please comment |
|
🤖 Bug0 QA Agent Here are the results of the automated tests for PR #2464:
To re-run the tests, please comment |
|
@CodeRabbit final review |
|
Tip For best results, initiate chat on the files or code changes. 🧩 Analysis chainI'll conduct a comprehensive final review of the changes in this PR. Let me examine the key files to ensure everything looks good. 🏁 Script executed: Length of output: 14706 @steven-tey Excellent work on this PR! 🎉 The implementation looks solid and follows best practices. Here's my final review: ✅ Strengths1. Clean Architecture
2. Robust Error Handling
3. Optimized Database Logic
4. Professional Email Template
5. User Experience
🔍 Code QualityThe implementation demonstrates:
📧 Email Template HighlightsThe
✅ Final VerdictThis PR is ready to merge! The implementation is well-thought-out, follows established patterns, and provides a great user experience for new program creators. The email will help users get started quickly with their new programs. All automated tests are passing, and the code quality is excellent. Great job! 🚀 🐰 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🔭 Outside diff range comments (1)
apps/web/ui/modals/program-welcome-modal.tsx (1)
51-55: Query-param key mismatch prevents modal from closing cleanlyYou delete
program-onboardedinonClosebut deleteonboarded-programwhen the “Get started” button is clicked. One of these keys is wrong, so the modal may re-open unexpectedly.- queryParams({ - del: ["onboarded-program"], - }) + queryParams({ + del: ["program-onboarded"], + })Double-check any code that sets this param to keep behaviour consistent.
Also applies to: 115-119
🧹 Nitpick comments (1)
apps/web/ui/modals/program-welcome-modal.tsx (1)
95-96: Minor a11y nit – add focus styling to anchor buttonsThe new font styling is fine, but the anchors still lack a visible focus outline. Consider adding the Tailwind
focus-visible:outlineutilities for keyboard users.-className="flex items-center gap-2 text-sm font-medium text-neutral-800 underline decoration-dotted" +className="flex items-center gap-2 text-sm font-medium text-neutral-800 underline decoration-dotted focus-visible:outline focus-visible:outline-2 focus-visible:outline-offset-2 focus-visible:outline-green-500"
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (6)
apps/web/app/app.dub.co/(dashboard)/[slug]/(ee)/program/discounts/page.tsx(1 hunks)apps/web/app/app.dub.co/(dashboard)/[slug]/(ee)/program/partners/page.tsx(1 hunks)apps/web/app/app.dub.co/(dashboard)/[slug]/(ee)/program/payouts/page.tsx(1 hunks)apps/web/app/app.dub.co/(dashboard)/[slug]/(ee)/program/rewards/page.tsx(1 hunks)apps/web/ui/modals/program-welcome-modal.tsx(3 hunks)packages/email/src/templates/program-welcome.tsx(1 hunks)
✅ Files skipped from review due to trivial changes (4)
- apps/web/app/app.dub.co/(dashboard)/[slug]/(ee)/program/payouts/page.tsx
- apps/web/app/app.dub.co/(dashboard)/[slug]/(ee)/program/rewards/page.tsx
- apps/web/app/app.dub.co/(dashboard)/[slug]/(ee)/program/partners/page.tsx
- apps/web/app/app.dub.co/(dashboard)/[slug]/(ee)/program/discounts/page.tsx
🚧 Files skipped from review as they are similar to previous changes (1)
- packages/email/src/templates/program-welcome.tsx
⏰ Context from checks skipped due to timeout of 90000ms (1)
- GitHub Check: build
🔇 Additional comments (2)
apps/web/ui/modals/program-welcome-modal.tsx (2)
30-33: Copy change looks good
Updated wording is clearer and action-oriented. No issues spotted.
41-45: ```shell
#!/bin/bash
set -eecho "=== Occurrences of '/dashboard/${workspaceSlug}' in .tsx files ==="
rg -n "/dashboard/\$\{workspaceSlug\}" -g "*.tsx" || echo "No occurrences found."echo
echo "=== Occurrences of 'program/branding' in .tsx files ==="
rg -n "program/branding" -g "*.tsx" || echo "No occurrences found."echo
echo "=== Occurrences of 'program/rewards' in .tsx files ==="
rg -n "program/rewards" -g "*.tsx" || echo "No occurrences found."</details> </blockquote></details> </details> <!-- This is an auto-generated comment by CodeRabbit for review status -->
|
🤖 Bug0 QA Agent Here are the results of the automated tests for PR #2464:
To re-run the tests, please comment |
Summary by CodeRabbit