Fix earnings calculator for flat reward amounts #2535

TWilson023 · 2025-06-16T18:56:38Z

Summary by CodeRabbit

Refactor
- Improved earnings calculation logic for flat reward types to scale with user input, ensuring more accurate results.
- Centralized reward amount handling for consistency across calculations.

vercel · 2025-06-16T18:56:43Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Updated (UTC)
dub	🔄 Building (Inspect)	Visit Preview	Jun 16, 2025 6:56pm

coderabbitai · 2025-06-16T18:56:44Z

Walkthrough

The code refactors the earnings calculation logic within the earnings calculator block by introducing a centralized rewardAmount variable. The calculation for the "flat" reward type is updated to scale with the input value, while the non-flat calculation now also uses the new variable for consistency.

Changes

File	Change Summary
apps/web/ui/partners/lander/blocks/earnings-calculator-block.tsx	Refactored earnings calculation logic: introduced `rewardAmount` variable and updated flat reward calculation to scale with input value.

Poem

In the land of code where rewards abound,
A rabbit found a number sound.
With rewardAmount now set just right,
Calculations scale, a coder’s delight!
Hopping through logic, both flat and tall,
Consistency blooms—reward for all! 🥕

✨ Finishing Touches

📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Explain this complex logic.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai explain this code block.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and explain its main purpose.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR.
@coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

coderabbitai

Actionable comments posted: 0

🧹 Nitpick comments (1)

apps/web/ui/partners/lander/blocks/earnings-calculator-block.tsx (1)
32-32: Clarify unit semantics for rewardAmount.

reward.amount appears to be expressed in cents for “flat” rewards and in percentage points for non-flat rewards. Storing both in a single variable named rewardAmount risks unit confusion and future regressions.
Consider deriving two explicit variables instead:
-const rewardAmount = reward.amount ?? 0;
+const rewardAmountInCents   = reward.type === "flat" ? reward.amount ?? 0 : 0;
+const rewardPercentage      = reward.type !== "flat" ? (reward.amount ?? 0) : 0;
and update the calculation paths accordingly.
This makes the code self-documenting and prevents accidental cross-unit usage.

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 2c58d60 and 1a14ce6.

📒 Files selected for processing (1)

apps/web/ui/partners/lander/blocks/earnings-calculator-block.tsx (2 hunks)

⏰ Context from checks skipped due to timeout of 90000ms (1)

GitHub Check: build

🔇 Additional comments (1)

apps/web/ui/partners/lander/blocks/earnings-calculator-block.tsx (1)

85-89: ```shell
#!/bin/bash

Display the top of the file for context and locate rewardAmount usage

sed -n '1,200p' apps/web/ui/partners/lander/blocks/earnings-calculator-block.tsx
rg -n 'rewardAmount' -n 'const reward' apps/web/ui/partners/lander/blocks/earnings-calculator-block.tsx
</details>

</blockquote></details>

</details>

bug0-qa-agent · 2025-06-16T19:09:28Z

🤖 Bug0 QA Agent

Here are the results of the automated tests for PR #2535:

✅ All tests passed
Tests completed in 3.4m
View detailed report

To re-run the tests, please comment /bug0 run or push a new commit to this PR.

Fix earnings calculator for flat reward amounts

1a14ce6

TWilson023 requested a review from steven-tey June 16, 2025 18:58

steven-tey approved these changes Jun 16, 2025

View reviewed changes

steven-tey merged commit 31dc943 into main Jun 16, 2025
5 of 8 checks passed

steven-tey deleted the earnings-calculator-fix branch June 16, 2025 18:59

coderabbitai bot reviewed Jun 16, 2025

View reviewed changes

vercel bot temporarily deployed to Preview June 16, 2025 19:07 Inactive

coderabbitai bot mentioned this pull request Jul 12, 2025

Fix lander calculator getProgramApplicationRewardsAndDiscount #2639

Merged

coderabbitai bot mentioned this pull request Oct 25, 2025

Support fractional reward percentages #2998

Merged

coderabbitai bot mentioned this pull request Nov 21, 2025

Group-level settings #3141

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Fix earnings calculator for flat reward amounts #2535

Fix earnings calculator for flat reward amounts #2535

Uh oh!

TWilson023 commented Jun 16, 2025 •

edited by coderabbitai bot

Loading

Uh oh!

vercel bot commented Jun 16, 2025

Uh oh!

coderabbitai bot commented Jun 16, 2025 •

edited

Loading

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

Uh oh!

Uh oh!

coderabbitai bot left a comment

Display the top of the file for context and locate rewardAmount usage

Uh oh!

bug0-qa-agent bot commented Jun 16, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Fix earnings calculator for flat reward amounts #2535

Fix earnings calculator for flat reward amounts #2535

Uh oh!

Conversation

TWilson023 commented Jun 16, 2025 • edited by coderabbitai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Uh oh!

vercel bot commented Jun 16, 2025

Uh oh!

coderabbitai bot commented Jun 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Poem

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

Uh oh!

Uh oh!

coderabbitai bot left a comment

Choose a reason for hiding this comment

Display the top of the file for context and locate rewardAmount usage

Uh oh!

bug0-qa-agent bot commented Jun 16, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

TWilson023 commented Jun 16, 2025 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Jun 16, 2025 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)