Updated logic #2582

marcusljf · 2025-06-26T18:58:52Z

Updated the program reward and reward list logic to shorten and be more clear for the partners.

Summary by CodeRabbit

New Features
- Improved reward descriptions to display more specific and user-friendly phrasing based on reward event type and duration.
- Duration is now shown in years when applicable, with clearer formatting for both months and years.
- Lifetime rewards are now distinctly highlighted for better visibility.
Style
- Enhanced formatting and styling for reward duration and event descriptions, including bolded text for emphasis.

Updated the program reward and reward list logic to shorten and be more clear for the partners.

vercel · 2025-06-26T18:58:56Z

@marcusljf is attempting to deploy a commit to the Dub Team on Vercel.

A member of the Team first needs to authorize it.

coderabbitai · 2025-06-26T18:59:42Z

Walkthrough

The changes refine the logic and phrasing for displaying reward descriptions in partner program UI components. The updates remove the hideIfZero prop, adjust conditional text based on the reward event and duration, format durations as years when appropriate, and improve clarity for lifetime rewards. Minor JSX and formatting improvements were also made. No changes were made to component exports or public interfaces.

Changes

File(s)	Change Summary
apps/web/ui/partners/program-reward-description.tsx	Removed `hideIfZero` prop; updated reward description logic with refined event phrasing and duration formatting in years or months.
apps/web/ui/partners/program-reward-list.tsx	Refined reward description rendering with styled and pluralized duration text and adjusted event phrasing.
apps/web/app/app.dub.co/(dashboard)/[slug]/(ee)/program/rewards/rewards.tsx	Removed explicit `hideIfZero={false}` prop from `ProgramRewardDescription` usage.
apps/web/ui/partners/format-reward-description.ts	Restructured `formatRewardDescription` to separate "Earn" and amount, improved event and duration phrasing, replaced pluralization utility with inline logic.

Poem

In fields of code where carrots grow,
Rewards now shine with clearer glow.
Months or years, the time is right,
For every sale, the words delight.
A bunny hops, with formats new—
Descriptions crisp, and styled too!
🥕✨

✨ Finishing Touches

📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Explain this complex logic.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai explain this code block.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and explain its main purpose.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR.
@coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

vercel · 2025-06-27T04:45:13Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Updated (UTC)
dub	✅ Ready (Inspect)	Visit Preview	Jun 27, 2025 4:55am

coderabbitai

Actionable comments posted: 1

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 3bc1e15 and 7f3ee4c.

📒 Files selected for processing (4)

apps/web/app/app.dub.co/(dashboard)/[slug]/(ee)/program/rewards/rewards.tsx (0 hunks)
apps/web/ui/partners/format-reward-description.ts (1 hunks)
apps/web/ui/partners/program-reward-description.tsx (2 hunks)
apps/web/ui/partners/program-reward-list.tsx (1 hunks)

💤 Files with no reviewable changes (1)

apps/web/app/app.dub.co/(dashboard)/[slug]/(ee)/program/rewards/rewards.tsx

🚧 Files skipped from review as they are similar to previous changes (2)

apps/web/ui/partners/program-reward-list.tsx
apps/web/ui/partners/program-reward-description.tsx

🧰 Additional context used

🧠 Learnings (2)

📓 Common learnings

Learnt from: devkiran
PR: dubinc/dub#2448
File: packages/email/src/templates/partner-program-summary.tsx:0-0
Timestamp: 2025-05-29T04:45:18.504Z
Learning: In the PartnerProgramSummary email template (packages/email/src/templates/partner-program-summary.tsx), the stat titles are hardcoded constants ("Clicks", "Leads", "Sales", "Earnings") that will always match the ICONS object keys after toLowerCase() conversion, so icon lookup failures are not possible.

apps/web/ui/partners/format-reward-description.ts (1)

Learnt from: devkiran
PR: dubinc/dub#2448
File: packages/email/src/templates/partner-program-summary.tsx:0-0
Timestamp: 2025-05-29T04:45:18.504Z
Learning: In the PartnerProgramSummary email template (packages/email/src/templates/partner-program-summary.tsx), the stat titles are hardcoded constants ("Clicks", "Leads", "Sales", "Earnings") that will always match the ICONS object keys after toLowerCase() conversion, so icon lookup failures are not possible.

⏰ Context from checks skipped due to timeout of 90000ms (1)

GitHub Check: build

🔇 Additional comments (2)

apps/web/ui/partners/format-reward-description.ts (2)

12-13: LGTM! Clean separation of string parts.

The separation of "Earn" prefix and reward amount into distinct parts improves the code structure and makes it easier to maintain.

15-19: ```shell
#!/bin/bash

Locate the RewardSchema definition file and display its contents

SCHEMA_FILE=$(find apps/web/lib/zod/schemas -type f -iname "rewards*.ts" | head -n1)
echo "Schema file: $SCHEMA_FILE"
sed -n '1,200p' "$SCHEMA_FILE"
</details>

</blockquote></details>

</details>

apps/web/ui/partners/format-reward-description.ts

Updated logic

3bc1e15

Updated the program reward and reward list logic to shorten and be more clear for the partners.

steven-tey added 2 commits June 26, 2025 21:36

Merge branch 'main' into pr/2582

cf4b541

final updates

7f3ee4c

steven-tey approved these changes Jun 27, 2025

View reviewed changes

coderabbitai bot reviewed Jun 27, 2025

View reviewed changes

apps/web/ui/partners/format-reward-description.ts Show resolved Hide resolved

vercel bot deployed to Preview June 27, 2025 04:55 View deployment

steven-tey merged commit a8b33d7 into dubinc:main Jun 27, 2025
7 checks passed

coderabbitai bot mentioned this pull request Jul 26, 2025

Fix reward schema to match discount (description > name) #2687

Merged

coderabbitai bot mentioned this pull request Aug 19, 2025

Add 1 to discount.maxDuration #2760

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Updated logic #2582

Updated logic #2582

Uh oh!

marcusljf commented Jun 26, 2025 •

edited by coderabbitai bot

Loading

Uh oh!

vercel bot commented Jun 26, 2025

Uh oh!

coderabbitai bot commented Jun 26, 2025 •

edited

Loading

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

Uh oh!

vercel bot commented Jun 27, 2025 •

edited

Loading

Uh oh!

coderabbitai bot left a comment

Locate the RewardSchema definition file and display its contents

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Updated logic #2582

Updated logic #2582

Uh oh!

Conversation

marcusljf commented Jun 26, 2025 • edited by coderabbitai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Uh oh!

vercel bot commented Jun 26, 2025

Uh oh!

coderabbitai bot commented Jun 26, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Poem

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

Uh oh!

vercel bot commented Jun 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

coderabbitai bot left a comment

Choose a reason for hiding this comment

Locate the RewardSchema definition file and display its contents

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

marcusljf commented Jun 26, 2025 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Jun 26, 2025 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)

vercel bot commented Jun 27, 2025 •

edited

Loading