Enhance PartnerLinkCard with edit button and UI improvements #2608

marcusljf · 2025-07-04T00:25:19Z

Added an 'Edit link' button that appears on hover, allowing users to edit partner links directly from the card. Improved the UI for short and destination links by grouping them, adding hover effects, and making copy buttons visible only on hover for a cleaner interface.

Summary by CodeRabbit

New Features
- Added an "Edit link" button that appears in the top-right corner of each partner link card on hover, allowing for quick editing.
Style
- Improved layout and visual grouping of short link and destination URL sections.
- Copy buttons for links now appear only on hover, enhancing interactivity and reducing visual clutter.
- Added hover-triggered "View more" buttons on analytics chart links with smooth slide-in animation.
- Updated card and content container positioning to support new interactive elements.
- Removed header placeholder from link card skeleton for a cleaner loading state.

Added an 'Edit link' button that appears on hover, allowing users to edit partner links directly from the card. Improved the UI for short and destination links by grouping them, adding hover effects, and making copy buttons visible only on hover for a cleaner interface.

vercel · 2025-07-04T00:25:22Z

@marcusljf is attempting to deploy a commit to the Dub Team on Vercel.

A member of the Team first needs to authorize it.

coderabbitai · 2025-07-04T00:25:24Z

Caution

Review failed

The pull request is closed.

Walkthrough

The PartnerLinkCard component was updated to include an "Edit" button with a pen icon in the card header that triggers the partner link modal. The short link and destination URL sections were restructured with hover effects revealing copy buttons. A "View more" button was added to analytics chart links with slide-in animation. The LinkCardSkeleton component had its top header placeholder div removed. No logic or exported API changes occurred.

Changes

File(s)	Change Summary
apps/web/app/(ee)/partners.dub.co/(dashboard)/programs/[programSlug]/(enrolled)/links/partner-link-card.tsx	Added "Edit" button triggering modal, restructured link sections with hover-revealed copy buttons, added slide-in "View more" buttons on analytics links, updated CSS and JSX structure, no logic/API changes.
apps/web/app/(ee)/partners.dub.co/(dashboard)/programs/[programSlug]/(enrolled)/links/page-client.tsx	Removed top header placeholder div from `LinkCardSkeleton` component; no other changes.

Possibly related PRs

Partner link control #2551: Refactors partner link modal content and introduces new partner link creation modals and hooks, related due to overlapping UI components and modal interactions.

Suggested reviewers

devkiran

Poem

🐇 In cards where partner links do play,
A pen appears to edit away.
Hover close, the buttons gleam,
Copy, view more — a smooth UI dream.
With gentle slides and subtle flair,
This bunny’s hops bring style and care! ✨🖊️

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 73368ea and d3e4c73.

📒 Files selected for processing (2)

apps/web/app/(ee)/partners.dub.co/(dashboard)/programs/[programSlug]/(enrolled)/links/page-client.tsx (0 hunks)
apps/web/app/(ee)/partners.dub.co/(dashboard)/programs/[programSlug]/(enrolled)/links/partner-link-card.tsx (4 hunks)

✨ Finishing Touches

📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Explain this complex logic.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai explain this code block.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and explain its main purpose.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR.
@coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

coderabbitai

Actionable comments posted: 0

🧹 Nitpick comments (1)

apps/web/app/(ee)/partners.dub.co/(dashboard)/programs/[programSlug]/(enrolled)/links/partner-link-card.tsx (1)
139-153: Consider adding accessibility improvements.

The edit button implementation is functionally correct with proper event handling and hover states. However, it could benefit from better accessibility.

Consider adding an aria-label for better screen reader support:
        <button
          type="button"
+         aria-label="Edit partner link"
          className="absolute right-4 top-4 z-10 opacity-0 pointer-events-none translate-y-1 transition-all duration-200 group-hover:opacity-100 group-hover:pointer-events-auto group-hover:translate-y-0"
          onClick={e => {
            e.stopPropagation();
            setShowPartnerLinkModal(true);
          }}
        >

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 7d509a9 and 73368ea.

📒 Files selected for processing (1)

apps/web/app/(ee)/partners.dub.co/(dashboard)/programs/[programSlug]/(enrolled)/links/partner-link-card.tsx (3 hunks)

🧰 Additional context used

🧠 Learnings (1)

apps/web/app/(ee)/partners.dub.co/(dashboard)/programs/[programSlug]/(enrolled)/links/partner-link-card.tsx (2)

Learnt from: devkiran
PR: dubinc/dub#2448
File: packages/email/src/templates/partner-program-summary.tsx:0-0
Timestamp: 2025-05-29T04:45:18.504Z
Learning: In the PartnerProgramSummary email template (packages/email/src/templates/partner-program-summary.tsx), the stat titles are hardcoded constants ("Clicks", "Leads", "Sales", "Earnings") that will always match the ICONS object keys after toLowerCase() conversion, so icon lookup failures are not possible.

Learnt from: TWilson023
PR: dubinc/dub#2445
File: apps/web/ui/partners/design/branding-form.tsx:315-318
Timestamp: 2025-05-27T20:33:24.040Z
Learning: In the Dub codebase, prefer code simplicity over handling minor edge case UX issues, particularly when the fix would add complexity like viewport change listeners for minor state management.

🧬 Code Graph Analysis (1)

apps/web/app/(ee)/partners.dub.co/(dashboard)/programs/[programSlug]/(enrolled)/links/partner-link-card.tsx (1)

apps/web/ui/modals/partner-link-modal.tsx (1)

PartnerLinkModal (59-76)

⏰ Context from checks skipped due to timeout of 90000ms (1)

GitHub Check: build

🔇 Additional comments (4)

apps/web/app/(ee)/partners.dub.co/(dashboard)/programs/[programSlug]/(enrolled)/links/partner-link-card.tsx (4)

18-19: LGTM! Clean import additions.

The new imports for Button and PenWriting are appropriately added to support the edit functionality.

134-134: LGTM! Proper group class addition.

Adding the group class to the card container correctly enables CSS group hover states for the nested edit button and other hover effects.

138-138: LGTM! Correct positioning context.

Adding relative positioning to the main div provides the necessary positioning context for the absolutely positioned edit button.

169-206: Excellent UX enhancement with proper hover interactions.

The restructuring of the link display sections with dedicated hover groups provides a clean, intuitive user experience. The implementation correctly:

Groups related elements together

Applies hover effects with smooth transitions

Shows copy buttons only on hover for cleaner UI

Preserves existing functionality like the comments badge

The CSS classes and transitions are well-implemented and follow good UX patterns.

vercel · 2025-07-04T05:23:46Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Updated (UTC)
dub	✅ Ready (Inspect)	Visit Preview	Jul 4, 2025 5:42am

coderabbitai bot reviewed Jul 4, 2025

View reviewed changes

Merge branch 'main' into partner-link-edit

984a236

vercel bot deployed to Preview July 4, 2025 05:42 View deployment

steven-tey added 2 commits July 4, 2025 19:36

Merge branch 'main' into partner-link-edit

822f68c

finalize partner link card design

d3e4c73

steven-tey approved these changes Jul 5, 2025

View reviewed changes

steven-tey merged commit d87a924 into dubinc:main Jul 5, 2025
4 of 7 checks passed

coderabbitai bot mentioned this pull request Aug 29, 2025

Discount code attribution tracking #2620

Merged

coderabbitai bot mentioned this pull request Oct 2, 2025

Partner link card updates #2916

Merged

coderabbitai bot mentioned this pull request Nov 4, 2025

Improvements to the partners dashboard #3061

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Enhance PartnerLinkCard with edit button and UI improvements #2608

Enhance PartnerLinkCard with edit button and UI improvements #2608

Uh oh!

marcusljf commented Jul 4, 2025 •

edited by coderabbitai bot

Loading

Uh oh!

vercel bot commented Jul 4, 2025

Uh oh!

coderabbitai bot commented Jul 4, 2025 •

edited

Loading

Review failed

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

Uh oh!

coderabbitai bot left a comment

Uh oh!

vercel bot commented Jul 4, 2025 •

edited

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Enhance PartnerLinkCard with edit button and UI improvements #2608

Enhance PartnerLinkCard with edit button and UI improvements #2608

Uh oh!

Conversation

marcusljf commented Jul 4, 2025 • edited by coderabbitai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Uh oh!

vercel bot commented Jul 4, 2025

Uh oh!

coderabbitai bot commented Jul 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review failed

Walkthrough

Changes

Possibly related PRs

Suggested reviewers

Poem

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

Uh oh!

coderabbitai bot left a comment

Choose a reason for hiding this comment

Uh oh!

vercel bot commented Jul 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

marcusljf commented Jul 4, 2025 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Jul 4, 2025 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)

vercel bot commented Jul 4, 2025 •

edited

Loading