Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Make company name optional in the payout settings modal #2630

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
steven-tey merged 1 commit into from
Jul 9, 2025
Merged

Make company name optional in the payout settings modal #2630

steven-tey merged 1 commit into from
Jul 9, 2025
+3 −8

Conversation

@devkiran
Copy link
Collaborator

@devkiran devkiran commented Jul 9, 2025 •
edited by coderabbitai bot
Loading

Summary by CodeRabbit

  • New Features

    • The "companyName" field in payout settings is now optional instead of required.

  • Refactor

    • The submit button in the payout settings modal is now enabled based solely on whether the form has been modified, regardless of the "companyName" field.

@vercel
Copy link
Contributor

vercel bot commented Jul 9, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
dub 🔄 Building (Inspect) Visit Preview Jul 9, 2025 5:33am

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Jul 9, 2025 •
edited
Loading

Walkthrough

The changes update the payout settings form by making the "companyName" field optional instead of required, both in the UI and in the validation schema. The submit button is now enabled solely based on whether the form has unsaved changes, with no dependency on the "companyName" field.

Changes

File(s) Change Summary
apps/web/app/(ee)/partners.dub.co/(dashboard)/payouts/payout-settings-modal.tsx Removed required validation and UI requirement for "companyName"; simplified submit button logic.
apps/web/lib/zod/schemas/partners.ts Changed companyName in schema from required string to optional (nullish) string, maintaining length limit.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant PayoutSettingsModal
    participant ValidationSchema

    User->>PayoutSettingsModal: Open form
    User->>PayoutSettingsModal: Edit fields (companyName optional)
    PayoutSettingsModal->>ValidationSchema: Validate form (companyName can be null/undefined)
    User->>PayoutSettingsModal: Click Submit (enabled if form is dirty)
    PayoutSettingsModal->>ValidationSchema: Final validation
    ValidationSchema-->>PayoutSettingsModal: Validation result
    PayoutSettingsModal-->>User: Submit success or error
Loading

Possibly related PRs

  • dubinc/dub#2619: Replaces the invoice settings modal with a new payout settings modal, introducing and modifying the same payout-settings-modal.tsx file as in this PR.

Suggested reviewers

  • steven-tey

Poem

A bunny hopped in code so neat,
Made "companyName" less concrete.
No more required, just optional flair,
Submit when ready—no need to beware!
Forms now lighter, rules less tight,
The payout modal feels just right.
🐇✨

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 77ba5b1 and b99ce1b.

📒 Files selected for processing (2)
  • apps/web/app/(ee)/partners.dub.co/(dashboard)/payouts/payout-settings-modal.tsx (2 hunks)
  • apps/web/lib/zod/schemas/partners.ts (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
  • GitHub Check: build
🔇 Additional comments (3)
apps/web/lib/zod/schemas/partners.ts (1)

584-584: Schema change correctly implements optional company name.

The change from a required string to .nullish() appropriately makes the companyName field optional while maintaining existing constraints (max length and trimming). This aligns well with the PR objective and UI changes.

apps/web/app/(ee)/partners.dub.co/(dashboard)/payouts/payout-settings-modal.tsx (2)

183-183: Form registration correctly removes required constraint.

The companyName field registration no longer enforces a required constraint, which is consistent with the updated schema validation and the PR objective to make company name optional.

231-231: Submit button logic appropriately simplified.

The submit button's disabled state now depends solely on form dirty state (!isDirty), which is the correct behavior after removing the company name requirement. This ensures users can submit the form as soon as they make any changes, regardless of whether they provide a company name.

✨ Finishing Touches
  • 📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@steven-tey steven-tey merged commit 1a67dc5 into main Jul 9, 2025
6 of 8 checks passed
@steven-tey steven-tey deleted the fix-partner-payout-settings branch July 9, 2025 05:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@steven-tey steven-tey steven-tey approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@devkiran @steven-tey