Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Fix manual commission #2647

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
steven-tey merged 1 commit into from
Jul 16, 2025
Merged

Fix manual commission #2647

steven-tey merged 1 commit into from
Jul 16, 2025

Conversation

@devkiran
Copy link
Collaborator

@devkiran devkiran commented Jul 16, 2025 •
edited by coderabbitai bot
Loading

Summary by CodeRabbit

  • Bug Fixes
    • Improved sale recording by allowing sales to be logged even when the sale event date is missing, defaulting the timestamp to the current date and time.

@vercel
Copy link
Contributor

vercel bot commented Jul 16, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
dub 🔄 Building (Inspect) Visit Preview Jul 16, 2025 1:53pm

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Jul 16, 2025 •
edited
Loading

Walkthrough

The logic for recording a sale in the commission creation action was updated. Now, a sale can be recorded if only the saleAmount is present, regardless of whether saleEventDate is provided. The code introduces a saleDate variable that defaults to the current date if saleEventDate is missing, ensuring consistent timestamp handling.

Changes

File(s) Change Summary
apps/web/lib/actions/partners/create-commission.ts Changed sale recording condition to require only saleAmount; introduced saleDate variable to handle missing saleEventDate by defaulting to current date. Consistently used saleDate for timestamp fields.

Poem

A sale can happen night or noon,
With or without a date so soon.
If the event date’s gone astray,
Today’s the time, we won’t delay!
Rabbits hop and code with glee—
Commissions tracked, as quick as can be! 🐇

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 612c4d9 and 3be59bf.

📒 Files selected for processing (1)
  • apps/web/lib/actions/partners/create-commission.ts (3 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
  • GitHub Check: build
🔇 Additional comments (4)
apps/web/lib/actions/partners/create-commission.ts (4)

191-191: LGTM - Logic change aligns with manual commission requirements.

The change from requiring both saleAmount and saleEventDate to only requiring saleAmount allows for more flexible manual commission creation, which aligns with the PR objective of fixing manual commission handling.

195-195: Good fallback behavior for manual commission creation.

The saleDate variable provides a clean fallback to the current time when saleEventDate is not provided, which is appropriate for manual commission scenarios.

206-206: Consistent timestamp usage.

Using the saleDate variable ensures consistent timestamp handling throughout the function and improves code maintainability.

220-220: Consistent timestamp for commission creation.

Using the same saleDate for both the event timestamp and commission creation ensures data consistency between the recorded sale event and the commission record.

✨ Finishing Touches
  • 📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@steven-tey steven-tey merged commit 185b9a4 into main Jul 16, 2025
6 of 8 checks passed
@steven-tey steven-tey deleted the fix-manual-commissions branch July 16, 2025 14:00
@coderabbitai coderabbitai bot mentioned this pull request Jul 18, 2025
Merged
@coderabbitai coderabbitai bot mentioned this pull request Sep 3, 2025
Merged
@coderabbitai coderabbitai bot mentioned this pull request Sep 11, 2025
Merged
@coderabbitai coderabbitai bot mentioned this pull request Oct 3, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@steven-tey steven-tey steven-tey approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@devkiran @steven-tey