apps/web/app/app.dub.co/(dashboard)/[slug]/(ee)/program/campaigns/[campaignId]/campaign-editor.tsx (2)

323-323: Remove non-null assertion or add guard.

The non-null assertion workspaceId! is unsafe if workspaceId can be undefined. Consider adding a guard or early return.

Apply this diff to add a defensive check:

                   uploadImage={async (file) => {
                     try {
+                      if (!workspaceId) {
+                        toast.error("Workspace not found");
+                        return null;
+                      }
+
                       const result = await executeImageUpload({
-                        workspaceId: workspaceId!,
+                        workspaceId,
                       });

---

337-337: Remove forbidden Content-Length header in browser PUT.

Browsers disallow setting Content-Length; it's ignored or can cause issues with some signed URLs. Let the browser set it automatically.

Apply this diff:

                       const uploadResponse = await fetch(signedUrl, {
                         method: "PUT",
                         body: file,
                         headers: {
                           "Content-Type": file.type,
-                          "Content-Length": file.size.toString(),
                         },
                       });

apps/web/app/app.dub.co/(dashboard)/[slug]/(ee)/program/campaigns/[campaignId]/campaign-editor.tsx (1)

148-156: Consider removing unused dependencies from the callback.

The saveCampaign dependency array includes isSavingCampaign and watch, but these values are not used within the callback body. Removing them will prevent unnecessary callback recreation.

Apply this diff:

     [
-      isSavingCampaign,
       getValues,
       dirtyFields,
-      watch,
       makeRequest,
       campaign.id,
       reset,
     ],

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

apps/web/app/(ee)/api/campaigns/[campaignId]/route.ts (2)

86-103: Fix: create workflow on add, delete/detach on clear, and link campaign to new workflow

Currently only updates existing workflows. Adding a trigger to a campaign without a workflow does nothing; clearing a trigger leaves the old workflow firing. Handle both cases and update campaign.workflowId accordingly.

 const updatedCampaign = await prisma.$transaction(async (tx) => {
-  if (campaign.workflowId) {
+  let newWorkflowId: string | null = null;
+
+  if (campaign.workflowId && triggerCondition === null) {
+    await tx.workflow.delete({ where: { id: campaign.workflowId } });
+  } else if (campaign.workflowId) {
     await tx.workflow.update({
       where: {
         id: campaign.workflowId,
       },
       data: {
-        ...(triggerCondition && {
+        ...(triggerCondition && {
           triggerConditions: [triggerCondition],
           trigger: WORKFLOW_ATTRIBUTE_TRIGGER[triggerCondition.attribute],
         }),
         ...(status && {
           disabledAt: status === "paused" ? new Date() : null,
         }),
       },
     });
+  } else if (triggerCondition) {
+    const created = await tx.workflow.create({
+      data: {
+        programId,
+        trigger: WORKFLOW_ATTRIBUTE_TRIGGER[triggerCondition.attribute],
+        triggerConditions: [triggerCondition],
+        actions: [{ type: "sendCampaign", data: { campaignId } }],
+      },
+    });
+    newWorkflowId = created.id;
   }
 
   return await tx.campaign.update({
@@
     data: {
       ...(name && { name }),
       ...(subject && { subject }),
       ...(status && { status }),
       ...(bodyJson && { bodyJson }),
+      ...(triggerCondition === null && campaign.workflowId
+        ? { workflowId: null }
+        : {}),
+      ...(newWorkflowId && { workflowId: newWorkflowId }),
       ...(shouldUpdateGroups && {
         groups: {
           deleteMany: {},
           ...(updatedPartnerGroups &&
             updatedPartnerGroups.length > 0 && {
               create: updatedPartnerGroups.map((group) => ({
                 groupId: group.id,
               })),
             }),
         },
       }),
     },

Also applies to: 104-131

---

159-167: Add error handling for QStash schedule create/delete

Schedule ops fail when schedule exists/absent; currently unhandled in waitUntil.

-        if (shouldSchedule) {
-          await qstash.schedules.create({
+        if (shouldSchedule) {
+          try {
+            await qstash.schedules.create({
               destination: `${APP_DOMAIN_WITH_NGROK}/api/cron/workflows/${updatedCampaign.workflow.id}`,
               cron: cronSchedule,
               scheduleId: updatedCampaign.workflow.id,
-          });
+            });
+          } catch (error) {
+            console.warn("Failed to create schedule:", error);
+          }
         } else if (shouldDeleteSchedule) {
-          await qstash.schedules.delete(updatedCampaign.workflow.id);
+          try {
+            await qstash.schedules.delete(updatedCampaign.workflow.id);
+          } catch (error) {
+            console.warn("Failed to delete schedule:", error);
+          }
         }

apps/web/lib/zod/schemas/workflows.ts (1)

76-81: Allow null value in workflowConditionSchema

UI assigns null to value; z.number() rejects it, causing runtime parse errors.

 export const workflowConditionSchema = z.object({
   attribute: z.enum(WORKFLOW_ATTRIBUTES),
   operator: z.enum(WORKFLOW_COMPARISON_OPERATORS).default("gte"),
-  value: z.number(),
+  value: z.number().nullable(),
 });

apps/web/lib/api/workflows/execute-send-campaign-workflow.ts (2)

139-145: Add error handling for markdown rendering.

Past reviews flagged that renderCampaignEmailMarkdown can throw if campaign.bodyJson is malformed. Without error handling, one invalid campaign body aborts message creation for the entire chunk (up to 100 partners), losing all workflow progress for that batch.

Additionally, the as unknown as TiptapNode cast bypasses type validation, increasing the risk of runtime failures.

Wrap the rendering in error handling to isolate failures to individual partners:

 const messages = await prisma.message.createMany({
-  data: programEnrollmentChunk.map((programEnrollment) => ({
+  data: programEnrollmentChunk
+    .map((programEnrollment) => {
+      try {
+        return {
+          id: createId({ prefix: "msg_" }),
+          programId: programEnrollment.programId,
+          partnerId: programEnrollment.partnerId,
+          senderUserId: campaign.userId,
+          type: "campaign",
+          subject: campaign.subject,
+          text: renderCampaignEmailMarkdown({
+            content: campaign.bodyJson as unknown as TiptapNode,
+            variables: {
+              PartnerName: programEnrollment.partner.name,
+              PartnerEmail: programEnrollment.partner.email,
+            },
+          }),
+        };
+      } catch (error) {
+        console.error(
+          `Failed to render markdown for partner ${programEnrollment.partnerId}:`,
+          error
+        );
+        return null;
+      }
+    })
+    .filter((data): data is NonNullable<typeof data> => data !== null),
-    id: createId({ prefix: "msg_" }),
-    programId: programEnrollment.programId,
-    partnerId: programEnrollment.partnerId,
-    senderUserId: campaign.userId,
-    type: "campaign",
-    subject: campaign.subject,
-    text: renderCampaignEmailMarkdown({
-      content: campaign.bodyJson as unknown as TiptapNode,
-      variables: {
-        PartnerName: programEnrollment.partner.name,
-        PartnerEmail: programEnrollment.partner.email,
-      },
-    }),
-  })),
 });

---

171-177: Add error handling for HTML generation.

renderCampaignEmailHTML can throw if campaign.bodyJson is malformed. Since messages are already created at line 131, a failure here leaves the system in an inconsistent state: messages exist in the database but emails were never sent to partners.

The as unknown as TiptapNode cast bypasses type safety, increasing the likelihood of runtime errors.

Wrap HTML generation in error handling to prevent inconsistent state:

+function safeRenderCampaignHTML(
+  bodyJson: unknown,
+  variables: { PartnerName: string; PartnerEmail: string }
+): string {
+  try {
+    return renderCampaignEmailHTML({
+      content: bodyJson as unknown as TiptapNode,
+      variables,
+    });
+  } catch (error) {
+    console.error('Failed to render campaign HTML:', error);
+    return '<p>Unable to render campaign content</p>';
+  }
+}
+
 const { data } = await sendBatchEmail(
   partnerUsers.map((partnerUser) => ({
     variant: "notifications",
     to: partnerUser.email!,
     subject: campaign.subject,
     react: CampaignEmail({
       program: {
         name: program.name,
         slug: program.slug,
         logo: program.logo,
         messagingEnabledAt: program.messagingEnabledAt,
       },
       campaign: {
         type: campaign.type,
         subject: campaign.subject,
-        body: renderCampaignEmailHTML({
-          content: campaign.bodyJson as unknown as TiptapNode,
-          variables: {
-            PartnerName: partnerUser.partner.name,
-            PartnerEmail: partnerUser.partner.email,
-          },
-        }),
+        body: safeRenderCampaignHTML(
+          campaign.bodyJson,
+          {
+            PartnerName: partnerUser.partner.name,
+            PartnerEmail: partnerUser.partner.email,
+          }
+        ),
       },
     }),
     tags: [{ name: "type", value: "notification-email" }],
     headers: {
       "Idempotency-Key": `${campaign.id}-${partnerUser.id}`,
     },
   })),
 );

apps/web/lib/zod/schemas/campaigns.ts (1)

21-58: Unify labels with central workflow labels to avoid drift

Labels here are lowercase and can diverge from WORKFLOW_ATTRIBUTE_LABELS (Title Case). Source labels from the single mapping to keep UI consistent.

Apply:

+import { WORKFLOW_ATTRIBUTE_LABELS } from "./workflows";
@@
   totalClicks: {
-    label: "clicks",
+    label: WORKFLOW_ATTRIBUTE_LABELS.totalClicks,
     inputType: "number",
   },
   totalLeads: {
-    label: "leads",
+    label: WORKFLOW_ATTRIBUTE_LABELS.totalLeads,
     inputType: "number",
   },
   totalConversions: {
-    label: "conversions",
+    label: WORKFLOW_ATTRIBUTE_LABELS.totalConversions,
     inputType: "number",
   },
   totalSales: {
-    label: "sales",
+    label: WORKFLOW_ATTRIBUTE_LABELS.totalSales,
     inputType: "number",
   },
   totalSaleAmount: {
-    label: "revenue",
+    label: WORKFLOW_ATTRIBUTE_LABELS.totalSaleAmount,
     inputType: "currency",
   },
   totalCommissions: {
-    label: "commissions",
+    label: WORKFLOW_ATTRIBUTE_LABELS.totalCommissions,
     inputType: "currency",
   },
   partnerEnrolledDays: {
-    label: "enrollment duration",
+    label: WORKFLOW_ATTRIBUTE_LABELS.partnerEnrolledDays,
     inputType: "dropdown",
     dropdownValues: [1, 3, 7, 14, 30],
   },
   partnerJoined: {
-    label: "joins the program",
+    label: WORKFLOW_ATTRIBUTE_LABELS.partnerJoined,
     inputType: "none",
   },

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

Learnt from: devkiran
PR: dubinc/dub#2736
File: apps/web/app/(ee)/api/stripe/integration/webhook/invoice-paid.ts:12-12
Timestamp: 2025-08-25T17:33:45.072Z
Learning: The WorkflowTrigger enum in packages/prisma/schema/workflow.prisma contains three values: leadRecorded, saleRecorded, and commissionEarned. All three are properly used throughout the codebase.

apps/web/lib/zod/schemas/workflows.ts (1)

84-88: Schema still doesn't accept null values for value field.

The value field remains z.number() without .nullable(), but the codebase assigns null as any (referenced in past reviews). This type mismatch bypasses TypeScript's type safety and can cause runtime errors.

Apply this diff to allow null values:

 export const workflowConditionSchema = z.object({
   attribute: z.enum(WORKFLOW_ATTRIBUTES),
   operator: z.enum(WORKFLOW_COMPARISON_OPERATORS).default("gte"),
-  value: z.number(),
+  value: z.number().nullable(),
 });

apps/web/lib/api/workflows/execute-send-campaign-workflow.ts (2)

142-148: Critical: Add error handling for markdown rendering failures.

The renderCampaignEmailMarkdown call lacks error handling. If campaign.bodyJson contains invalid structure, rendering will throw, causing message creation to fail for all partners in the chunk (up to 100). Additionally, the as unknown as TiptapNode cast bypasses type validation entirely.

Wrap the rendering in error handling:

+function safeRenderMarkdown(
+  bodyJson: any,
+  variables: { PartnerName: string; PartnerEmail: string }
+): string {
+  try {
+    return renderCampaignEmailMarkdown({
+      content: bodyJson as unknown as TiptapNode,
+      variables,
+    });
+  } catch (error) {
+    console.error('Failed to render campaign markdown:', error);
+    return `Campaign: ${variables.PartnerName}`;
+  }
+}
+
 const messages = await prisma.message.createMany({
   data: programEnrollmentChunk.map((programEnrollment) => ({
     id: createId({ prefix: "msg_" }),
     programId: programEnrollment.programId,
     partnerId: programEnrollment.partnerId,
     senderUserId: campaign.userId,
     type: "campaign",
     subject: campaign.subject,
-    text: renderCampaignEmailMarkdown({
-      content: campaign.bodyJson as unknown as TiptapNode,
-      variables: {
-        PartnerName: programEnrollment.partner.name,
-        PartnerEmail: programEnrollment.partner.email,
-      },
-    }),
+    text: safeRenderMarkdown(campaign.bodyJson, {
+      PartnerName: programEnrollment.partner.name,
+      PartnerEmail: programEnrollment.partner.email,
+    }),
   })),
 });

---

174-180: Critical: Add error handling for HTML generation failures.

The renderCampaignEmailHTML call lacks error handling. If campaign.bodyJson contains invalid structure, HTML generation will throw, aborting email delivery for all partners in the chunk. Since messages are already created at line 134, this leaves the system in an inconsistent state—messages exist but emails were never sent. The as unknown as TiptapNode cast bypasses type safety.

Wrap the rendering in error handling:

+function safeRenderHTML(
+  bodyJson: any,
+  variables: { PartnerName: string; PartnerEmail: string }
+): string {
+  try {
+    return renderCampaignEmailHTML({
+      content: bodyJson as unknown as TiptapNode,
+      variables,
+    });
+  } catch (error) {
+    console.error('Failed to render campaign HTML:', error);
+    return `<p>Campaign content for ${variables.PartnerName}</p>`;
+  }
+}
+
 const { data } = await sendBatchEmail(
   partnerUsers.map((partnerUser) => ({
     variant: "notifications",
     to: partnerUser.email!,
     subject: campaign.subject,
     react: CampaignEmail({
       program: {
         name: program.name,
         slug: program.slug,
         logo: program.logo,
         messagingEnabledAt: program.messagingEnabledAt,
       },
       campaign: {
         type: campaign.type,
         subject: campaign.subject,
-        body: renderCampaignEmailHTML({
-          content: campaign.bodyJson as unknown as TiptapNode,
-          variables: {
-            PartnerName: partnerUser.partner.name,
-            PartnerEmail: partnerUser.partner.email,
-          },
-        }),
+        body: safeRenderHTML(campaign.bodyJson, {
+          PartnerName: partnerUser.partner.name,
+          PartnerEmail: partnerUser.partner.email,
+        }),
       },
     }),
     tags: [{ name: "type", value: "notification-email" }],
     headers: {
       "Idempotency-Key": `${campaign.id}-${partnerUser.id}`,
     },
   })),
 );

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

packages/prisma/schema/workflow.prisma (1)

2-4: Don't reorder existing Postgres enums

Postgres cannot reorder enum labels; Prisma migrations will only append. Moving commissionEarned and inserting new labels at the top will leave the database in the old order, causing drift/noisy diffs. Append new triggers after the existing ones instead of reordering them.

 enum WorkflowTrigger {
-  partnerEnrolled // scheduled
-  clickRecorded // scheduled
-  commissionEarned
-  leadRecorded
-  saleRecorded
+  leadRecorded
+  saleRecorded
+  commissionEarned
+  partnerEnrolled // scheduled
+  clickRecorded // scheduled
 }

Based on learnings.

apps/web/lib/zod/schemas/workflows.ts (1)

67-69: Allow workflow condition values to be nullable

partnerJoined is configured with inputType: "none", so clients won't send a numeric threshold. Keeping value: z.number() forces callers to coerce or cast null, which will either fail validation or rely on as any. Please permit null (and optionally default to it) so non-quantitative triggers can be represented safely.

 export const workflowConditionSchema = z.object({
   attribute: z.enum(WORKFLOW_ATTRIBUTES),
   operator: z.enum(WORKFLOW_COMPARISON_OPERATORS).default("gte"),
-  value: z.number(),
+  value: z.number().nullable(),
 });

If downstream logic assumes numbers, guard against null before comparing.

apps/web/lib/api/bounties/performance-bounty-scope-attributes.ts (1)

1-9: Consider removing redundant as const assertion.

The as const assertion on line 9 is redundant when combined with the explicit Record<..., string> type annotation. The explicit type takes precedence, so the values remain typed as string rather than literal types like "Leads".

If literal types are desired for stricter type safety, consider removing the explicit type annotation:

-export const PERFORMANCE_BOUNTY_SCOPE_ATTRIBUTES: Record<
-  "totalLeads" | "totalConversions" | "totalSaleAmount" | "totalCommissions",
-  string
-> = {
+export const PERFORMANCE_BOUNTY_SCOPE_ATTRIBUTES = {
   totalLeads: "Leads",
   totalConversions: "Conversions",
   totalSaleAmount: "Revenue",
   totalCommissions: "Commissions",
 } as const;

If the current string typing is intentional, remove the as const to avoid confusion:

 export const PERFORMANCE_BOUNTY_SCOPE_ATTRIBUTES: Record<
   "totalLeads" | "totalConversions" | "totalSaleAmount" | "totalCommissions",
   string
 > = {
   totalLeads: "Leads",
   totalConversions: "Conversions",
   totalSaleAmount: "Revenue",
   totalCommissions: "Commissions",
-} as const;
+};

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

Learnt from: devkiran
PR: dubinc/dub#2736
File: apps/web/app/(ee)/api/stripe/integration/webhook/invoice-paid.ts:12-12
Timestamp: 2025-08-25T17:33:45.072Z
Learning: The WorkflowTrigger enum in packages/prisma/schema/workflow.prisma contains three values: leadRecorded, saleRecorded, and commissionEarned. All three are properly used throughout the codebase.

apps/web/lib/api/partners/bulk-delete-partners.ts (2)

26-26: Fix typo: "finalParterIds" should be "finalPartnerIds".

The variable name contains a typo ("Parter" instead of "Partner"). While this is pre-existing code, fixing it now improves maintainability, especially since the new deletion logic uses this variable.

Apply this diff to fix the typo:

-  const finalParterIds = partners.map((partner) => partner.id);
+  const finalPartnerIds = partners.map((partner) => partner.id);

Then update all references (lines 55, 63, 71, 79):

   await prisma.commission.deleteMany({
     where: {
       partnerId: {
-        in: finalParterIds,
+        in: finalPartnerIds,
       },
     },
   });

   await prisma.payout.deleteMany({
     where: {
       partnerId: {
-        in: finalParterIds,
+        in: finalPartnerIds,
       },
     },
   });

   await prisma.notificationEmail.deleteMany({
     where: {
       partnerId: {
-        in: finalParterIds,
+        in: finalPartnerIds,
       },
     },
   });

   await prisma.partner.deleteMany({
     where: {
       id: {
-        in: finalParterIds,
+        in: finalPartnerIds,
       },
     },
   });

Also applies to: 70-71

---

4-4: Update comment to include notificationEmail.

The comment lists entities deleted during bulk partner deletion but doesn't mention notificationEmail. Update it to reflect the current implementation.

Apply this diff:

-// bulk delete multiple partners and all associated links, customers, payouts, and commissions
+// bulk delete multiple partners and all associated links, customers, payouts, commissions, and notification emails

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

apps/web/ui/layout/page-content/page-content-with-side-panel.tsx (1)

80-82: Restore visible scrollbars when enabling individual scrolling.

scrollbar-hide strips the visual scrollbar, leaving keyboard/mouse users without any cue that the pane scrolls—exactly the accessibility problem raised in the earlier review. Swap it for a styled scrollbar (or only hide it on coarse pointers) so the scroll affordance remains visible.

-          individualScrolling && "scrollbar-hide min-h-0 overflow-y-auto",
+          individualScrolling &&
+            "scrollbar-thin scrollbar-thumb-neutral-300 scrollbar-track-transparent min-h-0 overflow-y-auto",

apps/web/app/app.dub.co/(dashboard)/[slug]/(ee)/program/campaigns/[campaignId]/campaign-controls.tsx (2)

139-141: Edge case: Empty groupIds array passes validation.

The current validation groupIds === undefined allows an empty array [] to bypass validation. If sending a campaign to zero groups is invalid, strengthen the check to also reject empty arrays.

Apply this diff:

-    if (groupIds === undefined) {
+    if (!groupIds || groupIds.length === 0) {
       return "Please select the groups you want to send this campaign to.";
     }

---

271-280: Missing popover close before duplication.

Unlike other menu items (lines 247, 264, 288), the Duplicate action doesn't call setOpenPopover(false) before executing, leaving the popover visually open during navigation to the duplicated campaign.

Apply this diff:

                 <MenuItem
                   as={Command.Item}
                   icon={isDuplicatingCampaign ? LoadingCircle : Duplicate}
                   disabled={isUpdatingCampaign || isDuplicatingCampaign}
                   onSelect={() => {
+                    setOpenPopover(false);
                     handleCampaignDuplication();
                   }}
                 >

apps/web/app/app.dub.co/(dashboard)/[slug]/(ee)/program/campaigns/[campaignId]/campaign-editor.tsx (2)

323-329: Guard against missing workspaceId before upload

workspaceId! will throw if the hook hasn’t resolved yet (e.g., first render), so image uploads can crash instead of showing a friendly error. Add a defensive check and return early.

                   uploadImage={async (file) => {
                     try {
+                      if (!workspaceId) {
+                        toast.error("Workspace not found");
+                        return null;
+                      }
+
                       const result = await executeImageUpload({
-                        workspaceId: workspaceId!,
+                        workspaceId,
                       });

---

333-339: Remove forbidden Content-Length header

Browsers ignore or reject manual Content-Length headers, and signed PUT URLs can fail when extra headers are sent. Let the browser compute it.

                       const uploadResponse = await fetch(signedUrl, {
                         method: "PUT",
                         body: file,
                         headers: {
                           "Content-Type": file.type,
-                          "Content-Length": file.size.toString(),
                         },
                       });

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro