Fix image validation in `onboardPartnerSchema` #2722

devkiran · 2025-08-07T04:53:40Z

Summary by CodeRabbit

New Features
- Enhanced validation for partner onboarding, including required name and image fields with clear error messages.
- Improved profile type selection with default and stricter value enforcement.

vercel · 2025-08-07T04:53:45Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Updated (UTC)
dub	✅ Ready (Inspect)	Visit Preview	Aug 7, 2025 4:58am

coderabbitai · 2025-08-07T04:54:07Z

Walkthrough

The onboard partner schema in the Zod validation layer was updated to enhance validation for the name, image, and profileType fields. The image field now uses a dedicated schema with transformation and refinement, while profileType leverages a native enum. The name field enforces a minimum length.

Changes

Cohort / File(s)	Change Summary
Partner Schema Validation Updates `apps/web/lib/zod/schemas/partners.ts`	Enhanced validation for `name` (min length), switched `image` to use `uploadedImageSchema` with transformation and refinement, and updated `profileType` to use a native enum with default.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~7 minutes

Possibly related PRs

Fix program resource logo SVGs #2566: Both PRs modify image validation schemas in the same module and update their usage in partner-related schemas, indicating a direct relationship in how image fields are validated and transformed.

Poem

A schema hops, its fields refined,
With names that must not lag behind.
Images checked, no blanks allowed,
Profile types now enum-crowned.
In Zod’s warren, rules are tight—
Validation done just right!
🐇✨

Note

⚡️ Unit Test Generation is now available in beta!

Learn more here, or try it out under "Finishing Touches" below.

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 8dc5beb and 8403135.

📒 Files selected for processing (1)

apps/web/lib/zod/schemas/partners.ts (2 hunks)

🧰 Additional context used

🧠 Learnings (3)

📓 Common learnings

Learnt from: TWilson023
PR: dubinc/dub#2673
File: apps/web/ui/partners/rewards/add-edit-reward-sheet.tsx:56-66
Timestamp: 2025-07-30T15:25:13.936Z
Learning: In apps/web/ui/partners/rewards/add-edit-reward-sheet.tsx, the form schema uses partial condition objects to allow users to add empty/unconfigured condition fields without type errors, while submission validation uses strict schemas to ensure data integrity. This two-stage validation pattern improves UX by allowing progressive completion of complex forms.

Learnt from: devkiran
PR: dubinc/dub#2433
File: apps/web/app/api/workspaces/[idOrSlug]/billing/payment-methods/route.ts:74-76
Timestamp: 2025-05-29T09:47:33.583Z
Learning: When Zod enum validation is used (e.g., `z.enum(PAYMENT_METHOD_TYPES)`), it ensures the validated value is one of the valid enum values, making subsequent type casts to the corresponding TypeScript types safe without additional validation.

📚 Learning: in apps/web/ui/partners/rewards/add-edit-reward-sheet.tsx, the form schema uses partial condition ob...

Learnt from: TWilson023
PR: dubinc/dub#2673
File: apps/web/ui/partners/rewards/add-edit-reward-sheet.tsx:56-66
Timestamp: 2025-07-30T15:25:13.936Z
Learning: In apps/web/ui/partners/rewards/add-edit-reward-sheet.tsx, the form schema uses partial condition objects to allow users to add empty/unconfigured condition fields without type errors, while submission validation uses strict schemas to ensure data integrity. This two-stage validation pattern improves UX by allowing progressive completion of complex forms.

Applied to files:

apps/web/lib/zod/schemas/partners.ts

📚 Learning: in apps/web/ui/partners/rewards/rewards-logic.tsx, when setting the entity field in a reward conditi...

Learnt from: TWilson023
PR: dubinc/dub#2673
File: apps/web/ui/partners/rewards/rewards-logic.tsx:268-275
Timestamp: 2025-07-30T15:29:54.131Z
Learning: In apps/web/ui/partners/rewards/rewards-logic.tsx, when setting the entity field in a reward condition, dependent fields (attribute, operator, value) should be reset rather than preserved because different entities (customer vs sale) have different available attributes. Maintaining existing fields when the entity changes would create invalid state combinations and confusing UX.

Applied to files:

apps/web/lib/zod/schemas/partners.ts

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)

GitHub Check: build

🔇 Additional comments (4)

apps/web/lib/zod/schemas/partners.ts (4)

13-17: LGTM: Clean import addition for image validation.

The addition of uploadedImageSchema import aligns perfectly with the PR objective to fix image validation in the onboard partner schema.

414-414: LGTM: Enhanced name validation with clear error messaging.

The addition of minimum length validation with a clear error message improves the user experience and ensures data quality.

415-419: LGTM: Robust image validation implementation.

The use of uploadedImageSchema with transformation and refinement provides comprehensive image validation that addresses the PR objective. The pattern of transforming falsy values to empty strings followed by non-empty validation ensures data integrity while providing clear error messaging.

421-421: LGTM: Improved type safety with native enum validation.

The switch from hardcoded string literals to z.nativeEnum(PartnerProfileType) enhances type safety and maintains consistency with the Prisma schema. This follows the established pattern in your codebase where Zod enum validation ensures the validated value is one of the valid enum values.

✨ Finishing Touches

📝 Generate Docstrings

🧪 Generate unit tests

Create PR with unit tests
Post copyable unit tests in a comment
Commit unit tests in branch fix-upload-issue

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Explain this complex logic.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai explain this code block.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and explain its main purpose.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR.
@coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
@coderabbitai generate unit tests to generate unit tests for this PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

Update partners.ts

8403135

vercel bot deployed to Preview August 7, 2025 04:58 View deployment

steven-tey approved these changes Aug 7, 2025

View reviewed changes

steven-tey merged commit ed05f4b into main Aug 7, 2025
9 checks passed

steven-tey deleted the fix-upload-issue branch August 7, 2025 05:15

coderabbitai bot mentioned this pull request Aug 13, 2025

Fix the partner profile upload #2747

Merged

coderabbitai bot mentioned this pull request Oct 19, 2025

Make partner image optional at onboarding #2983

Merged

coderabbitai bot mentioned this pull request Dec 12, 2025

Make partner onboarding image optional and sync to user #3221

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Fix image validation in `onboardPartnerSchema` #2722

Fix image validation in `onboardPartnerSchema` #2722

Uh oh!

devkiran commented Aug 7, 2025 •

edited by coderabbitai bot

Loading

Uh oh!

vercel bot commented Aug 7, 2025 •

edited

Loading

Uh oh!

coderabbitai bot commented Aug 7, 2025 •

edited

Loading

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Fix image validation in onboardPartnerSchema #2722

Fix image validation in onboardPartnerSchema #2722

Uh oh!

Conversation

devkiran commented Aug 7, 2025 • edited by coderabbitai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Uh oh!

vercel bot commented Aug 7, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

coderabbitai bot commented Aug 7, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Estimated code review effort

Possibly related PRs

Poem

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Fix image validation in `onboardPartnerSchema` #2722

Fix image validation in `onboardPartnerSchema` #2722

devkiran commented Aug 7, 2025 •

edited by coderabbitai bot

Loading

vercel bot commented Aug 7, 2025 •

edited

Loading

coderabbitai bot commented Aug 7, 2025 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)