apps/web/ui/partners/add-edit-discount-sheet.tsx (1)

367-374: Flat-amount discounts improperly capped at 100.

Validation unconditionally caps amount at 100, which is correct for percentages but blocks flat USD discounts over $100.

Use a type-aware max like in the rewards sheet:

 {...register("amount", {
   valueAsNumber: true,
   min: 0,
-  max: 100,
+  max: type === "percentage" ? 100 : undefined,
   onChange: handleMoneyInputChange,
   required: true,
 })}

apps/web/ui/partners/add-edit-discount-sheet.tsx (2)

50-54: Defaults plumbing is solid; align isRecurring and toggle behavior to respect defaultDiscountValues.

defaultValuesSource correctly unifies edit vs. duplicate flows. However, the initial isRecurring state and the radio toggle reuse discount?.maxDuration and ignore defaultDiscountValues, which can hide the "Duration" UI or set an unexpected duration when duplicating defaults.

Apply these changes:

@@
-  const [isRecurring, setIsRecurring] = useState(
-    discount ? discount.maxDuration !== 0 : false,
-  );
+  // Respect defaults when duplicating
+  const [isRecurring, setIsRecurring] = useState(
+    (discount?.maxDuration ?? defaultDiscountValues?.maxDuration ?? 0) !== 0,
+  );
@@
-                                          setValue(
-                                            "maxDuration",
-                                            recurring
-                                              ? discount?.maxDuration ||
-                                                  Infinity
-                                              : 0,
-                                          );
+                                          setValue(
+                                            "maxDuration",
+                                            recurring
+                                              ? (discount?.maxDuration ??
+                                                  defaultDiscountValues?.maxDuration ??
+                                                  Infinity)
+                                              : 0,
+                                          );

Also applies to: 69-70, 78-90

---

80-83: Prevent potential NaN when default amount is absent.

If a flat default is provided without an amount (or amount is 0-like), dividing undefined will yield NaN. Safer to null-coalesce before scaling.

-        defaultValuesSource?.type === "flat"
-          ? defaultValuesSource.amount / 100
-          : defaultValuesSource?.amount,
+        defaultValuesSource?.type === "flat"
+          ? (defaultValuesSource?.amount ?? 0) / 100
+          : defaultValuesSource?.amount ?? undefined,

apps/web/app/app.dub.co/(dashboard)/[slug]/(ee)/program/groups/[groupSlug]/discount/group-discount.tsx (1)

97-103: Use the DEFAULT_PARTNER_GROUP slug constant for consistency.

Avoid hardcoding "default" to reduce drift if the slug ever changes.

-const CopyDefaultDiscountButton = () => {
-  const { group: defaultGroup } = useGroup({ slug: "default" });
+const CopyDefaultDiscountButton = () => {
+  const { group: defaultGroup } = useGroup({ slug: DEFAULT_PARTNER_GROUP.slug });

apps/web/app/app.dub.co/(dashboard)/[slug]/(ee)/program/groups/[groupSlug]/rewards/group-rewards.tsx (1)

213-218: Use the DEFAULT_PARTNER_GROUP slug constant for parity with the discounts file.

Small consistency tweak.

-const CopyDefaultRewardButton = ({ event }: { event: EventType }) => {
-  const { group: defaultGroup } = useGroup({ slug: "default" });
+const CopyDefaultRewardButton = ({ event }: { event: EventType }) => {
+  const { group: defaultGroup } = useGroup({ slug: DEFAULT_PARTNER_GROUP.slug });

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

💡 Knowledge Base configuration:

• MCP integration is disabled by default for public repositories
• Jira integration is disabled by default for public repositories
• Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

Learnt from: TWilson023
PR: dubinc/dub#2673
File: apps/web/ui/partners/rewards/rewards-logic.tsx:268-275
Timestamp: 2025-07-30T15:29:54.131Z
Learning: In apps/web/ui/partners/rewards/rewards-logic.tsx, when setting the entity field in a reward condition, dependent fields (attribute, operator, value) should be reset rather than preserved because different entities (customer vs sale) have different available attributes. Maintaining existing fields when the entity changes would create invalid state combinations and confusing UX.

Learnt from: TWilson023
PR: dubinc/dub#2673
File: apps/web/ui/partners/rewards/add-edit-reward-sheet.tsx:56-66
Timestamp: 2025-07-30T15:25:13.936Z
Learning: In apps/web/ui/partners/rewards/add-edit-reward-sheet.tsx, the form schema uses partial condition objects to allow users to add empty/unconfigured condition fields without type errors, while submission validation uses strict schemas to ensure data integrity. This two-stage validation pattern improves UX by allowing progressive completion of complex forms.

apps/web/ui/partners/add-edit-discount-sheet.tsx (4)

60-66: Preserve duplicated maxDuration when toggling Recurring

When duplicating from default group, toggling the “Discount Type” back to Recurring resets maxDuration to Infinity because the code references discount?.maxDuration and ignores defaultDiscountValues. Use defaultValuesSource to preserve the prefilled value.

Apply this diff:

-  const defaultValuesSource = discount || defaultDiscountValues;
+  const defaultValuesSource = discount || defaultDiscountValues;
@@
-                                          setValue(
-                                            "maxDuration",
-                                            recurring
-                                              ? discount?.maxDuration ||
-                                                  Infinity
-                                              : 0,
-                                          );
+                                          setValue(
+                                            "maxDuration",
+                                            recurring
+                                              ? (defaultValuesSource?.maxDuration ??
+                                                  Infinity)
+                                              : 0,
+                                          );

Also applies to: 254-260

---

80-83: Avoid NaN defaults for amount when source amount is missing

Guard against undefined amounts to prevent NaN in the input when prefilled data is incomplete/unexpected.

-      amount:
-        defaultValuesSource?.type === "flat"
-          ? defaultValuesSource.amount / 100
-          : defaultValuesSource?.amount,
+      amount:
+        defaultValuesSource?.type === "flat"
+          ? (defaultValuesSource?.amount != null
+              ? defaultValuesSource.amount / 100
+              : 0)
+          : (defaultValuesSource?.amount ?? 0),

---

368-373: Cap 100 only for percentage; allow flat USD > 100

max: 100 blocks flat amounts above $100. Make the 100-cap percentage-only via a custom validator.

-                        {...register("amount", {
-                          valueAsNumber: true,
-                          min: 0,
-                          max: 100,
-                          onChange: handleMoneyInputChange,
-                          required: true,
-                        })}
+                        {...register("amount", {
+                          valueAsNumber: true,
+                          min: 0,
+                          validate: (v) =>
+                            type === "percentage"
+                              ? v <= 100 || "Percentage must be <= 100"
+                              : true,
+                          onChange: handleMoneyInputChange,
+                          required: true,
+                        })}

---

469-471: Disable submit on NaN amount

amount == null doesn’t catch NaN. Ensure the button disables when the value can’t be parsed.

-              disabled={
-                amount == null || isDeleting || isCreating || isUpdating
-              }
+              disabled={
+                amount == null ||
+                Number.isNaN(amount) ||
+                isDeleting ||
+                isCreating ||
+                isUpdating
+              }

apps/web/app/app.dub.co/(dashboard)/[slug]/(ee)/program/groups/[groupSlug]/discount/group-discount.tsx (1)

77-90: Prevent parent click handler from ever firing on button presses

The parent has a guard, but adding stopPropagation() here makes this robust if the guard changes in the future.

             <Button
               text={discount ? "Edit" : "Create"}
               variant={discount ? "secondary" : "primary"}
               className="h-9 w-full rounded-lg md:w-fit"
               onClick={(e) => {
                 e.preventDefault();
+                e.stopPropagation();
                 setIsOpen(true);
               }}
             />

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

💡 Knowledge Base configuration:

• MCP integration is disabled by default for public repositories
• Jira integration is disabled by default for public repositories
• Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.