Ensure all programEnrollments uses pge_ ID prefix #2789

steven-tey · 2025-08-31T03:53:42Z

Summary by CodeRabbit

Chores
- Standardized identifier assignment for newly created program enrollments across partner import and enrollment flows.
- Improves data consistency and reliability for tracking and reporting of enrollments from multiple sources.
- Reduces potential inconsistencies between integrations when creating new enrollments.
- No visible UI changes; background improvements only.

coderabbitai · 2025-08-31T03:53:48Z

Walkthrough

Adds explicit ID generation for newly created ProgramEnrollment records across partner creation/import flows by injecting id: createId({ prefix: "pge_" }) into Prisma nested create/upsert payloads. No function signatures or control flow are changed.

Changes

Cohort / File(s)	Summary of Changes
Explicit ProgramEnrollment ID generation `apps/web/lib/api/partners/create-and-enroll-partner.ts`, `apps/web/lib/partnerstack/import-partners.ts`, `apps/web/lib/rewardful/import-partners.ts`, `apps/web/lib/tolt/import-partners.ts`	Add `id: createId({ prefix: "pge_" })` to Prisma `programEnrollment` create payloads (nested create and upsert create paths). Update paths and other fields unchanged.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

Follow-up improvements to partner groups and imports #2754 — Also modifies programEnrollment creation in apps/web/lib/partnerstack/import-partners.ts, adjusting group-related fields; touches the same upsert create payload.

Poem

I stamped each seed with “pge_” bright,
So enrollments sprout with labeled light.
No paths re-routed, flows still clean—
Just tidy tags in fields unseen.
A hop, a bop, IDs in line—
This rabbit signs: everything’s fine. 🐇✨

✨ Finishing Touches

📝 Generate Docstrings

🧪 Generate unit tests

Create PR with unit tests
Post copyable unit tests in a comment
Commit unit tests in branch pge

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR/Issue comments)

Type @coderabbitai help to get the list of available commands.

Other keywords and placeholders

Add @coderabbitai ignore or @coderabbit ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Status, Documentation and Community

Visit our Status Page to check the current availability of CodeRabbit.
Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

vercel · 2025-08-31T03:53:48Z

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Preview	Updated (UTC)
dub	Ready	Preview	Aug 31, 2025 3:58am

coderabbitai

Actionable comments posted: 0

🧹 Nitpick comments (5)

apps/web/lib/tolt/import-partners.ts (2)
159-164: Optional: centralize the pge_ ID construction.

Reduce duplication/typos by exposing a helper and using it at call sites.

Apply:
-      id: createId({ prefix: "pge_" }),
+      id: createProgramEnrollmentId(),
Add in apps/web/lib/api/create-id.ts:
export const createProgramEnrollmentId = () => createId({ prefix: "pge_" });
159-164: Optional DB guardrail: enforce prefix at the schema layer.

Add a CHECK to guarantee future writes (including ad-hoc scripts) keep the pge_ prefix.

Example (Postgres migration):
ALTER TABLE "ProgramEnrollment"
  ADD CONSTRAINT program_enrollment_id_prefix_chk
  CHECK (id LIKE 'pge_%');
apps/web/lib/partnerstack/import-partners.ts (1)
180-189: If adopting helper, update here too.

Switch to createProgramEnrollmentId() when available for consistency.
-      id: createId({ prefix: "pge_" }),
+      id: createProgramEnrollmentId(),
apps/web/lib/api/partners/create-and-enroll-partner.ts (1)
104-121: Optional: use shared helper for ID generation.

Keeps call sites uniform and prevents prefix typos.
-        id: createId({ prefix: "pge_" }),
+        id: createProgramEnrollmentId(),
apps/web/lib/rewardful/import-partners.ts (1)
157-162: Optional: adopt shared helper once introduced.
-      id: createId({ prefix: "pge_" }),
+      id: createProgramEnrollmentId(),

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

💡 Knowledge Base configuration:

MCP integration is disabled by default for public repositories
Jira integration is disabled by default for public repositories
Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between 0145629 and 3e363c7.

📒 Files selected for processing (4)

apps/web/lib/api/partners/create-and-enroll-partner.ts (1 hunks)
apps/web/lib/partnerstack/import-partners.ts (1 hunks)
apps/web/lib/rewardful/import-partners.ts (1 hunks)
apps/web/lib/tolt/import-partners.ts (1 hunks)

🧰 Additional context used

🧬 Code graph analysis (4)

apps/web/lib/tolt/import-partners.ts (1)

apps/web/lib/api/create-id.ts (1)

createId (60-69)

apps/web/lib/rewardful/import-partners.ts (1)

apps/web/lib/api/create-id.ts (1)

createId (60-69)

apps/web/lib/api/partners/create-and-enroll-partner.ts (1)

apps/web/lib/api/create-id.ts (1)

createId (60-69)

apps/web/lib/partnerstack/import-partners.ts (1)

apps/web/lib/api/create-id.ts (1)

createId (60-69)

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)

GitHub Check: Vade Review
GitHub Check: build

🔇 Additional comments (5)

apps/web/lib/tolt/import-partners.ts (2)

159-164: LGTM: ProgramEnrollment IDs now use pge_ prefix.

Matches PR objective and maintains parity with other flows.

159-164: Verified: ‘pge_’ is allowlisted and all ProgramEnrollment create/upsert calls set the ID with createId({prefix: "pge_"}).

apps/web/lib/partnerstack/import-partners.ts (1)

180-189: LGTM: consistent pge_ ID on create path.

Aligned with other importers; update path untouched.

apps/web/lib/api/partners/create-and-enroll-partner.ts (1)

104-121: LGTM: nested ProgramEnrollment gets pge_ ID.

Meets the PR goal; nested write is valid in Prisma.

apps/web/lib/rewardful/import-partners.ts (1)

157-162: LGTM: adds pge_ ID on upsert create.

Consistent with other sources; no behavior change on update.

Ensure all programEnrollments uses pge_ ID prefix

3e363c7

vercel bot deployed to Preview August 31, 2025 03:58 View deployment

coderabbitai bot reviewed Aug 31, 2025

View reviewed changes

steven-tey merged commit 1ee547a into main Aug 31, 2025
10 checks passed

steven-tey deleted the pge branch August 31, 2025 04:05

coderabbitai bot mentioned this pull request Aug 31, 2025

Move link settings under partner groups #2774

Merged

coderabbitai bot mentioned this pull request Oct 6, 2025

Update POST /api/partners #2934

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Ensure all programEnrollments uses pge_ ID prefix #2789

Ensure all programEnrollments uses pge_ ID prefix #2789

Uh oh!

steven-tey commented Aug 31, 2025 •

edited by coderabbitai bot

Loading

Uh oh!

coderabbitai bot commented Aug 31, 2025 •

edited

Loading

Chat

Support

CodeRabbit Commands (Invoked using PR/Issue comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Status, Documentation and Community

Uh oh!

vercel bot commented Aug 31, 2025 •

edited

Loading

Uh oh!

coderabbitai bot left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Ensure all programEnrollments uses pge_ ID prefix #2789

Ensure all programEnrollments uses pge_ ID prefix #2789

Uh oh!

Conversation

steven-tey commented Aug 31, 2025 • edited by coderabbitai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Uh oh!

coderabbitai bot commented Aug 31, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Estimated code review effort

Possibly related PRs

Poem

Chat

Support

CodeRabbit Commands (Invoked using PR/Issue comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Status, Documentation and Community

Uh oh!

vercel bot commented Aug 31, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

coderabbitai bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

steven-tey commented Aug 31, 2025 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Aug 31, 2025 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)

vercel bot commented Aug 31, 2025 •

edited

Loading