apps/web/app/(ee)/app.dub.co/(new-program)/[slug]/program/new/rewards/form.tsx (1)

226-238: Prevent conflicting state when changing import source.
When the user selects a different import source, clear other provider objects to avoid ambiguity downstream.

                 setSelectedItem={(item: ImportSource) => {
                   if (item) {
                     setValue("importSource", item.id, {
                       shouldDirty: true,
                     });
+                    // Clear previously entered credentials from other sources
+                    setValue("rewardful", null);
+                    setValue("tolt", null);
+                    setValue("partnerstack", null);
                   }
                 }}

apps/web/app/(ee)/app.dub.co/(new-program)/[slug]/program/new/rewards/import-partnerstack-form.tsx (2)

47-58: Allow proceeding with already-saved credentials (better UX).
If partnerstack is already saved in form state, let users continue without re-entering keys.

@@
-  const onSubmit = async () => {
-    if (!workspaceId || !publicKey || !secretKey) {
-      toast.error("Please fill in all required fields.");
-      return;
-    }
-
-    await executeAsync({
-      workspaceId,
-      publicKey,
-      secretKey,
-    });
-  };
+  const hasSavedCredentials = Boolean(
+    partnerStack?.publicKey && partnerStack?.maskedSecretKey,
+  );
+
+  const onSubmit = async () => {
+    if (!workspaceId) {
+      toast.error("Workspace not found.");
+      return;
+    }
+    // If nothing entered but creds already saved, proceed.
+    if (!publicKey && !secretKey && hasSavedCredentials) {
+      onSuccess();
+      return;
+    }
+    if (!publicKey || !secretKey) {
+      toast.error("Please fill in all required fields.");
+      return;
+    }
+    await executeAsync({ workspaceId, publicKey, secretKey });
+  };
@@
-      <Button
+      <Button
         text="Continue"
         className="w-full"
-        disabled={!publicKey || !secretKey}
+        disabled={(!publicKey || !secretKey) && !hasSavedCredentials}
         loading={isSettingPartnerStackToken || isPending}
         onClick={onSubmit}
       />

Also applies to: 99-105

---

70-71: Avoid pre-filling password fields with masked values.
Pre-populating password inputs with masked secrets is confusing and may cause accidental submission without edits. Prefer placeholders or a “Saved” badge.

Example:

-          value={publicKey || partnerStack?.publicKey || ""}
+          value={publicKey}
@@
-          value={secretKey || partnerStack?.maskedSecretKey || ""}
+          value={secretKey}

Then show a small “Credentials saved” hint when partnerStack exists.

Also applies to: 94-95

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

💡 Knowledge Base configuration:

• MCP integration is disabled by default for public repositories
• Jira integration is disabled by default for public repositories
• Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

Learnt from: TWilson023
PR: dubinc/dub#2673
File: apps/web/ui/partners/rewards/add-edit-reward-sheet.tsx:56-66
Timestamp: 2025-07-30T15:25:13.936Z
Learning: In apps/web/ui/partners/rewards/add-edit-reward-sheet.tsx, the form schema uses partial condition objects to allow users to add empty/unconfigured condition fields without type errors, while submission validation uses strict schemas to ensure data integrity. This two-stage validation pattern improves UX by allowing progressive completion of complex forms.

Learnt from: TWilson023
PR: dubinc/dub#2673
File: apps/web/ui/partners/rewards/rewards-logic.tsx:268-275
Timestamp: 2025-07-30T15:29:54.131Z
Learning: In apps/web/ui/partners/rewards/rewards-logic.tsx, when setting the entity field in a reward condition, dependent fields (attribute, operator, value) should be reset rather than preserved because different entities (customer vs sale) have different available attributes. Maintaining existing fields when the entity changes would create invalid state combinations and confusing UX.