apps/web/lib/api/bounties/get-bounties-by-group.ts (1)

16-54: Tighten Prisma filter for readability and index-friendliness

The nested AND: [{ OR: [...] }] is redundant. Flattening improves readability and can help query planners. Functionality is unchanged.

-      // Only fetch bounties that are relevant to the specified groups
-      AND: [
-        {
-          OR: [
-            {
-              groups: {
-                none: {},
-              },
-            },
-            {
-              groups: {
-                some: {
-                  groupId: {
-                    in: targetGroupIds,
-                  },
-                },
-              },
-            },
-          ],
-        },
-      ],
+      // Only bounties with no groups or intersecting target groups
+      OR: [
+        { groups: { none: {} } },
+        { groups: { some: { groupId: { in: targetGroupIds } } } },
+      ],

apps/web/app/(ee)/api/cron/bounties/notify-partners/route.ts (2)

118-140: Strengthen idempotency key to avoid collisions across subsets

The key ignores partnerIds, so runs with different subsets can collide. Include a stable subset hash.

Minimal change (non-cryptographic, acceptable if subsets are rare):

         headers: {
-          "Idempotency-Key": `${bountyId}-page-${page}`,
+          "Idempotency-Key": `${bountyId}-page-${page}${partnerIds?.length ? `-subset` : `-all`}`,
         },

Prefer hashing the subset for uniqueness:

// Near parse line, compute once:
const subsetKey =
  partnerIds?.length ? `-${partnerIds.slice().sort().join(",")}` : "-all";

and then:

- "Idempotency-Key": `${bountyId}-page-${page}`,
+ "Idempotency-Key": `${bountyId}-page-${page}${subsetKey}`,

---

160-166: Safely log unknown errors

error is unknown. Narrow to Error before accessing .message.

-    await log({
-      message: "New bounties published cron failed. Error: " + error.message,
+    const msg =
+      error instanceof Error ? error.message : JSON.stringify(error);
+    await log({
+      message: "New bounties published cron failed. Error: " + msg,
       type: "errors",
     });

apps/web/lib/partners/approve-partner-enrollment.ts (1)

177-182: Optionally include startsAt in helper to schedule closer to go-live

If you want to avoid the cron handler re-queues, extend getBountiesByGroup to select startsAt and schedule notBefore = max(now+1h, startsAt+60s).

apps/web/lib/actions/partners/bulk-approve-partners.ts (1)

195-206: Chunk partnerIds to keep QStash payloads small and resilient

Large groups can produce big payloads. Chunking reduces risk of hitting request size/time limits and eases retries.

-          for (const bounty of bounties) {
-            bountyNotificationPromises.push(
-              qstash.publishJSON({
-                url: `${APP_DOMAIN_WITH_NGROK}/api/cron/bounties/notify-partners`,
-                body: {
-                  bountyId: bounty.id,
-                  partnerIds: partners.map((p) => p.id),
-                },
-                notBefore:
-                  Math.floor(new Date().getTime() / 1000) + 1 * 60 * 60, // 1 hour from now
-              }),
-            );
-          }
+          for (const bounty of bounties) {
+            for (const partnerIdChunk of chunk(
+              partners.map((p) => p.id),
+              500,
+            )) {
+              bountyNotificationPromises.push(
+                qstash.publishJSON({
+                  url: `${APP_DOMAIN_WITH_NGROK}/api/cron/bounties/notify-partners`,
+                  body: {
+                    bountyId: bounty.id,
+                    partnerIds: partnerIdChunk,
+                  },
+                  notBefore:
+                    Math.floor(Date.now() / 1000) + 60 * 60, // 1 hour from now
+                }),
+              );
+            }
+          }

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

Learnt from: TWilson023
PR: dubinc/dub#2736
File: apps/web/lib/api/bounties/get-bounty-or-throw.ts:53-63
Timestamp: 2025-08-26T15:38:48.173Z
Learning: In bounty-related code, getBountyOrThrow returns group objects with { id } field (transformed from BountyGroup.groupId), while other routes working directly with BountyGroup Prisma records use the actual groupId field. This is intentional - getBountyOrThrow abstracts the join table details.

Learnt from: devkiran
PR: dubinc/dub#2735
File: apps/web/lib/actions/partners/delete-reward.ts:33-41
Timestamp: 2025-08-14T05:17:51.825Z
Learning: In the partner groups system, a rewardId can only belong to one group, establishing a one-to-one relationship between rewards and groups. This means using Prisma's `update` method (rather than `updateMany`) is appropriate when updating groups by rewardId.