Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Improve comment formatting #2851

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
steven-tey merged 1 commit into from
Sep 16, 2025
Merged

Improve comment formatting #2851

steven-tey merged 1 commit into from
Sep 16, 2025

Conversation

@TWilson023
Copy link
Collaborator

@TWilson023 TWilson023 commented Sep 16, 2025 •
edited by coderabbitai bot
Loading

Handle newlines & links properly

Summary by CodeRabbit

  • Enhancements
    • Comments now automatically detect and convert URLs into clickable links in both view and edit modes.
    • Links open in a new tab for easier navigation and are underlined for clearer visibility.
    • Preserves existing text formatting and whitespace in comment content.
    • Improves readability and quick access to referenced resources across partner comment threads.

@vercel
Copy link
Contributor

vercel bot commented Sep 16, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Updated (UTC)
dub Building Building Preview Sep 16, 2025 9:15pm

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Sep 16, 2025 •
edited
Loading

Caution

Review failed

The pull request is closed.

Walkthrough

Introduces linkify-react to automatically convert URLs in comment text into clickable links within page-client.tsx. Wraps comment rendering in both editing and non-editing branches with Linkify configured for target "_blank", rel "noopener noreferrer nofollow", and an underline link class. No API, mutation, or public interface changes.

Changes

Cohort / File(s) Summary
Comment linkification in dashboard
apps/web/app/app.dub.co/(dashboard)/[slug]/(ee)/program/partners/[partnerId]/comments/page-client.tsx		 Import Linkify and wrap comment text render paths with Linkify (as <p>) to auto-link URLs; configure target="_blank", rel="noopener noreferrer nofollow", and link underline class; applies to both editing and non-editing displays; no changes to data flow or exports.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

  • Partner comment editing #2850 — Modifies the same page-client.tsx comment component, introducing in-place editing branches that this PR’s linkification now wraps.

Suggested reviewers

  • steven-tey

Poem

A hop, a link, a twinkling trail,
URLs now sail with every tale.
In comments’ burrows, bright and neat,
They open new tabs—what a treat!
I nibble code, ears all a-flutter,
Linkified words, smooth as butter. 🐇✨

✨ Finishing touches
  • 📝 Generate Docstrings
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch comment-formatting
📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between fa8f4c6 and df7ac7e.

📒 Files selected for processing (1)
  • apps/web/app/app.dub.co/(dashboard)/[slug]/(ee)/program/partners/[partnerId]/comments/page-client.tsx (2 hunks)

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@steven-tey steven-tey merged commit 04c160f into main Sep 16, 2025
6 of 9 checks passed
@steven-tey steven-tey deleted the comment-formatting branch September 16, 2025 21:17
@coderabbitai coderabbitai bot mentioned this pull request Nov 17, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@steven-tey steven-tey steven-tey approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@TWilson023 @steven-tey