Reviewing files that changed from the base of the PR and between 3d7f0ba and 934bb7c.

• apps/web/app/(ee)/api/bounties/[bountyId]/route.ts (4 hunks)
• apps/web/app/(ee)/api/bounties/route.ts (3 hunks)
• apps/web/app/app.dub.co/(dashboard)/[slug]/(ee)/program/bounties/add-edit-bounty-sheet.tsx (14 hunks)
• apps/web/lib/actions/partners/create-bounty-submission.ts (2 hunks)
• apps/web/lib/api/bounties/get-bounty-with-details.ts (2 hunks)
• apps/web/lib/api/bounties/validate-bounty.ts (1 hunks)
• apps/web/lib/webhook/sample-events/bounty-created.json (1 hunks)
• apps/web/lib/webhook/sample-events/bounty-updated.json (1 hunks)
• apps/web/lib/zod/schemas/bounties.ts (2 hunks)
• apps/web/tests/bounties/index.test.ts (4 hunks)
• apps/web/ui/partners/bounties/claim-bounty-modal.tsx (4 hunks)
• packages/prisma/schema/bounty.prisma (2 hunks)

• GitHub Check: build

apps/web/lib/webhook/sample-events/bounty-updated.json (1)

8-8: Consistent field in update sample.

Addition is consistent with create sample. Same suggestion to document that null ⇒ always open.

Would you like me to add a brief README entry for webhook consumers?

apps/web/app/app.dub.co/(dashboard)/[slug]/(ee)/program/bounties/add-edit-bounty-sheet.tsx (1)

371-379: Submit flow: ensure endsAt present when submission window is set.

You already block in the validator, good. Consider server-side revalidation too (validateBounty) to avoid coupling to UI.

Do we enforce “submissionWindow ⇒ endsAt required” on the server?

apps/web/ui/partners/bounties/claim-bounty-modal.tsx (1)

143-146: hasSubmissionsOpen logic is correct.

Treating null as open and future dates as closed matches the rest of the PR.

apps/web/lib/zod/schemas/bounties.ts (1)

55-57: Default startsAt on create required — validateBounty not found

createBountySchema allows startsAt to be nullish while BountySchema.startsAt is non-null (z.date()). Ensure the create path (validateBounty or the create handler) sets startsAt = new Date() when omitted to avoid DB insert failures. I could not find validateBounty in the repo — confirm its location or add defaulting in the create flow. submissionsOpenAt alignment is correct (create: parseDateSchema.nullish() vs BountySchema: z.date().nullable()).

apps/web/lib/api/bounties/get-bounty-with-details.ts (1)

19-20: Include submissionsOpenAt end-to-end (LGTM) — verify schema parity.

Selection and return wiring look correct. Please confirm BountySchemaExtended includes submissionsOpenAt to avoid parse errors at GET time.

Also applies to: 98-99

apps/web/lib/actions/partners/create-bounty-submission.ts (1)

18-18: New date-fns import is appropriate.

apps/web/app/(ee)/api/bounties/[bountyId]/route.ts (3)

4-4: Centralized validation import (LGTM).

---

62-63: PATCH payload now accepts submissionsOpenAt (LGTM).

---

150-153: Persist submissionsOpenAt (LGTM).

Note: passing undefined to Prisma omits the field update; this is fine here.

apps/web/app/(ee)/api/bounties/route.ts (4)

3-3: Centralized validation import (LGTM).

---

109-123: Create payload includes submissionsOpenAt (LGTM).

---

124-126: Defaulting startsAt on create (LGTM).

---

195-196: Persist submissionsOpenAt on create (LGTM).

apps/web/tests/bounties/index.test.ts (2)

2-2: Helper date utilities import (LGTM).

---

26-26: Fixture parity: submissionsOpenAt null baseline (LGTM).

apps/web/lib/api/bounties/validate-bounty.ts (7)

7-15: LGTM! Well-structured validation function signature.

The function signature clearly defines the bounty validation parameters and uses proper TypeScript typing with the CreateBountyInput type.

---

18-24: LGTM! Proper date validation with clear error message.

The validation correctly ensures that endsAt is on or after startsAt, and the error message is descriptive and user-friendly.

---

26-42: LGTM! Comprehensive submissions timing validation.

The validation logic correctly enforces the date relationship constraints:

• submissionsOpenAt must be on or after startsAt
• submissionsOpenAt must be on or before endsAt (when endsAt is provided)

The error messages are clear and informative.

---

44-57: LGTM! Proper reward validation logic.

The validation correctly handles the different reward requirements:

• Performance bounties require a rewardAmount
• Submission bounties require either rewardAmount or rewardDescription

This aligns with the learning from previous reviews about bounty submission requirements.

---

59-64: LGTM! Good defensive validation.

The negative reward amount check is appropriate and provides a clear error message.

---

66-71: LGTM! Validates performance scope requirement.

The validation correctly ensures that performance bounties have the required performanceScope field set.

---

1-72: Verify integration with bounty creation/update endpoints — path missing

The prior verification failed: apps/web/app/.*api.*bounties was not found, so I could not confirm that route handlers now call validateBounty or that inline date/reward checks were removed. Run these from the repo root and paste results:

rg -n --hidden -S 'validateBounty' || true
rg -n --hidden -S 'startsAt.*endsAt|endsAt.*startsAt|submissionsOpenAt.*startsAt|startsAt.*submissionsOpenAt|rewardAmount.*rewardDescription|rewardDescription.*rewardAmount|performanceScope' || true

Reviewing files that changed from the base of the PR and between 783356f and 7b88c26.

• apps/web/app/app.dub.co/(dashboard)/[slug]/(ee)/program/bounties/add-edit-bounty-sheet.tsx (14 hunks)

• GitHub Check: build

apps/web/app/app.dub.co/(dashboard)/[slug]/(ee)/program/bounties/add-edit-bounty-sheet.tsx (3)

838-841: Double‑check disabled state interplay with loading.

Button is disabled by validationError even while loading; ensure this doesn’t mask a state where loading is true and form becomes valid mid‑request. Likely fine, but worth confirming.

If needed, I can scan other sheets for consistent disabled/loading patterns.

---

265-275: Don’t compare end date to “now” when start date is unset.

Only validate end-after-start if a start date is explicitly set.

-    const effectiveStartDate = startsAt || new Date();
-
-    if (endsAt && endsAt <= effectiveStartDate) {
-      return `Please choose an end date that is after the start date (${formatDate(effectiveStartDate)}).`;
-    }
+    if (startsAt && endsAt && endsAt <= startsAt) {
+      return `Please choose an end date that is after the start date (${formatDate(startsAt)}).`;
+    }

---

287-289: Enforce reward > 0 in UI to align with server min(1).

-      if (rewardType === "flat" && isEmpty(rewardAmount)) {
+      if (rewardType === "flat" && (rewardAmount == null || Number(rewardAmount) <= 0)) {
         return "Reward amount is required for flat rate rewards.";
       }
@@
-      if (isEmpty(rewardAmount)) {
+      if (rewardAmount == null || Number(rewardAmount) <= 0) {
         return "Reward amount is required.";
       }

Also align RHF rules:

                             rules={{
-                              required: true,
-                              min: 0,
+                              required: true,
+                              min: 1,
                             }}

Also applies to: 305-307, 636-638

Reviewing files that changed from the base of the PR and between 3d7f0ba and 7b88c26.

• apps/web/app/(ee)/api/bounties/[bountyId]/route.ts (4 hunks)
• apps/web/app/(ee)/api/bounties/route.ts (3 hunks)
• apps/web/app/app.dub.co/(dashboard)/[slug]/(ee)/program/bounties/add-edit-bounty-sheet.tsx (14 hunks)
• apps/web/lib/actions/partners/create-bounty-submission.ts (2 hunks)
• apps/web/lib/api/bounties/get-bounty-with-details.ts (2 hunks)
• apps/web/lib/api/bounties/validate-bounty.ts (1 hunks)
• apps/web/lib/webhook/sample-events/bounty-created.json (1 hunks)
• apps/web/lib/webhook/sample-events/bounty-updated.json (1 hunks)
• apps/web/lib/zod/schemas/bounties.ts (2 hunks)
• apps/web/tests/bounties/index.test.ts (5 hunks)
• apps/web/ui/partners/bounties/claim-bounty-modal.tsx (4 hunks)
• packages/prisma/schema/bounty.prisma (2 hunks)

apps/web/lib/webhook/sample-events/bounty-updated.json (1)

8-8: Confirm downstream tolerance for null vs. missing submissionsOpenAt

Good to include in the sample. Please verify webhook consumers and docs treat this field as optional and nullable (null or absent), and that type expectations are clearly documented.

apps/web/lib/webhook/sample-events/bounty-created.json (1)

8-8: Align webhook docs and consumers with new submissionsOpenAt

Same note as the update event: ensure consumers accept null and that docs specify ISO 8601 string when present.

apps/web/lib/api/bounties/get-bounty-with-details.ts (1)

19-19: LGTM: submissionsOpenAt is selected and returned

Field is plumbed through correctly.

Please confirm the returned type (Date vs ISO string) matches PartnerBountyProps expectations to avoid runtime parsing issues in the UI.

Also applies to: 98-99

apps/web/app/(ee)/api/bounties/[bountyId]/route.ts (1)

86-94: No await needed here.

validateBounty is synchronous in this PR; the prior “missing await” feedback is obsolete.

apps/web/app/(ee)/api/bounties/route.ts (1)

127-135: No await required.

validateBounty is synchronous in this PR; earlier “missing await” comments don’t apply.

apps/web/app/app.dub.co/(dashboard)/[slug]/(ee)/program/bounties/add-edit-bounty-sheet.tsx (8)

265-275: Validate endsAt only when a start date is explicitly set.

Avoid false failures due to effectiveStartDate fallback.

-    const effectiveStartDate = startsAt || new Date();
-
-    if (endsAt && endsAt <= effectiveStartDate) {
-      return `Please choose an end date that is after the start date (${formatDate(effectiveStartDate)}).`;
-    }
+    if (startsAt && endsAt && endsAt <= startsAt) {
+      return `Please choose an end date that is after the start date (${formatDate(startsAt)}).`;
+    }

---

287-293: Don’t allow zero rewards in UI.

0 passes isEmpty; enforce > 0.

-      if (rewardType === "flat" && isEmpty(rewardAmount)) {
+      if (rewardType === "flat" && (rewardAmount == null || rewardAmount <= 0)) {
         return "Reward amount is required for flat rate rewards.";
       }

---

305-307: Performance reward must be > 0.

Mirror server constraint.

-      if (isEmpty(rewardAmount)) {
+      if (rewardAmount == null || rewardAmount <= 0) {
         return "Reward amount is required.";
       }

---

212-218: Submission window toggle should set a sensible default when enabled.

Initialize to 2 days (or your chosen default) on enable.

   useEffect(() => {
     if (!hasSubmissionWindow) {
       setValue("submissionsOpenAt", null);
       setSubmissionWindow(null);
-    }
+    } else if (submissionWindow == null) {
+      setSubmissionWindow(2);
+    }
-  }, [hasSubmissionWindow, setValue]);
+  }, [hasSubmissionWindow, setValue, submissionWindow]);

---

219-233: Guard submissionsOpenAt computation behind the toggle.

Compute only when enabled and endsAt present.

-  // Calculate the submissionsOpenAt based on the submissionWindow & endsAt
+  // Calculate submissionsOpenAt based on submissionWindow & endsAt (only when enabled)
   useEffect(() => {
-    if (!submissionWindow || !endsAt) {
+    if (!hasSubmissionWindow || !submissionWindow || !endsAt) {
       return;
     }
@@
-  }, [endsAt, submissionWindow]);
+  }, [endsAt, submissionWindow, hasSubmissionWindow]);

---

452-459: Keep the toggle visible; only collapse the input area.

The height gate hides the switch when off.

-                    <AnimatedSizeContainer
-                      height
-                      transition={{ ease: "easeInOut", duration: 0.2 }}
-                      style={{
-                        height: hasStartDate ? "auto" : "0px",
-                        overflow: "hidden",
-                      }}
-                    >
+                    <AnimatedSizeContainer
+                      height
+                      transition={{ ease: "easeInOut", duration: 0.2 }}
+                    >

---

496-503: Same: don’t hide the End date switch.

-                      style={{
-                        height: hasEndDate ? "auto" : "0px",
-                        overflow: "hidden",
-                      }}
+                      // keep the switch visible; conditionally render the picker below

---

540-580: Same: don’t hide the Submission window switch; show default in copy.

-                          style={{
-                            height: hasSubmissionWindow ? "auto" : "0px",
-                            overflow: "hidden",
-                          }}
+                          // keep the switch visible; conditionally render the stepper below
@@
-                              <p className="mt-2 text-xs text-neutral-500">
-                                Submissions open {submissionWindow} days before
+                              <p className="mt-2 text-xs text-neutral-500">
+                                Submissions open {submissionWindow ?? 2} days before
                                 the end date. Drafts can be saved until then.
                               </p>

packages/prisma/schema/bounty.prisma (1)

26-50: Schema changes look correct — run duplicate checks & plan zero‑downtime migration

The provided script only echoed SQL; execute the queries below on prod/stage and confirm they return zero rows before applying the migration.

-- 1) Duplicate submissions per bounty/partner
SELECT bountyId, partnerId, COUNT(*) c
FROM BountySubmission
GROUP BY bountyId, partnerId
HAVING c > 1;

-- 2) workflowId uniqueness check
SELECT workflowId, COUNT(*) c
FROM Bounty
WHERE workflowId IS NOT NULL
GROUP BY workflowId
HAVING c > 1;

• If any rows are returned: dedupe/backfill those records before adding the unique constraint.
• For new indexes/constraints: use a DB-specific online/zero-downtime strategy (e.g., Postgres: CREATE UNIQUE INDEX CONCURRENTLY then attach constraint or other safe workflow) or schedule a maintenance window.

apps/web/tests/bounties/index.test.ts (1)

126-155: Add negative test for submissionsOpenAt without endsAt (expect 400)

Good coverage for the submissionsOpenAt happy path; add a negative test in apps/web/tests/bounties/index.test.ts (around lines 126–155) that posts submissionsOpenAt without endsAt and asserts a 400 response.

Verification script failed in the sandbox: vitest not found (/bin/bash: line 4: vitest: command not found). Run tests locally or in CI to confirm behavior.

Reviewing files that changed from the base of the PR and between 3d7f0ba and 7b88c26.

• apps/web/app/(ee)/api/bounties/[bountyId]/route.ts (4 hunks)
• apps/web/app/(ee)/api/bounties/route.ts (3 hunks)
• apps/web/app/app.dub.co/(dashboard)/[slug]/(ee)/program/bounties/add-edit-bounty-sheet.tsx (14 hunks)
• apps/web/lib/actions/partners/create-bounty-submission.ts (2 hunks)
• apps/web/lib/api/bounties/get-bounty-with-details.ts (2 hunks)
• apps/web/lib/api/bounties/validate-bounty.ts (1 hunks)
• apps/web/lib/webhook/sample-events/bounty-created.json (1 hunks)
• apps/web/lib/webhook/sample-events/bounty-updated.json (1 hunks)
• apps/web/lib/zod/schemas/bounties.ts (2 hunks)
• apps/web/tests/bounties/index.test.ts (5 hunks)
• apps/web/ui/partners/bounties/claim-bounty-modal.tsx (4 hunks)
• packages/prisma/schema/bounty.prisma (2 hunks)

apps/web/ui/partners/bounties/claim-bounty-modal.tsx (1)

143-146: Make “open” check inclusive and robust to string Dates (repeat)

At the exact open instant, isBefore excludes opening; also guard if the value is an ISO string.

Apply this diff:

-import { formatDistanceToNow, isBefore } from "date-fns";
+import { formatDistanceToNow } from "date-fns";
@@
-  const hasSubmissionsOpen = bounty.submissionsOpenAt
-    ? isBefore(bounty.submissionsOpenAt, new Date())
-    : true;
+  const openAt = bounty.submissionsOpenAt
+    ? new Date(bounty.submissionsOpenAt as any)
+    : null;
+  const hasSubmissionsOpen = !openAt || Date.now() >= openAt.getTime();

apps/web/lib/api/bounties/get-bounty-with-details.ts (1)

19-20: LGTM — field is plumbed through SELECT and response

submissionsOpenAt is selected and returned consistently with other date fields.

Also applies to: 98-99

apps/web/app/(ee)/api/bounties/[bountyId]/route.ts (2)

86-94: Validate against effective dates to prevent invalid windows on PATCH (repeat)

Use DB values when a field is omitted to avoid defaulting to “now”.

Apply this diff:

-    validateBounty({
-      type: bounty.type,
-      startsAt,
-      endsAt,
-      submissionsOpenAt,
-      rewardAmount,
-      rewardDescription,
-      performanceScope: bounty.performanceScope,
-    });
+    const effectiveStartsAt = startsAt ?? bounty.startsAt;
+    const effectiveEndsAt = endsAt ?? bounty.endsAt;
+    const effectiveOpenAt = submissionsOpenAt ?? bounty.submissionsOpenAt;
+    await validateBounty({
+      type: bounty.type,
+      startsAt: effectiveStartsAt,
+      endsAt: effectiveEndsAt,
+      submissionsOpenAt: effectiveOpenAt,
+      rewardAmount,
+      rewardDescription,
+      performanceScope: bounty.performanceScope,
+    });

---

86-95: Await validation (repeat)

Same as POST: ensure validation runs before update.

Apply this diff if async:

-    validateBounty({
+    await validateBounty({
       type: bounty.type,
       startsAt,
       endsAt,
       submissionsOpenAt,
       rewardAmount,
       rewardDescription,
       performanceScope: bounty.performanceScope,
     });

apps/web/lib/zod/schemas/bounties.ts (1)

55-58: LGTM — schema updates align with API surface

startsAt made nullish and new submissionsOpenAt added on both create and payload schemas.

Also applies to: 96-97

apps/web/lib/actions/partners/create-bounty-submission.ts (1)

117-125: Allow saving drafts before the open time (repeat)

Gate only final submissions on submissionsOpenAt, not drafts.

Apply this diff:

-    if (bounty.submissionsOpenAt && bounty.submissionsOpenAt > now) {
+    if (!isDraft && bounty.submissionsOpenAt && bounty.submissionsOpenAt > now) {
       const waitTime = formatDistanceToNow(bounty.submissionsOpenAt, {
         addSuffix: true,
       });
 
       throw new Error(
         `Submissions are not open yet. You can submit ${waitTime}.`,
       );
     }

apps/web/app/(ee)/api/bounties/route.ts (1)

124-135: Await validation to avoid creating invalid bounties (repeat)

If validateBounty is async, this currently doesn’t block bad payloads.

Run to confirm whether validateBounty is async:

#!/bin/bash
rg -n -C2 'export (const|function) validateBounty' apps/web/lib/api/bounties/validate-bounty.ts || true
rg -n 'async function validateBounty|export const validateBounty\s*=\s*async' apps/web/lib/api/bounties/validate-bounty.ts || true

Apply this diff if async:

-    validateBounty({
+    await validateBounty({
       type,
       startsAt,
       endsAt,
       submissionsOpenAt,
       rewardAmount,
       rewardDescription,
       performanceScope,
     });

apps/web/tests/bounties/index.test.ts (1)

37-55: Investigate 500 on performance bounty creation; capture server error for faster triage.

Augment the assertion to log response body when status ≠ 200 so CI output shows the backend error cause.

-    expect(status).toEqual(200);
+    if (status !== 200) {
+      // Surface backend error in CI
+      // eslint-disable-next-line no-console
+      console.error("POST /bounties (performance) failed:", bounty);
+    }
+    expect(status).toEqual(200);

apps/web/lib/api/bounties/validate-bounty.ts (3)

44-64: Harden reward validation (undefined, non-finite, and non-positive).

Enforce > 0 for performance; for submission, allow either > 0 amount or non-empty description. Treat undefined/null/NaN/≤0 correctly.

-  if (rewardAmount === null || rewardAmount === 0) {
-    if (type === "performance") {
-      throw new DubApiError({
-        code: "bad_request",
-        message: "Reward amount is required for performance bounties.",
-      });
-    } else if (!rewardDescription) {
-      throw new DubApiError({
-        code: "bad_request",
-        message:
-          "For submission bounties, either reward amount or reward description is required.",
-      });
-    }
-  }
-
-  if (rewardAmount && rewardAmount < 0) {
+  const hasAmount = rewardAmount != null;
+  const amountValid =
+    hasAmount && Number.isFinite(rewardAmount) && rewardAmount > 0;
+
+  if (type === "performance") {
+    if (!amountValid) {
+      throw new DubApiError({
+        code: "bad_request",
+        message:
+          "Reward amount is required and must be > 0 for performance bounties.",
+      });
+    }
+  } else {
+    const hasDescription =
+      typeof rewardDescription === "string" &&
+      rewardDescription.trim().length > 0;
+    if (!amountValid && !hasDescription) {
+      throw new DubApiError({
+        code: "bad_request",
+        message:
+          "For submission bounties, either reward amount (> 0) or reward description is required.",
+      });
+    }
+    if (hasAmount && !amountValid) {
+      throw new DubApiError({
+        code: "bad_request",
+        message: "Reward amount must be > 0 when provided.",
+      });
+    }
+  }
+
+  if (hasAmount && Number.isFinite(rewardAmount) && rewardAmount < 0) {
     throw new DubApiError({
       code: "bad_request",
       message: "Reward amount cannot be negative.",
     });
   }

---

66-71: performanceScope check looks good.

Validation aligns with schema semantics; no change needed.

---

26-42: Require endsAt when submissionsOpenAt is provided; avoid comparing against undefined.

Also compare against startsAt only when startsAt exists.

-  if (submissionsOpenAt) {
-    if (submissionsOpenAt < startsAt) {
+  if (submissionsOpenAt) {
+    if (!endsAt) {
+      throw new DubApiError({
+        message:
+          "An end date (endsAt) is required when using submissionsOpenAt.",
+        code: "bad_request",
+      });
+    }
+    if (startsAt && submissionsOpenAt < startsAt) {
       throw new DubApiError({
         message:
           "Bounty submissions open date (submissionsOpenAt) must be on or after start date (startsAt).",
         code: "bad_request",
       });
     }
 
-    if (endsAt && submissionsOpenAt > endsAt) {
+    if (submissionsOpenAt > endsAt) {
       throw new DubApiError({
         message:
           "Bounty submissions open date (submissionsOpenAt) must be on or before end date (endsAt).",
         code: "bad_request",
       });
     }
   }

apps/web/app/app.dub.co/(dashboard)/[slug]/(ee)/program/bounties/add-edit-bounty-sheet.tsx (4)

219-233: Guard submissionsOpenAt computation by toggle and seed a default window.

Without this, enabling the toggle shows “2” but the form value stays null; also, we compute even when disabled.

-  // Calculate the submissionsOpenAt based on the submissionWindow & endsAt
+  // Calculate submissionsOpenAt based on submissionWindow & endsAt (only when enabled)
   useEffect(() => {
-    if (!submissionWindow || !endsAt) {
+    if (!hasSubmissionWindow || !submissionWindow || !endsAt) {
       return;
     }
@@
-  }, [endsAt, submissionWindow]);
+  }, [endsAt, submissionWindow, hasSubmissionWindow]);

Also set an initial default when enabling:

   useEffect(() => {
     if (!hasSubmissionWindow) {
       setValue("submissionsOpenAt", null);
       setSubmissionWindow(null);
     } else if (submissionWindow == null) {
       setSubmissionWindow(2);
     }
-  }, [hasSubmissionWindow, setValue]);
+  }, [hasSubmissionWindow, setValue, submissionWindow]);

---

452-459: Keep the toggle row visible; avoid height-gating the entire section.

Current AnimatedSizeContainer height style hides the Switch itself when off, making it impossible to enable.

-                    <AnimatedSizeContainer
-                      height
-                      transition={{ ease: "easeInOut", duration: 0.2 }}
-                      style={{
-                        height: hasStartDate ? "auto" : "0px",
-                        overflow: "hidden",
-                      }}
-                    >
+                    <AnimatedSizeContainer
+                      height
+                      transition={{ ease: "easeInOut", duration: 0.2 }}
+                    >

Apply similarly around lines 496-503 and 540-547.

---

265-275: Avoid “effectiveStartDate = now” fallback; only compare when startsAt exists.

Otherwise, users without a start date set are forced to choose endsAt > now due to millisecond drift.

-  const validationError = useMemo(() => {
-    if (startsAt && startsAt < new Date()) {
-      return "Please choose a start date that is in the future.";
-    }
-
-    const effectiveStartDate = startsAt || new Date();
-
-    if (endsAt && endsAt <= effectiveStartDate) {
-      return `Please choose an end date that is after the start date (${formatDate(effectiveStartDate)}).`;
-    }
+  const validationError = useMemo(() => {
+    if (startsAt && startsAt < new Date()) {
+      return "Please choose a start date that is in the future.";
+    }
+    if (startsAt && endsAt && endsAt <= startsAt) {
+      return `Please choose an end date that is after the start date (${formatDate(startsAt)}).`;
+    }

---

287-307: Enforce > 0 reward amounts in UI; don’t rely on isEmpty(0).

Match server rules: performance/flat must be strictly positive; custom requires description.

-      if (rewardType === "flat" && isEmpty(rewardAmount)) {
+      if (rewardType === "flat" && (rewardAmount == null || rewardAmount <= 0)) {
         return "Reward amount is required for flat rate rewards.";
       }
@@
-      if (isEmpty(rewardAmount)) {
+      if (rewardAmount == null || rewardAmount <= 0) {
         return "Reward amount is required.";
       }

And update the controller rule:

-                            rules={{
-                              required: true,
-                              min: 0,
-                            }}
+                            rules={{
+                              required: true,
+                              min: 1,
+                            }}

packages/prisma/schema/bounty.prisma (1)

27-50: Reconsider onDelete behavior for the Workflow relation: use SetNull instead of Cascade to preserve Bounties if a Workflow is removed.

-  workflow    Workflow?          @relation(fields: [workflowId], references: [id], onDelete: Cascade)
+  workflow    Workflow?          @relation(fields: [workflowId], references: [id], onDelete: SetNull)

Should deleting a Workflow ever delete its Bounty?

Reviewing files that changed from the base of the PR and between 7b88c26 and e325d43.

• apps/web/app/(ee)/api/bounties/[bountyId]/route.ts (4 hunks)
• apps/web/app/(ee)/api/bounties/route.ts (3 hunks)
• apps/web/app/app.dub.co/(dashboard)/[slug]/(ee)/program/bounties/add-edit-bounty-sheet.tsx (14 hunks)
• apps/web/lib/actions/partners/create-bounty-submission.ts (2 hunks)
• apps/web/lib/api/bounties/validate-bounty.ts (1 hunks)

• apps/web/lib/api/bounties/validate-bounty.ts

• GitHub Check: build

apps/web/lib/actions/partners/create-bounty-submission.ts (2)

117-129: Good: gate submissionsOpenAt only for final submissions.

This preserves draft-saving while enforcing the opening window for real submissions. Nice UX.

---

131-135: Don’t mask data integrity issues: remove fallback to [].

Per repo convention, non‑performance bounties must have submissionRequirements; falling back to [] hides broken data and weakens validation.

Apply:

-    const submissionRequirements = submissionRequirementsSchema.parse(
-      bounty.submissionRequirements || [],
-    );
+    const submissionRequirements = submissionRequirementsSchema.parse(
+      bounty.submissionRequirements,
+    );

apps/web/app/(ee)/api/bounties/route.ts (1)

127-135: Validation centralization looks good.

validateBounty is synchronous, so no await is needed. Inputs (including submissionsOpenAt) are correctly validated before create.

apps/web/app/app.dub.co/(dashboard)/[slug]/(ee)/program/bounties/add-edit-bounty-sheet.tsx (5)

454-461: Toggle becomes unreachable when off — remove height gate from the container.

Collapsing the entire block hides the Switch itself, so users can’t enable Start date.

Apply:

-                    <AnimatedSizeContainer
-                      height
-                      transition={{ ease: "easeInOut", duration: 0.2 }}
-                      style={{
-                        height: hasStartDate ? "auto" : "0px",
-                        overflow: "hidden",
-                      }}
-                    >
+                    <AnimatedSizeContainer
+                      height
+                      transition={{ ease: "easeInOut", duration: 0.2 }}
+                    >

---

498-505: Same issue for End date — keep the toggle row visible.

Remove the height style to prevent hiding the Switch when hasEndDate is false.

Apply:

-                    <AnimatedSizeContainer
-                      height
-                      transition={{ ease: "easeInOut", duration: 0.2 }}
-                      style={{
-                        height: hasEndDate ? "auto" : "0px",
-                        overflow: "hidden",
-                      }}
-                    >
+                    <AnimatedSizeContainer
+                      height
+                      transition={{ ease: "easeInOut", duration: 0.2 }}
+                    >

---

543-549: Same issue for Submission window — don’t hide the Switch.

Apply:

-                        <AnimatedSizeContainer
-                          height
-                          transition={{ ease: "easeInOut", duration: 0.2 }}
-                          style={{
-                            height: hasSubmissionWindow ? "auto" : "0px",
-                            overflow: "hidden",
-                          }}
-                        >
+                        <AnimatedSizeContainer
+                          height
+                          transition={{ ease: "easeInOut", duration: 0.2 }}
+                        >

---

289-291: Enforce > 0 for flat rewards to match server min(1).

isEmpty allows 0; the server rejects 0 via Zod min(1). Align UI to prevent avoidable errors.

Apply:

-      if (rewardType === "flat" && isEmpty(rewardAmount)) {
+      if (
+        rewardType === "flat" &&
+        (rewardAmount == null || Number(rewardAmount) <= 0)
+      ) {
         return "Reward amount is required for flat rate rewards.";
       }

---

307-309: Enforce > 0 for performance rewards as well.

Apply:

-      if (isEmpty(rewardAmount)) {
+      if (rewardAmount == null || Number(rewardAmount) <= 0) {
         return "Reward amount is required.";
       }

apps/web/app/(ee)/api/bounties/[bountyId]/route.ts (1)

86-94: Use effective DB dates for PATCH validation to prevent invalid ranges.

When startsAt/endsAt/submissionsOpenAt are omitted, validateBounty defaults startsAt to now, which can let endsAt slip before the persisted startsAt or wrongly reject valid updates. Pass effective values falling back to the current bounty’s dates.

Apply:

-    validateBounty({
-      type: bounty.type,
-      startsAt,
-      endsAt,
-      submissionsOpenAt,
-      rewardAmount,
-      rewardDescription,
-      performanceScope: bounty.performanceScope,
-    });
+    const effectiveStartsAt = startsAt ?? bounty.startsAt;
+    const effectiveEndsAt = endsAt ?? bounty.endsAt;
+    const effectiveSubmissionsOpenAt =
+      submissionsOpenAt ?? bounty.submissionsOpenAt ?? undefined;
+
+    validateBounty({
+      type: bounty.type,
+      startsAt: effectiveStartsAt,
+      endsAt: effectiveEndsAt,
+      submissionsOpenAt: effectiveSubmissionsOpenAt,
+      rewardAmount,
+      rewardDescription,
+      performanceScope: bounty.performanceScope,
+    });

Reviewing files that changed from the base of the PR and between e325d43 and 409dfce.

• apps/web/app/app.dub.co/(dashboard)/[slug]/(ee)/program/bounties/add-edit-bounty-sheet.tsx (13 hunks)
• apps/web/ui/partners/bounties/claim-bounty-modal.tsx (4 hunks)

• GitHub Check: build

apps/web/ui/partners/bounties/claim-bounty-modal.tsx (2)

28-28: Remove unused/isBefore import and prep for inclusive check

We shouldn't rely on isBefore here; we'll switch to an inclusive timestamp comparison and drop this import.

-import { isBefore } from "date-fns";

---

143-146: Make “submissions open” check inclusive and safe for Date | string

At the exact open instant the current check still reports “closed”, and passing a raw ISO/string to date-fns is brittle. Parse to Date and use an inclusive comparison.

-  const hasSubmissionsOpen = bounty.submissionsOpenAt
-    ? isBefore(bounty.submissionsOpenAt, new Date())
-    : true;
+  const openAt =
+    bounty.submissionsOpenAt instanceof Date
+      ? bounty.submissionsOpenAt
+      : bounty.submissionsOpenAt
+        ? new Date(bounty.submissionsOpenAt as string)
+        : null;
+  const hasSubmissionsOpen = !openAt || Date.now() >= openAt.getTime();

apps/web/app/app.dub.co/(dashboard)/[slug]/(ee)/program/bounties/add-edit-bounty-sheet.tsx (11)

29-36: LGTM on UI imports

The new imports for NumberStepper and formatDate support the submission window functionality correctly.

---

102-113: Submission window calculation logic is sound

The calculation using Math.ceil() and converting milliseconds to days correctly handles the submission window duration between submissionsOpenAt and endsAt.

---

133-133: Form schema extension for submissionsOpenAt

The form now properly includes the submissionsOpenAt field in the default values, aligning with the broader PR's extension of the data model.

---

185-200: Proper form state management in toggle handlers

The toggle handlers correctly manage form state with React Hook Form's setValue using appropriate flags (shouldDirty, shouldValidate). When setValue cause state update, such as dirty and touched, these flags ensure the form's dirty state is properly maintained.

---

202-233: Submission window synchronization works correctly

The logic properly synchronizes submissionsOpenAt with changes to endsAt and submissionWindow by calculating the date offset. The date manipulation using setDate(date.getDate() - submissionWindow) correctly subtracts days from the end date.

---

235-258: Helper function for submission requirements is well-structured

The updateSubmissionRequirements function correctly handles the array manipulation for image/URL requirements and maintains form state synchronization.

---

272-320: Comprehensive validation with proper date comparisons

The validation logic addresses the previous timing issues by:

1. Only validating startsAt against current time when it has changed from the existing bounty
2. Using formatDate(effectiveStartDate) in error messages for clarity
3. Properly calculating minimum time gaps and submission window constraints

The logic handles edge cases well, including the submission window not extending before the start date.

---

441-441: Correct nullification of submissionsOpenAt for performance bounties

Setting submissionsOpenAt to null for performance bounties is correct since submission windows only apply to submission-type bounties.

---

533-661: Animated submission window UI implementation is well-designed

The submission window section properly:

1. Uses AnimatedSizeContainer for smooth transitions
2. Integrates NumberStepper with appropriate min/max constraints (1-30 days)
3. Shows helpful explanatory text with dynamic values
4. Disables the toggle when no end date is set
5. Uses the correct event handlers for state synchronization

The UX is intuitive and prevents invalid states.

---

921-925: Form submission state properly managed

The submit button correctly uses validationError for disabling and shows appropriate tooltips. The dirty state checking for updates (bounty && !isDirty) prevents unnecessary API calls.

---

647-658: Accessibility Verified – The NumberStepper already applies role="spinbutton" with aria-valuenow/valuemin/valuemax, keyboard handlers, and the increment/decrement buttons include aria-labels. No changes needed.