apps/web/ui/partners/change-group-modal.tsx (2)

131-139: Minor: include workspaceId in handleChangeGroup deps.

Avoid stale workspaceId capture in the useCallback.

-  }, [changeGroup, selectedGroupId, partners]);
+  }, [changeGroup, selectedGroupId, partners, workspaceId]);

---

149-153: Minor: stale closure risk for onChangeGroup in hook.

Add onChangeGroup to the useCallback deps.

-  }, [showChangeGroupModal, setShowChangeGroupModal, partners]);
+  }, [showChangeGroupModal, setShowChangeGroupModal, partners, onChangeGroup]);

Also applies to: 161-164

apps/web/ui/partners/partner-info-group.tsx (3)

23-25: Allow clearing selection to “default” explicitly.
Consider letting the setter accept null to reset to the default group.

Apply this diff:

-  setSelectedGroupId?: (groupId: string) => void;
+  setSelectedGroupId?: (groupId: string | null) => void;

---

31-34: Prefer nullish coalescing to avoid empty‑string pitfalls; keep fallback robust.
|| treats "" as falsy. If an empty string ever flows in, we’ll erroneously fall back. Use ??.

Apply this diff:

-  const group = groups
-    ? groups.find((g) => g.id === (selectedGroupId || partner.groupId)) ||
-      groups.find((g) => g.slug === DEFAULT_PARTNER_GROUP.slug)
-    : undefined;
+  const group = groups
+    ? groups.find((g) => g.id === (selectedGroupId ?? partner.groupId)) ??
+      groups.find((g) => g.slug === DEFAULT_PARTNER_GROUP.slug)
+    : undefined;

Also, please confirm every workspace always has a "default" group; otherwise this can still be undefined. If not guaranteed, we should render a non-linked “Default Group” label when fallback is missing.

---

37-44: Potential stale onChangeGroup in useChangeGroupModal.
The hook memoizes a callback that captures onChangeGroup, but its dependency list (in the hook file) omits it. Passing a new handler here might be ignored by the modal until the next dependency change.

Apply this diff in apps/web/ui/partners/change-group-modal.tsx:

-  const ChangeGroupModalCallback = useCallback(() => {
+  const ChangeGroupModalCallback = useCallback(() => {
     return (
       <ChangeGroupModal
         showChangeGroupModal={showChangeGroupModal}
         setShowChangeGroupModal={setShowChangeGroupModal}
         partners={partners}
         onChangeGroup={onChangeGroup}
       />
     );
-  }, [showChangeGroupModal, setShowChangeGroupModal, partners]);
+  }, [showChangeGroupModal, setShowChangeGroupModal, partners, onChangeGroup]);
 
-  return useMemo(
+  return useMemo(
     () => ({
       setShowChangeGroupModal,
       ChangeGroupModal: ChangeGroupModalCallback,
     }),
-    [setShowChangeGroupModal, ChangeGroupModalCallback],
+    [setShowChangeGroupModal, ChangeGroupModalCallback],
   );

apps/web/ui/partners/partner-info-cards.tsx (4)

42-45: Symmetry with child component: allow clearing to default.
Match PartnerInfoGroup by widening the setter type to accept null.

Apply this diff:

-  setSelectedGroupId?: (groupId: string) => void;
+  setSelectedGroupId?: (groupId: string | null) => void;

---

61-68: Use nullish coalescing and verify SWR option override intent.

• Prefer ?? so empty strings don’t trigger fallback.
• Double‑check that keepPreviousData: false is intentional (it will increase UI skeleton flicker on selection change).

Apply this diff:

-  const { group } = useGroup(
-    {
-      groupIdOrSlug: partner
-        ? selectedGroupId || partner.groupId || DEFAULT_PARTNER_GROUP.slug
-        : undefined,
-    },
-    { keepPreviousData: false },
-  );
+  const { group } = useGroup(
+    {
+      groupIdOrSlug: partner
+        ? selectedGroupId ?? partner.groupId ?? DEFAULT_PARTNER_GROUP.slug
+        : undefined,
+    },
+    { keepPreviousData: false },
+  );

---

192-194: Avoid duplicate fetches (optional).
Both this component (useGroup) and PartnerInfoGroup (useGroups) fetch group data. Consider passing group down to PartnerInfoGroup (and letting it skip its SWR call when provided) to cut one network request and re-render path.

---

206-209: Reward presence check: handle zero/falsey discount.
If discount can be 0 (or another falsey but valid value), the current truthiness check will render “No rewards”. Compare against null/undefined instead.

Apply this diff:

-            group.clickReward ||
-            group.leadReward ||
-            group.saleReward ||
-            group.discount ? (
+            group.clickReward ||
+            group.leadReward ||
+            group.saleReward ||
+            (group.discount != null) ? (

If discount is an object, keep this; if it’s a number/percentage, you’re covered too.

Also applies to: 223-225

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

Learnt from: TWilson023
PR: dubinc/dub#2736
File: apps/web/lib/api/bounties/get-bounty-or-throw.ts:53-63
Timestamp: 2025-08-26T15:38:48.173Z
Learning: In bounty-related code, getBountyOrThrow returns group objects with { id } field (transformed from BountyGroup.groupId), while other routes working directly with BountyGroup Prisma records use the actual groupId field. This is intentional - getBountyOrThrow abstracts the join table details.