Add `source_transaction` to `stripe.transfers.create` #2888

devkiran · 2025-09-25T13:42:01Z

Summary by CodeRabbit

Bug Fixes
- Improves Stripe payout processing by reliably associating payouts with the originating charge from successful payments, enhancing reconciliation accuracy.
- Prevents duplicate associations for payouts that have already been processed, reducing the risk of errors in partner transfers.
- Maintains existing behavior and error handling while increasing robustness in charge-to-payout linkage.

vercel · 2025-09-25T13:42:06Z

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Preview	Updated (UTC)
dub	Ready	Preview	Sep 26, 2025 0:20am

coderabbitai · 2025-09-25T13:42:09Z

Walkthrough

Threads Stripe chargeId through the payouts flow. The API route parses chargeId from invoice.stripeChargeMetadata and passes it to sendStripePayouts. sendStripePayouts updates its signature to accept chargeId and forwards it to createStripeTransfer, which conditionally sets source_transaction when no prior payouts exist.

Changes

Cohort / File(s)	Summary
Charge-succeeded API route `apps/web/app/(ee)/api/cron/payouts/charge-succeeded/route.ts`	Parse chargeId from invoice.stripeChargeMetadata via stripeChargeMetadataSchema and pass it into sendStripePayouts alongside invoiceId.
Payout orchestration `apps/web/app/(ee)/api/cron/payouts/charge-succeeded/send-stripe-payouts.ts`	Update sendStripePayouts signature to accept `{ invoiceId, chargeId }` and forward chargeId to createStripeTransfer in per-partner transfers.
Stripe transfer utility `apps/web/lib/partners/create-stripe-transfer.ts`	Add optional chargeId param; include `source_transaction: chargeId` only when there are no previously processed payouts; otherwise omit `source_transaction`.

Sequence Diagram(s)

sequenceDiagram
  autonumber
  participant CR as Charge-Succeeded Route
  participant DB as DB (Invoice)
  participant SP as sendStripePayouts
  participant PT as createStripeTransfer
  participant ST as Stripe Transfers API

  CR->>DB: Fetch invoice by invoiceId
  DB-->>CR: Invoice with stripeChargeMetadata
  Note over CR: Parse chargeId via stripeChargeMetadataSchema
  CR->>SP: sendStripePayouts({ invoiceId, chargeId })

  loop For each partner
    SP->>PT: createStripeTransfer({ ..., chargeId })
    alt No prior payouts
      PT->>ST: Create Transfer { source_transaction: chargeId }
    else Prior payouts exist
      PT->>ST: Create Transfer { no source_transaction }
    end
    ST-->>PT: Transfer result
    PT-->>SP: Transfer outcome
  end

  SP-->>CR: Payouts processed
  Note over CR,SP: Existing error handling unchanged

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~25 minutes

Possibly related PRs

Refactor payout processing to use invoiceId only #2643 — Touches the same payout flow files, adjusting reliance on invoiceId vs. chargeId; changes appear in opposing directions.
Improve payout descriptions #2703 — Modifies create-stripe-transfer.ts (description/types), overlapping with this PR’s additions of chargeId and source_transaction logic.
Add createStripeTransfer function #2674 — Updates sendStripePayouts and createStripeTransfer around threading chargeId, directly intersecting this PR’s changes.

Suggested reviewers

steven-tey

Poem

I hop through ledgers, light and spry,
Threading chargeId needles nigh—
A tuft of code, a tidy trail,
From invoice burrow to payout vale.
Source_transactions set just right—
Carrots balanced, ledgers bright. 🥕✨

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 50.00% which is insufficient. The required threshold is 80.00%.	You can run `@coderabbitai generate docstrings` to improve docstring coverage.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title Check	✅ Passed	The title clearly and concisely summarizes the primary change by stating that the `source_transaction` field is being added to the `stripe.transfers.create` call, which directly reflects the core update in the pull request. It is specific enough for a reviewer to understand the intent without unnecessary detail or jargon and avoids vague terms.

✨ Finishing touches

📝 Generate Docstrings

🧪 Generate unit tests

Create PR with unit tests
Post copyable unit tests in a comment
Commit unit tests in branch fix-payouts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

coderabbitai

Actionable comments posted: 2

Caution

Some comments are outside the diff and can’t be posted inline due to platform limitations.

⚠️ Outside diff range comments (1)

apps/web/app/(ee)/api/cron/payouts/charge-succeeded/send-stripe-payouts.ts (1)
7-95: Propagate optional chargeId through the payout flow

Once we allow the route to continue without a charge id, this signature needs to match. Treating chargeId as required will keep TypeScript satisfied yet still hand undefined to createStripeTransfer, producing an invalid source_transaction. Please make the parameter optional and only forward it when present.
-export async function sendStripePayouts({
-  invoiceId,
-  chargeId,
-}: {
-  invoiceId: string;
-  chargeId: string;
-}) {
+export async function sendStripePayouts({
+  invoiceId,
+  chargeId,
+}: {
+  invoiceId: string;
+  chargeId?: string;
+}) {
...
-      chargeId,
+      chargeId,

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 75afa6b and bf6051f.

📒 Files selected for processing (3)

apps/web/app/(ee)/api/cron/payouts/charge-succeeded/route.ts (2 hunks)
apps/web/app/(ee)/api/cron/payouts/charge-succeeded/send-stripe-payouts.ts (2 hunks)
apps/web/lib/partners/create-stripe-transfer.ts (2 hunks)

🧰 Additional context used

🧠 Learnings (2)

📓 Common learnings

Learnt from: devkiran
PR: dubinc/dub#2635
File: packages/prisma/schema/payout.prisma:24-25
Timestamp: 2025-07-11T16:28:55.693Z
Learning: In the Dub codebase, multiple payout records can now share the same stripeTransferId because payouts are grouped by partner and processed as single Stripe transfers. This is why the unique constraint was removed from the stripeTransferId field in the Payout model - a single transfer can include multiple payouts for the same partner.

📚 Learning: 2025-07-11T16:28:55.693Z

Learnt from: devkiran
PR: dubinc/dub#2635
File: packages/prisma/schema/payout.prisma:24-25
Timestamp: 2025-07-11T16:28:55.693Z
Learning: In the Dub codebase, multiple payout records can now share the same stripeTransferId because payouts are grouped by partner and processed as single Stripe transfers. This is why the unique constraint was removed from the stripeTransferId field in the Payout model - a single transfer can include multiple payouts for the same partner.

Applied to files:

apps/web/app/(ee)/api/cron/payouts/charge-succeeded/send-stripe-payouts.ts
apps/web/lib/partners/create-stripe-transfer.ts

🧬 Code graph analysis (1)

apps/web/app/(ee)/api/cron/payouts/charge-succeeded/route.ts (1)

apps/web/app/(ee)/api/cron/payouts/charge-succeeded/send-stripe-payouts.ts (1)

sendStripePayouts (7-118)

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)

GitHub Check: build

apps/web/app/(ee)/api/cron/payouts/charge-succeeded/route.ts

apps/web/lib/partners/create-stripe-transfer.ts

Add source_transaction to stripe.transfers.create

bf6051f

coderabbitai bot reviewed Sep 25, 2025

View reviewed changes

apps/web/app/(ee)/api/cron/payouts/charge-succeeded/route.ts Show resolved Hide resolved

apps/web/lib/partners/create-stripe-transfer.ts Show resolved Hide resolved

vercel bot deployed to Preview September 25, 2025 13:46 View deployment

Merge branch 'main' into fix-payouts

bd4ee2f

vercel bot deployed to Preview September 26, 2025 00:20 View deployment

steven-tey approved these changes Sep 26, 2025

View reviewed changes

steven-tey merged commit dda5f45 into main Sep 26, 2025
8 checks passed

steven-tey deleted the fix-payouts branch September 26, 2025 00:36

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Add `source_transaction` to `stripe.transfers.create` #2888

Add `source_transaction` to `stripe.transfers.create` #2888

Uh oh!

devkiran commented Sep 25, 2025 •

edited by coderabbitai bot

Loading

Uh oh!

vercel bot commented Sep 25, 2025 •

edited

Loading

Uh oh!

coderabbitai bot commented Sep 25, 2025 •

edited

Loading

Uh oh!

coderabbitai bot left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Add source_transaction to stripe.transfers.create #2888

Add source_transaction to stripe.transfers.create #2888

Uh oh!

Conversation

devkiran commented Sep 25, 2025 • edited by coderabbitai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Uh oh!

vercel bot commented Sep 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

coderabbitai bot commented Sep 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Sequence Diagram(s)

Estimated code review effort

Possibly related PRs

Suggested reviewers

Poem

Pre-merge checks and finishing touches

Uh oh!

coderabbitai bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Add `source_transaction` to `stripe.transfers.create` #2888

Add `source_transaction` to `stripe.transfers.create` #2888

devkiran commented Sep 25, 2025 •

edited by coderabbitai bot

Loading

vercel bot commented Sep 25, 2025 •

edited

Loading

coderabbitai bot commented Sep 25, 2025 •

edited

Loading