apps/web/app/(ee)/api/stripe/integration/webhook/checkout-session-completed.ts (4)

609-620: Consider idempotency for lead recording.

The function records a lead without checking if one already exists for this customer. If the Stripe webhook is retried, this could result in duplicate lead events in Tinybird.

If Tinybird does not deduplicate based on event_id, consider checking for an existing lead before recording:

// Check if lead already exists
const existingLead = await getLeadEvent({ customerId: customer.id }).then(
  (res) => res.data[0],
);

if (!existingLead) {
  await recordLead(leadEvent);
}

Alternatively, ensure the Redis idempotency check (lines 267-293) covers lead creation as well, or leverage Tinybird's deduplication if available.

---

522-572: Consider structured error logging.

The function uses console.log for error messages before returning null. In production, these errors might be difficult to track without structured logging or error monitoring.

Consider using a structured logger or error tracking service (e.g., Sentry) to capture these failure scenarios with context:

logger.warn("Promotion code attribution failed", {
  reason: "promotion_code_not_found",
  promotionCodeId,
  stripeAccountId,
});

This will improve observability and make debugging easier.

---

581-590: Document the "Unknown" fallback for missing address data.

When customer address data is missing from the Stripe checkout session, the code falls back to "Unknown" for continent, country, and region. This is reasonable for handling incomplete data, but it might affect analytics and reporting.

Consider documenting this behavior in a comment to clarify the expected impact on analytics:

// Note: If customer address is missing, we use "Unknown" for geo fields.
// This ensures attribution succeeds but may affect geo-based analytics.
const clickEvent = await recordFakeClick({
  link,
  customer: {
    continent: customerAddress?.country
      ? COUNTRIES_TO_CONTINENTS[customerAddress.country]
      : "Unknown",
    country: customerAddress?.country ?? "Unknown",
    region: customerAddress?.state ?? "Unknown",
  },
});

---

599-599: Use the stripeCustomerId variable instead of unsafe casting.

Line 599 casts charge.customer as string, but according to Stripe types, charge.customer can be a string | Stripe.Customer | Stripe.DeletedCustomer | null. While the main handler verifies stripeCustomerId is present (line 145), directly casting here is fragile.

Pass stripeCustomerId as a parameter to attributeViaPromoCode and use it directly:

 async function attributeViaPromoCode({
   promotionCodeId,
   stripeAccountId,
   livemode,
   charge,
+  stripeCustomerId,
 }: {
   promotionCodeId: string;
   stripeAccountId: string;
   livemode: boolean;
   charge: Stripe.Checkout.Session;
+  stripeCustomerId: string;
 }) {
   // ...
   const customer = await prisma.customer.create({
     data: {
       // ...
-      stripeCustomerId: charge.customer as string,
+      stripeCustomerId,
       // ...
     },
   });

Then update the callers at lines 180 and 224 to pass stripeCustomerId.

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro