Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Fix race condition preventing duplicate commissions in bounty workflow #2945

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
devkiran wants to merge 3 commits into from
Closed

Fix race condition preventing duplicate commissions in bounty workflow #2945

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
153441f
Update execute-award-bounty-workflow.ts
devkiran Oct 8, 2025
251b8e5
Update execute-award-bounty-workflow.ts
devkiran Oct 8, 2025
809e71d
Update execute-award-bounty-workflow.ts
devkiran Oct 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
162 changes: 87 additions & 75 deletions apps/web/lib/api/workflows/execute-award-bounty-workflow.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,11 +38,6 @@ export const executeAwardBountyWorkflow = async ({
include: {
program: true,
groups: true,
submissions: {
where: {
partnerId,
},
},
},
});

Expand Down Expand Up @@ -74,11 +69,9 @@ export const executeAwardBountyWorkflow = async ({
return;
}

const { groups, submissions } = bounty;

// If the bounty is part of a group, check if the partner is in the group
if (groups.length > 0) {
const groupIds = groups.map(({ groupId }) => groupId);
if (bounty.groups.length > 0) {
const groupIds = bounty.groups.map(({ groupId }) => groupId);

if (!groupIds.includes(groupId)) {
console.log(
Expand All @@ -88,14 +81,6 @@ export const executeAwardBountyWorkflow = async ({
}
}

// Check if the partner's submission has already been approved
if (submissions.length > 0 && submissions[0].status === "approved") {
console.log(
`Partner ${partnerId} has already been awarded this bounty (bountyId: ${bounty.id}, submissionId: ${submissions[0].id}).`,
);
return;
}

console.log(
`Partner is eligible for bounty ${bounty.id}, executing workflow ${bounty.workflowId}...`,
);
Expand All @@ -119,75 +104,102 @@ export const executeAwardBountyWorkflow = async ({

const performanceCount = finalContext[condition.attribute] ?? 0;

// Create or update the submission
const bountySubmission = await prisma.bountySubmission.upsert({
where: {
bountyId_partnerId: {
bountyId,
const updatedSubmission = await prisma.$transaction(async (tx) => {
const existingSubmission = await tx.bountySubmission.findUnique({
where: {
bountyId_partnerId: {
bountyId,
partnerId,
},
},
});

if (existingSubmission?.status === "approved") {
console.log(
`Partner ${partnerId} has already been awarded this bounty (bountyId: ${bounty.id}, submissionId: ${existingSubmission.id}).`,
);
return;
}

const bountySubmission = await tx.bountySubmission.upsert({
where: {
bountyId_partnerId: {
bountyId,
partnerId,
},
},
create: {
id: createId({ prefix: "bnty_sub_" }),
programId: bounty.programId,
partnerId,
bountyId: bounty.id,
status: "draft",
performanceCount,
},
},
create: {
id: createId({ prefix: "bnty_sub_" }),
programId: bounty.programId,
partnerId,
bountyId: bounty.id,
status: "draft",
performanceCount,
},
update: {
performanceCount: {
increment: performanceCount,
update: {
performanceCount: {
increment: performanceCount,
},
},
},
});
});

// Check if the bounty submission meet the reward criteria
const shouldExecute = evaluateWorkflowCondition({
condition,
attributes: {
[condition.attribute]: bountySubmission.performanceCount,
},
});
const shouldExecute = evaluateWorkflowCondition({
condition,
attributes: {
[condition.attribute]: bountySubmission.performanceCount,
},
});

if (!shouldExecute) {
console.log(
`Bounty submission ${bountySubmission.id} does not meet the trigger condition.`,
);
return;
}
if (!shouldExecute) {
console.log(
`Bounty submission ${bountySubmission.id} does not meet the trigger condition.`,
);
return;
}

// Create the commission for the partner
const { commission } = await createPartnerCommission({
event: "custom",
partnerId,
programId: bounty.programId,
amount: bounty.rewardAmount,
quantity: 1,
description: `Commission for successfully completed "${bounty.name}" bounty.`,
skipWorkflow: true,
if (bountySubmission.commissionId) {
console.log(
`Bounty submission ${bountySubmission.id} already has a commission ${bountySubmission.commissionId}.`,
);
return;
}

const { commission } = await createPartnerCommission({
event: "custom",
partnerId,
programId: bounty.programId,
amount: bounty.rewardAmount ?? 0,
quantity: 1,
description: `Commission for successfully completed "${bounty.name}" bounty.`,
skipWorkflow: true,
});

if (!commission) {
console.error(
`Failed to create commission for partner ${partnerId} in program ${bounty.programId} for bounty ${bounty.id}.`,
);
return;
}

return await tx.bountySubmission.update({
where: {
id: bountySubmission.id,
},
data: {
commissionId: commission.id,
status: "approved",
},
include: {
partner: true,
},
});
});

if (!commission) {
console.error(
`Failed to create commission for partner ${partnerId} in program ${bounty.programId} for bounty ${bounty.id}.`,
);
if (!updatedSubmission) {
return;
}

// Update the bounty submission
const { partner } = await prisma.bountySubmission.update({
where: {
id: bountySubmission.id,
},
data: {
commissionId: commission.id,
status: "approved",
},
include: {
partner: true,
},
});
const { partner } = updatedSubmission;

if (partner.email) {
await sendEmail({
Expand Down