Update group and partner selector hover styling #2950

marcusljf · 2025-10-09T18:26:10Z

Changed hover background color to bg-subtle
Increased border radius to rounded-lg
Reduced button size (px-2, py-1, h-8) to match the all groups button
included the partner selector as well to match

After

Before

Summary by CodeRabbit

Style
- Updated header variant styling for the group selector button: adjusted padding, fixed height, rounded corners, and subtler hover background for a cleaner, more consistent look.
- Mirrored the same header variant refinements for the partner selector combobox button to improve visual polish and slightly increase tap/click target without changing behavior.

- Changed hover background color to `bg-subtle` - Increased border radius to `rounded-lg` - Reduced button size (px-2, py-1, h-8) for more compact appearance

vercel · 2025-10-09T18:26:15Z

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Preview	Updated (UTC)
dub	Ready	Preview	Oct 9, 2025 7:57pm

coderabbitai · 2025-10-09T18:26:51Z

Walkthrough

Updated CSS classes for the header-variant button in GroupSelector and PartnerSelector: adjusted padding, height, hover background, and border radius. No logic, data flow, or API changes.

Changes

Cohort / File(s)	Summary
UI styling tweaks `apps/web/ui/partners/groups/group-selector.tsx`, `apps/web/ui/partners/partner-selector.tsx`	Replaced header-variant Combobox/button CSS classes: changed padding to `px-2` `py-1`, set `h-8`, added `rounded-lg`, and adjusted hover/background token classes; purely visual changes, no functional edits.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

Adds partner fast switcher #2931 — Modifies the same selector components and header-variant button styling, likely related.

Suggested reviewers

steven-tey

Poem

Thump-thump, I tweak with gentle might,
A button’s coat made neat and light—
Soft hovers glow, rounded edges bright,
I nibble CSS by moonlit night,
Ship the style, hop out of sight. 🐇✨

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	You can run `@coderabbitai generate docstrings` to improve docstring coverage.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title Check	✅ Passed	The title clearly indicates that both the group and partner selector components have had their hover styling updated, which directly reflects the main visual change made in the pull request; it is concise, specific, and omits unnecessary detail.

✨ Finishing touches

📝 Generate docstrings

🧪 Generate unit tests (beta)

Create PR with unit tests
Post copyable unit tests in a comment
Commit unit tests in branch group-quick-select

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

Matching the group selector hover state

coderabbitai

Actionable comments posted: 1

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 42b7646 and 489646d.

📒 Files selected for processing (1)

apps/web/ui/partners/partner-selector.tsx (1 hunks)

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)

GitHub Check: build

coderabbitai · 2025-10-09T19:54:45Z

apps/web/ui/partners/partner-selector.tsx

              disabled,
              className:
-                "w-full justify-start px-3 transition-none max-md:bg-bg-subtle hover:bg-bg-emphasis md:hover:bg-neutral-50 border-none",
+                "w-full justify-start px-2 py-1 h-8 transition-none max-md:bg-bg-subtle hover:bg-bg-subtle md:hover:bg-subtle border-none rounded-lg",


⚠️ Potential issue | 🔴 Critical

🧩 Analysis chain

Verify the bg-bg-subtle token validity.

The token bg-bg-subtle appears to have a redundant bg- prefix. Typically, design system tokens follow the pattern bg-subtle (as used in md:hover:bg-subtle on the same line). This looks like a typo or an invalid token that could cause incorrect styling.

If bg-bg-subtle is invalid, apply this diff to correct the token:

- "w-full justify-start px-2 py-1 h-8 transition-none max-md:bg-bg-subtle hover:bg-bg-subtle md:hover:bg-subtle border-none rounded-lg", + "w-full justify-start px-2 py-1 h-8 transition-none max-md:bg-subtle hover:bg-subtle md:hover:bg-subtle border-none rounded-lg",

Run the following script to check if bg-bg-subtle is a valid token in your design system:

🏁 Script executed:

#!/bin/bash # Description: Search for bg-bg-subtle token definition in the codebase and design system configs # Search for token definitions in config files echo "=== Searching for bg-bg-subtle in design system configs ===" fd -e js -e ts -e json config tailwind theme | xargs rg -l "bg-bg-subtle" # Search for other usages of this token echo "=== Searching for other usages of bg-bg-subtle ===" rg -n "bg-bg-subtle" --type ts --type tsx -g '!*.test.*' # Search for similar bg-subtle token for comparison echo "=== Searching for bg-subtle token usages ===" rg -n "bg-subtle" --type ts --type tsx -g '!*.test.*' | head -20

Length of output: 1385

🏁 Script executed:

#!/bin/bash # Locate Tailwind config file(s) echo "=== Locating Tailwind config files ===" fd --ignore-case --full-path "tailwind.config" -t f # Search for 'bg-bg-subtle' in config echo "=== Searching for 'bg-bg-subtle' in Tailwind config ===" fd --ignore-case --full-path "tailwind.config" -t f | xargs rg -n "bg-bg-subtle" # Search for 'subtle' definitions in config colors echo "=== Searching for 'subtle' in color definitions ===" fd --ignore-case --full-path "tailwind.config" -t f | xargs rg -n "subtle"

Length of output: 1280

Replace invalid bg-bg-subtle with bg-subtle
bg-bg-subtle isn’t defined in any Tailwind config; use bg-subtle instead (apps/web/ui/partners/partner-selector.tsx:118).

- max-md:bg-bg-subtle hover:bg-bg-subtle + max-md:bg-subtle hover:bg-subtle

📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change

"w-full justify-start px-2 py-1 h-8 transition-none max-md:bg-bg-subtle hover:bg-bg-subtle md:hover:bg-subtle border-none rounded-lg",

"w-full justify-start px-2 py-1 h-8 transition-none max-md:bg-subtle hover:bg-subtle md:hover:bg-subtle border-none rounded-lg",

🤖 Prompt for AI Agents

In apps/web/ui/partners/partner-selector.tsx around line 118, the class list contains an invalid Tailwind class `bg-bg-subtle`; replace `bg-bg-subtle` with the correct `bg-subtle` in that string so the background utility matches the configured Tailwind token and styling will apply correctly (update any occurrences on that line to use `bg-subtle`).

Update group selector hover styling

42b7646

- Changed hover background color to `bg-subtle` - Increased border radius to `rounded-lg` - Reduced button size (px-2, py-1, h-8) for more compact appearance

vercel bot had a problem deploying to Preview October 9, 2025 18:27 Failure

Update PartnerSelector hover state

489646d

Matching the group selector hover state

marcusljf changed the title ~~Update group selector hover styling~~ Update group and partner selector hover styling Oct 9, 2025

coderabbitai bot reviewed Oct 9, 2025

View reviewed changes

vercel bot deployed to Preview October 9, 2025 19:57 View deployment

steven-tey approved these changes Oct 9, 2025

View reviewed changes

steven-tey merged commit 8c1b010 into main Oct 9, 2025
7 of 8 checks passed

steven-tey deleted the group-quick-select branch October 9, 2025 19:59

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Update group and partner selector hover styling #2950

Update group and partner selector hover styling #2950

Uh oh!

marcusljf commented Oct 9, 2025 •

edited by coderabbitai bot

Loading

Uh oh!

vercel bot commented Oct 9, 2025 •

edited

Loading

Uh oh!

coderabbitai bot commented Oct 9, 2025 •

edited

Loading

Uh oh!

coderabbitai bot left a comment

Uh oh!

coderabbitai bot Oct 9, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

	"w-full justify-start px-2 py-1 h-8 transition-none max-md:bg-bg-subtle hover:bg-bg-subtle md:hover:bg-subtle border-none rounded-lg",
	"w-full justify-start px-2 py-1 h-8 transition-none max-md:bg-subtle hover:bg-subtle md:hover:bg-subtle border-none rounded-lg",

Update group and partner selector hover styling #2950

Update group and partner selector hover styling #2950

Uh oh!

Conversation

marcusljf commented Oct 9, 2025 • edited by coderabbitai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Uh oh!

vercel bot commented Oct 9, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

coderabbitai bot commented Oct 9, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Estimated code review effort

Possibly related PRs

Suggested reviewers

Poem

Pre-merge checks and finishing touches

Uh oh!

coderabbitai bot left a comment

Choose a reason for hiding this comment

Uh oh!

coderabbitai bot Oct 9, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

marcusljf commented Oct 9, 2025 •

edited by coderabbitai bot

Loading

vercel bot commented Oct 9, 2025 •

edited

Loading

coderabbitai bot commented Oct 9, 2025 •

edited

Loading