Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Remove unused types #2972

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
steven-tey merged 8 commits into from
Oct 17, 2025
Merged

Remove unused types #2972

steven-tey merged 8 commits into from
Oct 17, 2025

Conversation

@devkiran
Copy link
Collaborator

@devkiran devkiran commented Oct 17, 2025 •
edited by coderabbitai bot
Loading

Summary by CodeRabbit

  • Refactor
    • Removed several unused public type exports and one unused constant, reducing the public API surface. These are internal-only changes with no visible UI or behavior changes; existing functionality remains compatible and no runtime changes are expected.

@vercel
Copy link
Contributor

vercel bot commented Oct 17, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Updated (UTC)
dub Ready Ready Preview Oct 17, 2025 10:20am

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Oct 17, 2025 •
edited
Loading

Walkthrough

Removed multiple exported type aliases and one constant across several web app modules, deleting their schema/type imports and public exports without introducing new logic or control flow changes.

Changes

Cohort / File(s) Change Summary
Core types cleaned
apps/web/lib/types.ts		 Deleted several exported type aliases and removed their schema imports/exports (ProgramPartnerLinkProps, ProgramInviteProps, PartnerProgramInviteProps, PayoutProps, ProgramMetrics, SaleEventTB, PayoutSchema, ProgramInviteSchema, ProgramPartnerLinkSchema, etc.).
Analytics type removed
apps/web/lib/analytics/types.ts		 Removed exported type alias PartnerEventsFilters (was inferred from partnerEventsSchema).
FirstPromoter type removed
apps/web/lib/firstpromoter/types.ts		 Removed exported type FirstPromoterCampaign and its schema import.
Webhook constants removed
apps/web/lib/webhook/constants.ts		 Removed exported constant WEBHOOK_REDIS_KEY.
Webhook types removed
apps/web/lib/webhook/types.ts		 Removed exported type WebhookTrigger and its dependency on WEBHOOK_TRIGGERS.
UI guide type removed
apps/web/ui/guides/integrations.ts		 Removed exported type IntegrationGuideWithMarkdown (dropped markdown field from public type).

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Multiple small-but-dispersed removals across several modules—reviewers should verify no remaining references/imports and that public API expectations are preserved.

Possibly related PRs

Poem

🐇 I hopped through code at break of day,

Trimmed old types tidy — whisked away.
Fewer names now in the sun,
A cleaner warren, work well done.
Emojis and carrots, one for play 🥕✨

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title Check ✅ Passed The pull request title "Remove unused types" is directly related to the main changes in the changeset. The PR removes multiple type declarations and schema imports across six files: type aliases from types.ts, analytics/types.ts, firstpromoter/types.ts, webhook/types.ts, and guides/integrations.ts, along with one exported constant from webhook/constants.ts. The title clearly and concisely summarizes the primary action being taken without using vague terminology or unnecessary noise, making it easy for teammates to understand the changeset's purpose at a glance.
Docstring Coverage ✅ Passed No functions found in the changes. Docstring coverage check skipped.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch remove-default-exports
📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 6da9e65 and 7203a3f.

📒 Files selected for processing (6)
  • apps/web/lib/analytics/types.ts (0 hunks)
  • apps/web/lib/firstpromoter/types.ts (0 hunks)
  • apps/web/lib/types.ts (0 hunks)
  • apps/web/lib/webhook/constants.ts (0 hunks)
  • apps/web/lib/webhook/types.ts (0 hunks)
  • apps/web/ui/guides/integrations.ts (0 hunks)
💤 Files with no reviewable changes (6)
  • apps/web/ui/guides/integrations.ts
  • apps/web/lib/analytics/types.ts
  • apps/web/lib/webhook/types.ts
  • apps/web/lib/webhook/constants.ts
  • apps/web/lib/firstpromoter/types.ts
  • apps/web/lib/types.ts
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
  • GitHub Check: build

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@steven-tey steven-tey merged commit 2fa951d into main Oct 17, 2025
7 of 8 checks passed
@steven-tey steven-tey deleted the remove-default-exports branch October 17, 2025 17:17
@coderabbitai coderabbitai bot mentioned this pull request Oct 31, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@steven-tey steven-tey steven-tey approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@devkiran @steven-tey