apps/web/app/(ee)/api/cron/domains/transfer/route.ts (1)

29-36: Optional: fetch only needed fields to reduce payload.

findMany pulls full rows; you only use id (and fields mirrored in cache/analytics). Selecting minimal fields lowers memory and network I/O.

-    const links = await prisma.link.findMany({
+    const links = await prisma.link.findMany({
       where: { domain, projectId: currentWorkspaceId },
       take: 100,
       orderBy: {
         createdAt: "desc",
       },
+      select: {
+        id: true,
+        domain: true,
+        key: true,
+        url: true,
+        projectId: true,
+        folderId: true,
+        clicks: true,
+        leads: true,
+        sales: true,
+        saleAmount: true,
+        conversions: true,
+        lastClicked: true,
+        lastLeadAt: true,
+        lastConversionAt: true,
+      },
     });

apps/web/app/api/links/[linkId]/transfer/route.ts (1)

55-69: Destination role check (optional but safer).

You fetch role but only validate membership. If viewers exist, consider requiring a role with write privileges.

-    if (!newWorkspace || newWorkspace.users.length === 0) {
+    const member = newWorkspace?.users[0];
+    if (!newWorkspace || !member) {
       throw new DubApiError({
         code: "not_found",
         message: "New workspace not found.",
       });
     }
+    if (member.role === "viewer") {
+      throw new DubApiError({
+        code: "forbidden",
+        message:
+          "You don't have permission to add links in the destination workspace.",
+      });
+    }

apps/web/app/api/domains/[domain]/transfer/route.ts (1)

105-115: Optional: preflight for destination domain conflicts and wrap in try/catch to tailor errors.

While unlikely, defensive checks can turn a DB unique error into a user-friendly response.

-    const domainResponse = await prisma.domain.update({
+    const existsInDest = newWorkspace.domains.some((d) => d.slug === domain);
+    if (existsInDest) {
+      throw new DubApiError({
+        code: "conflict",
+        message: `Workspace ${newWorkspace.name} already has this domain.`,
+      });
+    }
+    const domainResponse = await prisma.domain.update({
       where: { slug: domain, projectId: workspace.id },
       data: {
         projectId: newWorkspaceId,
         primary: newWorkspace.domains.length === 0,
       },
       include: {
         registeredDomain: true,
       },
     });

apps/web/ui/modals/transfer-domain-modal.tsx (1)

182-191: Optional: include props and onSuccess in hook deps to avoid stale closures.

Keeps the modal in sync if these change.

-  }, [showTransferDomainModal, setShowTransferDomainModal]);
+  }, [showTransferDomainModal, setShowTransferDomainModal, props, onSuccess]);

apps/web/ui/modals/transfer-link-modal.tsx (1)

174-184: Optional: include props and onSuccess in hook deps to avoid stale closures.

Matches the domain modal hook tweak.

-  }, [showTransferLinkModal, setShowTransferLinkModal]);
+  }, [showTransferLinkModal, setShowTransferLinkModal, props, onSuccess]);

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

Learnt from: TWilson023
PR: dubinc/dub#2736
File: apps/web/lib/swr/use-bounty.ts:11-16
Timestamp: 2025-08-26T15:05:55.081Z
Learning: In the Dub codebase, workspace authentication and route structures prevent endless loading states when workspaceId or similar route parameters are missing, so gating SWR loading states on parameter availability is often unnecessary.