apps/web/app/(ee)/api/bounties/[bountyId]/route.ts (1)

218-227: Remove commented-out code.

The commented notification logic should be removed rather than left in the codebase. If this code might be needed in the future, document the decision in a comment or track it in an issue.

Apply this diff to remove the dead code:

-        // sendNotificationEmails &&
-        //   // if bounty.startsAt was updated, publish a new message to the queue
-        //   updatedBounty.startsAt.getTime() !== bounty.startsAt.getTime() &&
-        //   qstash.publishJSON({
-        //     url: `${APP_DOMAIN_WITH_NGROK}/api/cron/bounties/notify-partners`,
-        //     body: {
-        //       bountyId: updatedBounty.id,
-        //     },
-        //     notBefore: Math.floor(updatedBounty.startsAt.getTime() / 1000),
-        //   }),
       ]),

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

Learnt from: TWilson023
PR: dubinc/dub#2736
File: apps/web/app/api/workspaces/[idOrSlug]/notification-preferences/route.ts:13-14
Timestamp: 2025-08-26T14:20:23.943Z
Learning: The updateNotificationPreference action in apps/web/lib/actions/update-notification-preference.ts already handles all notification preference types dynamically, including newBountySubmitted, through its schema validation using the notificationTypes enum and Prisma's dynamic field update pattern.

apps/web/app/app.dub.co/(dashboard)/[slug]/(ee)/program/bounties/confirm-create-bounty-modal.tsx (1)

137-139: Consider more explicit boolean coercion.

The onCheckedChange callback receives checked which can be true | false | 'indeterminate' from Radix UI. While Boolean('indeterminate') evaluates to true, it would be clearer to use checked === true to be explicit about the intended behavior, even though this checkbox doesn't use the indeterminate state.

Apply this diff for more explicit handling:

-              onCheckedChange={(checked) =>
-                setSendNotificationEmails(Boolean(checked))
-              }
+              onCheckedChange={(checked) =>
+                setSendNotificationEmails(checked === true)
+              }

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

apps/web/app/(ee)/api/bounties/route.ts (1)

163-165: Return 403 when sendNotificationEmails is requested but not allowed.

Avoid silently ignoring a client’s request; fail fast with a clear error. This aligns API behavior with UI gating and prevents confusing no‑ops.

@@
-    const { canSendEmailCampaigns } = getPlanCapabilities(workspace.plan);
+    const { canSendEmailCampaigns } = getPlanCapabilities(workspace.plan);
+    if (sendNotificationEmails && !canSendEmailCampaigns) {
+      throw new DubApiError({
+        code: "forbidden",
+        message: "Bounty notifications are not available on your plan.",
+      });
+    }
@@
-        sendNotificationEmails &&
-          canSendEmailCampaigns &&
+        sendNotificationEmails &&
+          canSendEmailCampaigns &&
           qstash.publishJSON({

Also applies to: 270-303

apps/web/app/app.dub.co/(dashboard)/[slug]/(ee)/program/bounties/confirm-create-bounty-modal.tsx (1)

46-49: Nice fix on default state.

Initializing from canSendEmailCampaigns resolves the previous UI inconsistency.

apps/web/ui/partners/partners-upgrade-modal.tsx (2)

218-238: Use semantic list markup for features and tighten icon typing.

• elements should live inside a
  /
  for a11y/semantics.
  1. Indexing PLAN_FEATURE_ICONS with a string id can yield implicit any; cast to a typed Record to satisfy TS.

  Apply:

  -            {features.map(({ id, text, tooltip }) => {
  -              const Icon =
  -                id && PLAN_FEATURE_ICONS[id] ? PLAN_FEATURE_ICONS[id] : Check;
  +            {features.map(({ id, text, tooltip }) => {
  +              const Icon =
  +                (PLAN_FEATURE_ICONS as Record<string, import("@/../packages/ui/src/icons").Icon>)[id] ??
  +                Check;
                 return (
  -                <li
  +                <li
                     key={id}
                     className="flex items-center gap-2 text-neutral-600"
                   >
                     <Icon className="size-3 shrink-0 [&_*]:stroke-2" />

  And wrap the list with a semantic container (change outside the mapped block):

  -          <div className="mt-6 flex flex-col gap-2 text-sm">
  +          <ul role="list" className="mt-6 flex flex-col gap-2 text-sm">
   ...
  -          </div>
  +          </ul>

  ---

  89-97: Consider formatting the groups count for consistency.

  If plan.limits.groups can be 1,000+, use nFormatter to match payouts formatting. Example:

  -            text: `${plan.limits.groups} partner groups`,
  +            text: `${nFormatter(plan.limits.groups)} partner groups`,

apps/web/app/app.dub.co/(dashboard)/[slug]/(ee)/program/messages/messages-upsell.tsx (1)

53-57: Minor a11y: hint intent to open a dialog.

Add aria attributes to make the button’s behavior clearer to assistive tech.

-          <Button
-            onClick={() => setShowPartnersUpgradeModal(true)}
-            text="Upgrade to Advanced"
-            className="h-8 px-3"
-          />
+          <Button
+            onClick={() => setShowPartnersUpgradeModal(true)}
+            text="Upgrade to Advanced"
+            className="h-8 px-3"
+            aria-haspopup="dialog"
+            aria-expanded="false"
+          />

apps/web/app/app.dub.co/(dashboard)/[slug]/settings/(basic-layout)/integrations/[integrationSlug]/page-client.tsx (1)

274-283: Gating condition looks good; two small nits.

• Brand: “HubSpot” (capital S).
• Guard for undefined workspaceId to avoid the non‑null assertion crash if the user clicks before workspace loads.

Apply:

-                      title="Hubspot integration is only available on Business plans and above. Upgrade to get started."
+                      title="HubSpot integration is only available on Business plans and above. Upgrade to get started."

And defensively guard the click handler:

-                  execute({
-                    workspaceId: workspaceId!,
+                  if (!workspaceId) {
+                    toast.error("Workspace is still loading. Please try again.");
+                    return;
+                  }
+                  execute({
+                    workspaceId,
                     integrationSlug: integration.slug,
                   });

apps/web/app/app.dub.co/(dashboard)/[slug]/(ee)/program/bounties/confirm-create-bounty-modal.tsx (1)

46-50: Resync default when the modal opens to avoid stale state.

If plan loads after mount, the initial false won’t flip to true. Reinitialize on open.

-import { Dispatch, SetStateAction, useState } from "react";
+import { Dispatch, SetStateAction, useEffect, useState } from "react";
@@
   const [sendNotificationEmails, setSendNotificationEmails] = useState(
     canSendEmailCampaigns,
   );
+  useEffect(() => {
+    if (showConfirmCreateBountyModal) {
+      setSendNotificationEmails(canSendEmailCampaigns);
+    }
+  }, [showConfirmCreateBountyModal, canSendEmailCampaigns]);

Also applies to: 65-77

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro