apps/web/lib/partnerstack/import-groups.ts (1)

23-26: Improve error message specificity.

The validation logic is correctly placed, but the error message doesn't indicate which field is missing. Consider providing more specific feedback.

Apply this diff to improve the error message:

-  if (!program.domain || !program.url) {
-    throw new Error("Program domain or URL is not set.");
-  }
+  if (!program.domain) {
+    throw new Error("Program domain is not set.");
+  }
+  if (!program.url) {
+    throw new Error("Program URL is not set.");
+  }

apps/web/lib/rewardful/import-campaigns.ts (2)

25-28: Improve error message specificity.

The error message doesn't indicate which field is missing. Consider providing more specific feedback.

Apply this diff:

-  if (!program.domain || !program.url) {
-    throw new Error("Program domain or URL is not set.");
-  }
+  if (!program.domain) {
+    throw new Error("Program domain is not set.");
+  }
+  if (!program.url) {
+    throw new Error("Program URL is not set.");
+  }

---

14-28: Consider extracting shared validation logic.

Both import-groups.ts and import-campaigns.ts have identical logic for fetching and validating program domain/url. Consider extracting this into a shared utility function to reduce duplication and improve maintainability.

Example shared utility:

// lib/utils/validate-program.ts
export async function validateProgramDomainAndUrl(programId: string) {
  const program = await prisma.program.findUniqueOrThrow({
    where: { id: programId },
    select: {
      workspaceId: true,
      domain: true,
      url: true,
    },
  });

  if (!program.domain) {
    throw new Error("Program domain is not set.");
  }
  if (!program.url) {
    throw new Error("Program URL is not set.");
  }

  return program;
}

Then use it in both import flows:

const program = await validateProgramDomainAndUrl(programId);

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

apps/web/lib/rewardful/import-campaigns.ts (1)

66-75: Default link is created only on group creation; existing groups won’t get one.

Upsert’s update: {} means re-runs won’t backfill a default link for already-existing groups. If backfill is desired, add a post-upsert check and create when missing (safer than connectOrCreate here, since we don’t have the group id inside update):

// Right after obtaining createdGroup (before creating reward):
if (program.domain && program.url) {
  const existing = await prisma.partnerGroupDefaultLink.findFirst({
    where: { programId, partnerGroupId: createdGroup.id },
  });
  if (!existing) {
    await prisma.partnerGroupDefaultLink.create({
      data: {
        id: createId({ prefix: "pgdl_" }),
        programId,
        partnerGroupId: createdGroup.id,
        domain: program.domain,
        url: program.url,
      },
    });
  }
}

If the schema has a unique key like programId_partnerGroupId on PartnerGroupDefaultLink, we could alternatively use connectOrCreate on a follow-up prisma.partnerGroup.update. Please confirm model name/unique constraints to pick the best approach.

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro