apps/web/lib/zod/schemas/partner-profile.ts (1)

177-192: Use discriminatedUnion and strict objects for faster, safer parsing.

Current union works; a discriminated union on field improves inference and performance and .strict() prevents stray keys. Optional: default to [].

Apply:

-export const partnerProfileChangeHistoryLogSchema = z.array(
-  z.union([
-    z.object({
-      field: z.literal("country"),
-      from: z.string().nullable(),
-      to: z.string().nullable(),
-      changedAt: z.coerce.date(),
-    }),
-    z.object({
-      field: z.literal("profileType"),
-      from: z.nativeEnum(PartnerProfileType),
-      to: z.nativeEnum(PartnerProfileType),
-      changedAt: z.coerce.date(),
-    }),
-  ]),
-);
+export const partnerProfileChangeHistoryLogSchema = z
+  .array(
+    z.discriminatedUnion("field", [
+      z
+        .object({
+          field: z.literal("country"),
+          from: z.string().nullable(),
+          to: z.string().nullable(),
+          changedAt: z.coerce.date(),
+        })
+        .strict(),
+      z
+        .object({
+          field: z.literal("profileType"),
+          from: z.nativeEnum(PartnerProfileType),
+          to: z.nativeEnum(PartnerProfileType),
+          changedAt: z.coerce.date(),
+        })
+        .strict(),
+    ]),
+  )
+  .default([]);

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

apps/web/lib/actions/partners/update-partner-profile.ts (2)

279-282: Parse defensively to avoid crashes on malformed JSON.

Switch to safeParse with fallback to [] to avoid throwing if the stored JSON is malformed. This was already suggested in earlier feedback.

---

283-290: Null-safe assignment for country “to”.

Use input.country ?? null instead of a string assertion. This matches the schema’s .nullable() and avoids incorrect typing. Previously noted; echoing for completeness.

-      to: input.country as string,
+      to: input.country ?? null,

packages/prisma/schema/partner.prisma (1)

61-61: Consider defaulting JSON and/or making it non-null.

To reduce null checks and parsing pitfalls, consider storing an empty array by default and making this non-null (DB default jsonb '[]', then NOT NULL). If you prefer keeping it nullable, ensure all reads use safeParse with fallback.

apps/web/lib/zod/schemas/partner-profile.ts (1)

177-192: Use discriminated union and export the type.

Improves inference and narrowing; keeps shape explicit.

-export const partnerProfileChangeHistoryLogSchema = z.array(
-  z.union([
-    z.object({
-      field: z.literal("country"),
-      from: z.string().nullable(),
-      to: z.string().nullable(),
-      changedAt: z.coerce.date(),
-    }),
-    z.object({
-      field: z.literal("profileType"),
-      from: z.nativeEnum(PartnerProfileType),
-      to: z.nativeEnum(PartnerProfileType),
-      changedAt: z.coerce.date(),
-    }),
-  ]),
-);
+export const partnerProfileChangeHistoryLogSchema = z.array(
+  z.discriminatedUnion("field", [
+    z.object({
+      field: z.literal("country"),
+      from: z.string().nullable(),
+      to: z.string().nullable(),
+      changedAt: z.coerce.date(),
+    }),
+    z.object({
+      field: z.literal("profileType"),
+      from: z.nativeEnum(PartnerProfileType),
+      to: z.nativeEnum(PartnerProfileType),
+      changedAt: z.coerce.date(),
+    }),
+  ]),
+);
+
+export type PartnerProfileChangeHistoryLog = z.infer<
+  typeof partnerProfileChangeHistoryLogSchema
+>;

apps/web/lib/actions/partners/update-partner-profile.ts (1)

301-314: Reorder DB update before Stripe deletion; make deletion idempotent and async.

Avoid inconsistent audit/state if the later update fails, and don’t fail the entire action on already-deleted accounts.

-  if (partner.stripeConnectId) {
-    await stripe.accounts.del(partner.stripeConnectId);
-  }
-
-  await prisma.partner.update({
+  // First persist app state + history
+  await prisma.partner.update({
     where: {
       id: partner.id,
     },
     data: {
       stripeConnectId: null,
       changeHistoryLog: partnerChangeHistoryLog,
     },
   });
+
+  // Then delete the Stripe account best-effort (idempotent)
+  if (partner.stripeConnectId) {
+    waitUntil(
+      (async () => {
+        try {
+          await stripe.accounts.del(partner.stripeConnectId!);
+        } catch (err: any) {
+          // Treat not found as success; rethrow others
+          const code = err?.statusCode ?? err?.raw?.statusCode;
+          if (code !== 404) throw err;
+        }
+      })(),
+    );
+  }

Optional: cap history length to prevent unbounded growth.

-  if (countryChanged) {
+  if (countryChanged) {
     partnerChangeHistoryLog.push({ /* ... */ });
+    // keep last 100
+    if (partnerChangeHistoryLog.length > 100) {
+      partnerChangeHistoryLog.splice(0, partnerChangeHistoryLog.length - 100);
+    }
   }

If you prefer stronger consistency, wrap a re-read/merge in a short transaction to avoid lost updates when multiple writers appear in the future. I can provide a transactional snippet if useful.

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro