apps/web/tests/utils/verify-commission.ts (1)

24-24: Consider making the delay configurable.

The hard-coded 2-second delay may cause flaky tests if the system is slow, or waste time if the system is fast. Consider making it configurable or using a retry mechanism with polling.

Example with configurable delay:

+ const COMMISSION_PROCESSING_DELAY = parseInt(process.env.E2E_COMMISSION_DELAY || "2000");
+
  export const verifyCommission = async ({
    http,
    customerExternalId,
    expectedEarnings,
  }: {
    http: HttpClient;
    customerExternalId: string;
    expectedEarnings: number;
  }) => {
    // Find the customer first
    const { data: customers } = await http.get<Customer[]>({
      path: "/customers",
      query: {
        externalId: customerExternalId,
      },
    });

    const customer = customers[0];

-   await new Promise((resolve) => setTimeout(resolve, 2000));
+   await new Promise((resolve) => setTimeout(resolve, COMMISSION_PROCESSING_DELAY));

apps/web/tests/rewards/index.test.ts (1)

16-128: Reduce test duplication using parameterized tests.

The three test cases follow an identical structure with only the partner data and expected earnings changing. Consider refactoring using test.each to reduce duplication and improve maintainability.

Apply this refactor:

-  test("when {Partner} {Country} is {US}", async () => {
-    // Track the click
-    const clickResponse = await http.post<{ clickId: string }>({
-      path: "/track/click",
-      headers: E2E_TRACK_CLICK_HEADERS,
-      body: {
-        ...E2E_PARTNERS[0].shortLink,
-      },
-    });
-
-    expect(clickResponse.status).toEqual(200);
-
-    const clickId = clickResponse.data.clickId;
-    const customer = randomCustomer();
-
-    // Track the lead
-    const trackLeadResponse = await http.post<TrackLeadResponse>({
-      path: "/track/lead",
-      body: {
-        clickId,
-        eventName: "Signup",
-        customerExternalId: customer.externalId,
-        customerName: customer.name,
-        customerEmail: customer.email,
-        customerAvatar: customer.avatar,
-      },
-    });
-
-    expect(trackLeadResponse.status).toEqual(200);
-
-    // Verify the commission
-    await verifyCommission({
-      http,
-      customerExternalId: customer.externalId,
-      expectedEarnings: E2E_LEAD_REWARD.modifiers[0].amountInCents,
-    });
-  });
-
-  test("when {Partner} {Country} is {CA}", async () => {
-    // Track the click
-    const clickResponse = await http.post<{ clickId: string }>({
-      path: "/track/click",
-      headers: E2E_TRACK_CLICK_HEADERS,
-      body: {
-        ...E2E_PARTNERS[1].shortLink,
-      },
-    });
-
-    expect(clickResponse.status).toEqual(200);
-
-    const clickId = clickResponse.data.clickId;
-    const customer = randomCustomer();
-
-    // Track the lead
-    const trackLeadResponse = await http.post<TrackLeadResponse>({
-      path: "/track/lead",
-      body: {
-        clickId,
-        eventName: "Signup",
-        customerExternalId: customer.externalId,
-        customerName: customer.name,
-        customerEmail: customer.email,
-        customerAvatar: customer.avatar,
-      },
-    });
-
-    expect(trackLeadResponse.status).toEqual(200);
-
-    // Verify the commission
-    await verifyCommission({
-      http,
-      customerExternalId: customer.externalId,
-      expectedEarnings: E2E_LEAD_REWARD.modifiers[1].amountInCents,
-    });
-  });
-
-  test("when {Partner} {Country} is not {US} or {CA}", async () => {
-    // Track the click
-    const clickResponse = await http.post<{ clickId: string }>({
-      path: "/track/click",
-      headers: E2E_TRACK_CLICK_HEADERS,
-      body: {
-        ...E2E_PARTNERS[2].shortLink,
-      },
-    });
-
-    expect(clickResponse.status).toEqual(200);
-
-    const clickId = clickResponse.data.clickId;
-    const customer = randomCustomer();
-
-    // Track the lead
-    const trackLeadResponse = await http.post<TrackLeadResponse>({
-      path: "/track/lead",
-      body: {
-        clickId,
-        eventName: "Signup",
-        customerExternalId: customer.externalId,
-        customerName: customer.name,
-        customerEmail: customer.email,
-        customerAvatar: customer.avatar,
-      },
-    });
-
-    expect(trackLeadResponse.status).toEqual(200);
-
-    // Verify the commission
-    await verifyCommission({
-      http,
-      customerExternalId: customer.externalId,
-      expectedEarnings: E2E_LEAD_REWARD.amountInCents,
-    });
-  });
+  test.each([
+    {
+      country: "US",
+      partnerIndex: 0,
+      expectedEarnings: E2E_LEAD_REWARD.modifiers[0].amountInCents,
+    },
+    {
+      country: "CA",
+      partnerIndex: 1,
+      expectedEarnings: E2E_LEAD_REWARD.modifiers[1].amountInCents,
+    },
+    {
+      country: "IN",
+      partnerIndex: 2,
+      expectedEarnings: E2E_LEAD_REWARD.amountInCents,
+    },
+  ])("when {Partner} {Country} is {$country}", async ({ partnerIndex, expectedEarnings }) => {
+    // Track the click
+    const clickResponse = await http.post<{ clickId: string }>({
+      path: "/track/click",
+      headers: E2E_TRACK_CLICK_HEADERS,
+      body: {
+        ...E2E_PARTNERS[partnerIndex].shortLink,
+      },
+    });
+
+    expect(clickResponse.status).toEqual(200);
+
+    const clickId = clickResponse.data.clickId;
+    const customer = randomCustomer();
+
+    // Track the lead
+    const trackLeadResponse = await http.post<TrackLeadResponse>({
+      path: "/track/lead",
+      body: {
+        clickId,
+        eventName: "Signup",
+        customerExternalId: customer.externalId,
+        customerName: customer.name,
+        customerEmail: customer.email,
+        customerAvatar: customer.avatar,
+      },
+    });
+
+    expect(trackLeadResponse.status).toEqual(200);
+
+    // Verify the commission
+    await verifyCommission({
+      http,
+      customerExternalId: customer.externalId,
+      expectedEarnings,
+    });
+  });

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

apps/web/tests/utils/verify-commission.ts (4)

32-34: Replace fixed sleep with polling + timeout to de-flake tests.

A hard 2s wait may be too short or excessive. Poll /commissions with a timeout instead.

Apply this diff:

-    // Small delay if necessary for async commission processing
-    await new Promise((resolve) => setTimeout(resolve, 2000));
+    // Defer commission check; actual waiting handled by polling below

And replace the single GET + assertions with polling:

-  const { status, data: commissions } = await http.get<CommissionResponse[]>({
-    path: "/commissions",
-    query,
-  });
-
-  expect(status).toEqual(200);
-  expect(commissions).toHaveLength(1);
-
-  const commission = commissions[0];
+  // Poll until exactly one commission is available (or timeout)
+  const maxAttempts = 10;
+  const intervalMs = 500;
+  let commission: CommissionResponse | undefined;
+  for (let attempt = 1; attempt <= maxAttempts; attempt++) {
+    const { status, data } = await http.get<CommissionResponse[]>({
+      path: "/commissions",
+      query,
+    });
+    expect(status).toEqual(200);
+    if (data.length === 1) {
+      commission = data[0];
+      break;
+    }
+    await new Promise((r) => setTimeout(r, intervalMs));
+  }
+  if (!commission) {
+    throw new Error(
+      `Timed out waiting for a single commission with query=${JSON.stringify(
+        query
+      )}`
+    );
+  }

Also applies to: 46-53

---

24-31: Make customer resolution deterministic and error-friendly.

Strengthen the check to fail fast if multiple or zero customers are returned. Include the externalId in the error for debugging.

Apply this diff:

-    expect(customers.length).toBeGreaterThan(0);
-    customerId = customers[0].id;
+    if (customers.length !== 1) {
+      throw new Error(
+        `Expected exactly 1 customer for externalId=${customerExternalId}, got ${customers.length}`
+      );
+    }
+    customerId = customers[0].id;

---

64-69: Optional: allow tolerance for computed percentages.

If earnings can be percentage-based, rounding may differ. Consider allowing a tolerance or use integer math upstream. If you keep exact equality, ensure all callers compute integers (e.g., Math.round(amount * pct / 100)).

---

13-19: Add types to function return for clarity.

Explicitly annotate the promise: : Promise<void> on verifyCommission for consistency with exported signature.

apps/web/tests/tracks/track-sale.test.ts (4)

111-113: Centralize waiting in verifyCommission (avoid fixed sleeps in tests).

If you adopt polling in verifyCommission, drop this 2s pause here to speed up and deflake the suite.

---

114-119: Avoid brittle index access for modifiers (use find).

Accessing modifiers[0] assumes order. Prefer finding the premium product modifier by condition.

Example:

const premiumFlat = E2E_SALE_REWARD.modifiers.find(
  (m) => m.type === "flat" && m.conditions.some(
    c => c.entity === "sale" && c.attribute === "productId" && c.value === "premiumProductId"
  )
)!;
await verifyCommission({ http, invoiceId: premiumInvoiceId, expectedAmount: response2.data.sale!.amount!, expectedEarnings: premiumFlat.amountInCents! });

---

121-126: Same as above for premium case.

Replace modifiers[0] with a condition-based lookup to avoid future order changes breaking tests.

---

296-308: Find the “large amount” modifier by rule, not index.

Replace modifiers[1] with a lookup where sale.amount > 15000 condition is present.

apps/web/tests/rewards/sale-reward.test.ts (2)

31-36: Derive the 10% from the resource to prevent drift.

Avoid hardcoding 0.1. Read the percentage from E2E_SALE_REWARD to keep tests aligned with data.

Example:

const pct = E2E_SALE_REWARD.modifiers.find(
  (m) => m.type === "percentage" &&
         m.conditions.some(c => c.entity === "customer" && c.attribute === "country" && c.value === "US")
)!.amountInPercentage!;
const expected = Math.round((saleAmount * pct) / 100);
await verifyCommission({ http, invoiceId, expectedEarnings: expected });

---

39-65: Clarify reward semantics before unskipping.

CA has a flat 50 modifier in resources, but the test expects base amount. Confirm whether modifiers override, add to, or replace base, then update assertion and unskip accordingly.

apps/web/tests/rewards/lead-reward.test.ts (1)

46-51: LGTM; will benefit from helper polling.

The flow is sound. Once verifyCommission polls, no extra waits needed here.

apps/web/tests/utils/resource.ts (1)

47-60: Export named modifier handles to avoid index coupling.

Tests refer to modifiers[0/1]. Provide named exports (e.g., E2E_SALE_REWARD_PREMIUM_PRODUCT_FLAT, E2E_SALE_REWARD_LARGE_AMOUNT_FLAT, E2E_SALE_REWARD_US_PERCENT, E2E_SALE_REWARD_CA_FLAT) or attach keyed properties to E2E_SALE_REWARD to stabilize references.

Also applies to: 62-74, 75-88, 89-102

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro