Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Update link styling in ProgramHelpLinks #3035

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
steven-tey merged 1 commit into from
Oct 31, 2025
Merged

Update link styling in ProgramHelpLinks #3035

steven-tey merged 1 commit into from
Oct 31, 2025

Conversation

@marcusljf
Copy link
Collaborator

@marcusljf marcusljf commented Oct 30, 2025 •
edited by coderabbitai bot
Loading

Added w-full and px-2.5 to the link class for improved layout and consistent padding in the ProgramHelpLinks component.

The link starting position was off to the right. I think this had carried over from an earlier version we had.

Before
CleanShot 2025-10-30 at 16 32 39@2x

After
CleanShot 2025-10-30 at 16 32 22@2x

Summary by CodeRabbit

  • Style
    • Enhanced partner program help links with full-width layout and consistent padding styling for improved usability and visual presentation.

@marcusljf
Update link styling in ProgramHelpLinks
0a65b2e 
Added w-full and px-2.5 to the link class for improved layout and consistent padding in the ProgramHelpLinks component.
@vercel
Copy link
Contributor

vercel bot commented Oct 30, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Updated (UTC)
dub Ready Ready Preview Oct 30, 2025 11:40pm

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Oct 30, 2025 •
edited
Loading

Walkthrough

Updated anchor element styling in the partners program help links component by converting hover-based horizontal padding to constant padding and adding full width behavior. Layout and other styling properties remain unchanged.

Changes

Cohort / File(s) Summary
Partner Help Links Styling
apps/web/ui/partners/program-help-links.tsx		 Changed anchor element padding from hover-only (hover:px-2.5) to always-on (px-2.5), added w-full class for full width, and reordered padding declarations while maintaining spacing semantics

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

  • Single file with localized CSS class modifications
  • No logic or behavioral changes beyond styling
  • Straightforward padding and width adjustments

Possibly related PRs

Suggested reviewers

  • steven-tey

Poem

🐰 A hop, a skip, a styling twist,
From hover-dance to constant bliss,
Full width padding, steady and true,
The links now stretch in morning dew! ✨

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. You can run @coderabbitai generate docstrings to improve docstring coverage.
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title Check ✅ Passed The PR title "Update link styling in ProgramHelpLinks" is concise, clear, and directly related to the main change in the changeset. It accurately identifies both the primary action (updating link styling) and the specific component being modified (ProgramHelpLinks). The title avoids noise and vague terminology, providing enough specificity that a teammate reviewing the commit history would understand the purpose of the change without needing to examine the full diff. While the title doesn't enumerate specific styling changes like the addition of w-full or the conversion from hover-based to permanent padding, this level of detail is not expected for a PR title.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch partner-support-nav
📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 33de46c and 0a65b2e.

📒 Files selected for processing (1)
  • apps/web/ui/partners/program-help-links.tsx (1 hunks)
🧰 Additional context used
🧠 Learnings (1)
📚 Learning: 2025-07-09T20:52:56.592Z 
Learnt from: TWilson023
Repo: dubinc/dub PR: 2614
File: apps/web/ui/partners/design/previews/lander-preview.tsx:181-181
Timestamp: 2025-07-09T20:52:56.592Z
Learning: In apps/web/ui/partners/design/previews/lander-preview.tsx, the ellipsis wave animation delay calculation `3 - i * -0.15` is intentionally designed to create negative delays that offset each dot's animation cycle. This pattern works correctly for the intended ellipsis effect and should not be changed to positive incremental delays.

Applied to files:

  • apps/web/ui/partners/program-help-links.tsx
🔇 Additional comments (1)
apps/web/ui/partners/program-help-links.tsx (1)

54-54: LGTM! Improves accessibility and prevents layout shift.

The changes effectively address the alignment issue mentioned in the PR:

  • w-full ensures the full grid cell width is clickable, improving the click target size
  • Moving px-2.5 from hover-only to always-on prevents content from jumping when users hover, providing a better user experience
  • Consistent padding aligns the text properly from the start

The hover feedback is still clearly visible through the background color transitions.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@steven-tey steven-tey merged commit 2c378e7 into main Oct 31, 2025
8 of 9 checks passed
@steven-tey steven-tey deleted the partner-support-nav branch October 31, 2025 02:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@steven-tey steven-tey steven-tey approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@marcusljf @steven-tey