Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Skip sending email if the batch is empty #3038

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
steven-tey merged 1 commit into from
Oct 31, 2025
Merged

Skip sending email if the batch is empty #3038

steven-tey merged 1 commit into from
Oct 31, 2025

Conversation

@devkiran
Copy link
Collaborator

@devkiran devkiran commented Oct 31, 2025 •
edited by coderabbitai bot
Loading

Summary by CodeRabbit

  • Bug Fixes
    • Optimized batch email sending to prevent unnecessary API calls when processing empty queues.

@vercel
Copy link
Contributor

vercel bot commented Oct 31, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Updated (UTC)
dub Ready Ready Preview Oct 31, 2025 0:14am

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Oct 31, 2025 •
edited
Loading

Walkthrough

Added an early return guard in sendBatchEmailViaResend that returns { data: null, error: null } immediately when the input array is empty, eliminating an unnecessary API call to the resend batch endpoint.

Changes

Cohort / File(s) Summary
Email batch send optimization
packages/email/src/send-via-resend.ts		 Added early guard condition to return early with null values when opts array is empty, preventing unnecessary resend.batch.send API call

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

  • Straightforward early-exit guard based on array length check
  • No API contract changes or logic modifications beyond control flow
  • Low risk of unintended side effects

Poem

🐰 A guard clause hops ahead so spry,
Skipping empty batches—why send null to the sky?
No API call for nothing, just a swift return,
Efficiency blooms when guards are what we learn! 🌿

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. You can run @coderabbitai generate docstrings to improve docstring coverage.
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title Check ✅ Passed The pull request title "Skip sending email if the batch is empty" directly and accurately describes the main change in the changeset. The modification adds an early guard that checks if the input array is empty and returns early without invoking the resend API, which is precisely what the title conveys. The title is concise, clear, and uses specific language that would help a teammate scanning the commit history understand the purpose of the change without ambiguity.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch fix-resend-404
📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 6784533 and 9556ea4.

📒 Files selected for processing (1)
  • packages/email/src/send-via-resend.ts (1 hunks)
🧰 Additional context used
🧠 Learnings (1)
📓 Common learnings 
Learnt from: steven-tey
Repo: dubinc/dub PR: 2951
File: apps/web/scripts/migrations/backfill-submission-completedat.ts:16-24
Timestamp: 2025-10-09T19:50:25.662Z
Learning: Skip reviewing changes in the `scripts/` directory for the dubinc/dub repository.
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
  • GitHub Check: build
🔇 Additional comments (1)
packages/email/src/send-via-resend.ts (1)

69-74: LGTM! Good defensive programming.

The early return guard correctly prevents an unnecessary API call when the batch is empty. The return value { data: null, error: null } is consistent with the existing no-resend case and appropriately treats the empty batch as a successful no-op rather than an error.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@devkiran devkiran requested a review from steven-tey October 31, 2025 12:11
@steven-tey steven-tey merged commit 3334f1a into main Oct 31, 2025
9 checks passed
@steven-tey steven-tey deleted the fix-resend-404 branch October 31, 2025 15:35
@coderabbitai coderabbitai bot mentioned this pull request Oct 31, 2025
Merged
@coderabbitai coderabbitai bot mentioned this pull request Nov 15, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@steven-tey steven-tey steven-tey approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@devkiran @steven-tey