Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Fix /links/domains/email page not loading #3052

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
steven-tey merged 1 commit into from
Nov 2, 2025
Merged

Fix /links/domains/email page not loading #3052

steven-tey merged 1 commit into from
Nov 2, 2025

Conversation

@devkiran
Copy link
Collaborator

@devkiran devkiran commented Nov 2, 2025 •
edited by coderabbitai bot
Loading

Summary by CodeRabbit

  • Refactor
    • Reorganized email domain settings navigation to improve accessibility within the dashboard.

@vercel
Copy link
Contributor

vercel bot commented Nov 2, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Updated (UTC)
dub Ready Ready Preview Nov 2, 2025 1:33pm

@devkiran devkiran requested a review from steven-tey November 2, 2025 13:28
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Nov 2, 2025 •
edited
Loading

Walkthrough

A re-export of a page component is added at a new route location, proxying the default export from an existing page module. This mirrors the same component across different URL paths without introducing new logic.

Changes

Cohort / File(s) Summary
Page re-export
apps/web/app/app.dub.co/(dashboard)/[slug]/links/domains/email/page.tsx		 Re-exports default export from ../../../settings/domains/email/page to make the component available at a new route location

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

  • Single file with a straightforward re-export statement
  • No new business logic or conditional logic introduced
  • Minimal risk of introducing bugs given the nature of the change

Poem

🐰 A path now splits, yet one remains,
The same component flows through new domains,
Where once was one, now two may roam,
The rabbit's route finds a second home! 🐇

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. You can run @coderabbitai generate docstrings to improve docstring coverage.
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title Check ✅ Passed The title "Fix /links/domains/email page not loading" accurately describes the main objective of the pull request. The changeset adds a re-export that makes the /links/domains/email page accessible and functional, directly addressing the problem stated in the title. The title is concise, specific, and clearly communicates the purpose of the change without unnecessary technical details. A teammate scanning the commit history would understand that this PR resolves a page loading issue.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch fix-email-domains
📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 5fab554 and fa7ae09.

📒 Files selected for processing (1)
  • apps/web/app/app.dub.co/(dashboard)/[slug]/links/domains/email/page.tsx (1 hunks)
🧰 Additional context used
🧠 Learnings (2)
📚 Learning: 2025-10-15T01:05:43.266Z 
Learnt from: steven-tey
Repo: dubinc/dub PR: 2958
File: apps/web/app/app.dub.co/(dashboard)/[slug]/settings/members/page-client.tsx:432-457
Timestamp: 2025-10-15T01:05:43.266Z
Learning: In apps/web/app/app.dub.co/(dashboard)/[slug]/settings/members/page-client.tsx, defer refactoring the custom MenuItem component (lines 432-457) to use the shared dub/ui MenuItem component to a future PR, as requested by steven-tey.

Applied to files:

  • apps/web/app/app.dub.co/(dashboard)/[slug]/links/domains/email/page.tsx
📚 Learning: 2025-09-19T18:46:43.787Z 
Learnt from: CR
Repo: dubinc/dub PR: 0
File: packages/hubspot-app/CLAUDE.md:0-0
Timestamp: 2025-09-19T18:46:43.787Z
Learning: Applies to packages/hubspot-app/app/settings/**/*.{js,jsx,ts,tsx} : Only use components exported by hubspot/ui-extensions in settings components

Applied to files:

  • apps/web/app/app.dub.co/(dashboard)/[slug]/links/domains/email/page.tsx
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
  • GitHub Check: build
🔇 Additional comments (1)
apps/web/app/app.dub.co/(dashboard)/[slug]/links/domains/email/page.tsx (1)

1-1: Valid Next.js route alias—source file verified.

The re-export correctly creates a route at /[slug]/links/domains/email that mirrors the settings page. The source file exists at the resolved path, confirming this is a clean solution for the page not loading issue.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@steven-tey steven-tey merged commit 7636951 into main Nov 2, 2025
9 checks passed
@steven-tey steven-tey deleted the fix-email-domains branch November 2, 2025 16:38
@coderabbitai coderabbitai bot mentioned this pull request Dec 4, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@steven-tey steven-tey steven-tey approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@devkiran @steven-tey