Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Add COMMON_CORS_HEADERS in /track/client error responses #3094

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
steven-tey merged 3 commits into from
Nov 12, 2025
Merged

Add COMMON_CORS_HEADERS in /track/client error responses #3094

steven-tey merged 3 commits into from
Nov 12, 2025

Conversation

@steven-tey
Copy link
Collaborator

@steven-tey steven-tey commented Nov 12, 2025 •
edited by coderabbitai bot
Loading

Summary by CodeRabbit

  • Refactor
    • Improved CORS header handling in authentication to ensure consistent header initialization across all response paths.

@vercel
Copy link
Contributor

vercel bot commented Nov 12, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Updated (UTC)
dub Ready Ready Preview Nov 12, 2025 5:35am

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Nov 12, 2025 •
edited
Loading

Warning

Rate limit exceeded

@steven-tey has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 18 minutes and 31 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

📥 Commits

Reviewing files that changed from the base of the PR and between 4b64272 and 74f5883.

📒 Files selected for processing (1)
  • apps/web/lib/auth/publishable-key.ts (2 hunks)

Walkthrough

The publishable-key authentication endpoint now initializes response headers by importing and using COMMON_CORS_HEADERS, pre-populating CORS headers instead of starting with an empty Headers object. This standardizes CORS header handling across all response paths, including error responses.

Changes

Cohort / File(s) Change Summary
CORS Header Initialization
apps/web/lib/auth/publishable-key.ts		 Imports COMMON_CORS_HEADERS and uses it to initialize responseHeaders, replacing empty Headers instance with pre-populated CORS headers for all code paths

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

  • Verify that COMMON_CORS_HEADERS contains the appropriate CORS directives for this endpoint
  • Confirm that pre-populating headers in all code paths (including error cases) aligns with intended CORS policy
  • Check for any potential side effects on existing response header logic

Poem

🐰 Headers hop with care so true,
CORS rules now woven through,
Pre-populated paths all shine,
Error responses align,
A cleaner auth design! ✨

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main change: adding COMMON_CORS_HEADERS to the /track/client error responses, which aligns with the file modified (publishable-key.ts) and the AI-generated summary.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@steven-tey
Copy link
Collaborator Author

steven-tey commented Nov 12, 2025

@coderabbitai full review

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Nov 12, 2025

✅ Actions performed

Full review triggered.

@steven-tey steven-tey merged commit f617c0b into main Nov 12, 2025
7 of 8 checks passed
@steven-tey steven-tey deleted the track-client-cors branch November 12, 2025 05:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@devkiran devkiran devkiran approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@steven-tey @devkiran