• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch deeplink-queryparam-passing

Reviewing files that changed from the base of the PR and between 1895c99 and 3e39d07.

• apps/web/lib/middleware/link.ts (2 hunks)

apps/web/lib/middleware/link.ts (3)

436-436: Verify URL encoding behavior with the new fullPath approach.

The previous implementation used encodeURIComponent(key), but the new code uses fullPath directly. While the URL constructor should handle this correctly, ensure that:

1. Special characters in query parameter values are properly encoded
2. Multiple query parameters are preserved correctly
3. Edge cases like # fragments, spaces, and unicode characters work as expected

Consider testing with these query parameter scenarios:

• Simple: /key?foo=bar
• Multiple params: /key?foo=bar&baz=qux
• Special chars: /key?redirect=https://example.com&message=hello world
• Unicode: /key?text=你好
• Fragments: /key?foo=bar#section

---

42-42: Verification confirms fullPath format is correct.

The parse() function constructs fullPath as ${path}${searchParamsString} where:

• path from req.nextUrl.pathname always includes a leading slash
• searchParamsString is either ?params or empty string (properly formatted)
• URL encoding is handled by Next.js URL API

This guarantees fullPath format like /key?param=value, so line 436 produces valid URLs like /deeplink/domain/key?param=value. The change is safe and correctly preserves query parameters.

---

436-436: No changes needed to the deeplink page component—the URL structure change is compatible.

The deeplink page at apps/web/app/app.dub.co/(deeplink)/deeplink/[domain]/[key]/page.tsx correctly handles the new URL structure. The route [domain]/[key] extracts parameters independently from query strings, so /deeplink/dub.co/abc123?utm=email works the same as before—params are {domain: "dub.co", key: "abc123"} with query params handled separately by Next.js. The change from encodeURIComponent(key) to fullPath is safe; fullPath preserves the original request path encoding and query parameters are maintained throughout the redirect.