The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Preview	Updated (UTC)
dub	Ready	Preview	Nov 14, 2025 9:25am

Walkthrough

The PR modifies apps/web/lib/api/conversions/track-sale.ts to remove unused ClickEventTB type imports and its associated local declaration, while introducing a validation guard that skips processing when sale amounts are non-positive, logging a conversion event before early exit.

Changes

Sequence Diagram

sequenceDiagram
    participant Caller
    participant trackSale
    participant _trackSale
    participant Logger

    Caller->>trackSale: call trackSale(params)
    trackSale->>_trackSale: call _trackSale(params)
    
    rect rgb(240, 248, 255)
    Note over _trackSale: New validation path
    alt amount <= 0
        _trackSale->>Logger: log conversion event
        _trackSale-->>trackSale: return {eventName, customer: null, sale: null}
    else amount > 0
        Note over _trackSale: Existing currency conversion logic
        _trackSale->>_trackSale: handle currency conversion
        _trackSale-->>trackSale: return sale data
    end
    end
    
    trackSale-->>Caller: return result

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

• Areas requiring attention:
  • Verify the new guard clause logic correctly identifies and logs non-positive amounts
  • Confirm the early-exit behavior (returning null customer and sale) aligns with downstream expectations
  • Ensure removal of ClickEventTB doesn't break any remaining references in the codebase

Possibly related PRs

• Allow automatic lead event creation in track/sale #2818: Directly related—removes ClickEventTB and clickData from the same file while adding early-exit validation for non-positive amounts
• Add lead params to /track/sale/client #2822: Modifies the same trackSale data flow by passing additional lead parameters (including clickId) into the function
• Add missing conversion log + nav changes #2678: Affects the same conversion-logging/error paths in track-sale.ts with centralized error messaging

Poem

🐰 ClickEventTB, now goodbye—
No more clickData cluttering by,
With guards for amounts that won't grow,
Zero sales get logged, then off they go! 🎯✨

Pre-merge checks and finishing touches

Learnt from: steven-tey
Repo: dubinc/dub PR: 2951
File: apps/web/scripts/migrations/backfill-submission-completedat.ts:16-24
Timestamp: 2025-10-09T19:50:25.662Z
Learning: Skip reviewing changes in the `scripts/` directory for the dubinc/dub repository.

Learnt from: steven-tey
Repo: dubinc/dub PR: 2924
File: apps/web/lib/api/conversions/track-lead.ts:7-7
Timestamp: 2025-10-02T22:46:22.739Z
Learning: In apps/web/lib/api/conversions/track-lead.ts, lead events are cached in Redis for 5 minutes (keys: `leadCache:${customer.id}` and `leadCache:${customer.id}:${stringifiedEventName}`) to provide immediate data availability while Tinybird ingestion happens asynchronously. This caching pattern allows for async-only recording without breaking "wait" mode semantics.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

_{Comment @coderabbitai help to get the list of available commands and usage tips.}