Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Include searchParamsString for isGooglePlayStoreUrl #3119

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
steven-tey merged 1 commit into from
Nov 17, 2025
Merged

Include searchParamsString for isGooglePlayStoreUrl #3119

steven-tey merged 1 commit into from
Nov 17, 2025

Conversation

@steven-tey
Copy link
Collaborator

@steven-tey steven-tey commented Nov 17, 2025 •
edited by coderabbitai bot
Loading

Summary by CodeRabbit

  • Bug Fixes
    • Enhanced handling of URL query parameters to ensure proper data transmission in platform integrations.

@vercel
Copy link
Contributor

vercel bot commented Nov 17, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Updated (UTC)
dub Ready Ready Preview Nov 17, 2025 5:33pm

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Nov 17, 2025 •
edited
Loading

Walkthrough

The change modifies Google Play Store URL handling in the final URL utility by restructuring how query parameters are appended to the shortLink. The deepLink value now concatenates the shortLink with searchParamsString, altering how referrer parameters are constructed.

Changes

Cohort / File(s) Summary
URL Query Parameter Handling
apps/web/lib/middleware/utils/get-final-url.ts		 Destructures parse(req) to extract shortLink and searchParamsString, then concatenates them to update the deepLink value for Google Play Store URLs.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

  • Single-file change with straightforward string concatenation logic
  • Focused modification to Google Play Store URL construction path
  • Verify the order of concatenation and query parameter format correctness

Possibly related PRs

Suggested reviewers

  • devkiran

Poem

🐰 A shortLink meets its query string so fine,
Concatenated together in perfect line!
The deepLink grows with params appended with care,
Google Play Store URLs handled with flair! ✨

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and specifically describes the main change: including searchParamsString in the Google Play Store URL handling logic.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch include-sp-deeplink
📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between ea19829 and 55acb54.

📒 Files selected for processing (1)
  • apps/web/lib/middleware/utils/get-final-url.ts (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
  • GitHub Check: build
🔇 Additional comments (1)
apps/web/lib/middleware/utils/get-final-url.ts (1)

81-87: ****

The concatenation logic is correct. Based on the parse() function implementation:

  • shortLink is always a base URL without query params: https://domain/path
  • searchParamsString is either ?params or an empty string (never &params)

Therefore, ${shortLink}${searchParamsString} always produces valid URLs:

  • https://d.to/github + ?utm_source=x = valid
  • https://d.to/github + `` = valid

This pattern is consistently used elsewhere in the codebase (partners.ts, app.ts, workspaces.ts), confirming correctness.

Likely an incorrect or invalid review comment.

Tip

📝 Customizable high-level summaries are now available in beta!

You can now customize how CodeRabbit generates the high-level summary in your pull requests — including its content, structure, tone, and formatting.

  • Provide your own instructions using the high_level_summary_instructions setting.
  • Format the summary however you like (bullet lists, tables, contributor stats, etc.).
  • Use high_level_summary_in_walkthrough to move the summary from the description to the walkthrough section.

Example:

"Create a concise high-level summary as a bullet-point list. Then include a Markdown table showing lines added and removed by each contributing author."

Note: This feature is currently in beta for Pro-tier users, and pricing will be announced later.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@steven-tey steven-tey merged commit 7d56042 into main Nov 17, 2025
7 of 9 checks passed
@steven-tey steven-tey deleted the include-sp-deeplink branch November 17, 2025 17:42
@coderabbitai coderabbitai bot mentioned this pull request Nov 18, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@devkiran devkiran devkiran approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@steven-tey @devkiran